1. 11 Oct, 2021 4 commits
    • Aleksey Midenkov's avatar
      MDEV-22464 Server crash on UPDATE with nested subquery · ff77a09b
      Aleksey Midenkov authored
      Uninitialized ref_pointer_array[] because setup_fields() got empty
      fields list.  mysql_multi_update() for some reason does that by
      substituting the fields list with empty total_list for the
      mysql_select() call (looks like wrong merge since total_list is not
      used anywhere else and is always empty). The fix would be to return
      back the original fields list. But this fails update_use_source.test
      case:
      
        --error ER_BAD_FIELD_ERROR
        update v1 set t1c1=2 order by 1;
      
      Actually not failing the above seems to be ok.
      
      The other fix would be to keep resolve_in_select_list false (and that
      keeps outer context from being resolved in
      Item_ref::fix_fields()). This fix is more consistent with how SELECT
      behaves:
      
        --error ER_SUBQUERY_NO_1_ROW
        select a from t1 where a= (select 2 from t1 having (a = 3));
      
      So this patch implements this fix.
      ff77a09b
    • Aleksey Midenkov's avatar
      MDEV-25891 Computed default for INVISIBLE column is ignored in INSERT · 1e70b287
      Aleksey Midenkov authored
      There are two fill_record() functions (lines 8343 and 8618). First one
      is used when there are some explicit values, the second one is used
      for all implicit values. First one does update_default_fields(), the
      second one did not. Added update_default_fields() call to the implicit
      version of fill_record().
      1e70b287
    • Aleksey Midenkov's avatar
      MDEV-22660 SIGSEGV on adding system versioning and modifying system column · d31f9537
      Aleksey Midenkov authored
      Second alter subcommand correctly removed VERS_ROW_END flag. We throw
      ER_VERS_PERIOD_COLUMNS in such case.
      d31f9537
    • Aleksey Midenkov's avatar
      MDEV-22660 System versioning cleanups · 911c803d
      Aleksey Midenkov authored
      - Cleaned up Vers_parse_info::check_sys_fields();
      - Renamed VERS_SYS_START_FLAG, VERS_SYS_END_FLAG to VERS_ROW_START,
        VERS_ROW_END.
      911c803d
  2. 06 Oct, 2021 2 commits
    • Brandon Nesterenko's avatar
      Merge branch '10.2' into 10.3 · 00affc32
      Brandon Nesterenko authored
      00affc32
    • Brandon Nesterenko's avatar
      MDEV-25444: mysql --binary-mode is not able to replay some mysqlbinlog outputs · 1ce35c32
      Brandon Nesterenko authored
      Note: This patch backports commits 10cd2818 and 1755ea4b from 10.3.
      
      10cd2818:
      Problem:- Some binary data is inserted into the table using
      Jconnector. When binlog dump of the data is applied using mysql
      client it gives syntax error.
      
      Reason:-
      After investigating it turns out to be a issue of mysql client not
      able to properly handle  \\0 <0 in binary>. In all binary files
      where mysql client fails to insert
      these 2 bytes are common (0x5c00)
      
      Solution:-
      I have changed mysql.cc to include for the possibility that binary
      string can have \\0 in it
      
      1755ea4b:
      Changes on top of Sachin’s patch. Specifically:
       1) Refined the parsing break condition to only change the parser’s
      behavior for parsing strings in binary mode (behavior of \0 outside
      of strings is unchanged).
       2) Prefixed binary_zero_insert.test with ‘mysql_’ to more clearly
      associate the  purpose of the test.
       3) As the input of the test contains binary zeros (0x5c00),
      different text editors can visualize this sequence differently, and
      Github would not display it at all. Therefore, the input itself was
      consolidated into the test and created out of hex sequences to make
      it easier to understand what is happening.
       4) Extended test to validate that the rows which correspond to the
      INSERTS with 0x5c00 have the correct binary zero data.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      1ce35c32
  3. 05 Oct, 2021 2 commits
    • Brandon Nesterenko's avatar
      MDEV-25444: mysql --binary-mode is not able to replay some mysqlbinlog outputs · 1755ea4b
      Brandon Nesterenko authored
      Changes on top of Sachin’s patch. Specifically:
       1) Refined the parsing break condition to only change the parser’s
      behavior for parsing strings in binary mode (behavior of \0 outside
      of strings is unchanged).
       2) Prefixed binary_zero_insert.test with ‘mysql_’ to more clearly
      associate the  purpose of the test.
       3) As the input of the test contains binary zeros (0x5c00),
      different text editors can visualize this sequence differently, and
      Github would not display it at all. Therefore, the input itself was
      consolidated into the test and created out of hex sequences to make
      it easier to understand what is happening.
       4) Extended test to validate that the rows which correspond to the
      INSERTS with 0x5c00 have the correct binary zero data.
      
      Reviewed By:
      ===========
      Andrei Elkin <andrei.elkin@mariadb.com>
      1755ea4b
    • Sachin Kumar's avatar
      MDEV-25444 mysql --binary-mode is not able to replay some mysqlbinlog outputs · 10cd2818
      Sachin Kumar authored
      Problem:- Some binary data is inserted into the table using Jconnector. When
      binlog dump of the data is applied using mysql cleint it gives syntax error.
      
      Reason:-
      After investigating it turns out to be a issue of mysql client not able to properly
      handle  \\\0 <0 in binary>. In all binary files where mysql client fails to insert
      these 2 bytes are commom (0x5c00)
      
      Solution:-
      I have changed mysql.cc to include for the possibility that binary string can
      have \\\0 in it
      10cd2818
  4. 04 Oct, 2021 2 commits
  5. 03 Oct, 2021 1 commit
  6. 30 Sep, 2021 1 commit
    • sjaakola's avatar
      MDEV-24978 crash with transaction on table with no PK and long fulltext column · d5a15f04
      sjaakola authored
      If a table has no unique indexes, write set key information will be collected on all columns in the table.
      The write set key information has space only for max 3500 bytes for individual column, and if a varchar colummn of such non-primary key table is longer than
       this limit, currently a crash follows.
      The fix in this commit, is to truncate key values extracted from such long varhar columns to max 3500 bytes.
      This may potentially lead to false positive certification failures for transactions, which operate on separate cluster nodes, and update/insert/delete table rows, which differ only in the part of such long columns after 3500 bytes border.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      d5a15f04
  7. 29 Sep, 2021 6 commits
  8. 27 Sep, 2021 3 commits
    • Vladislav Vaintroub's avatar
      MDEV-20699 mysqldump of routines causes MariaDB to get killed by oom-killer · 1f099418
      Vladislav Vaintroub authored
      The reason for this behavior is that SP get cached, per connection.
      The stored_program_cache is size of this cache, which amounts to 256
      routines by default. A compiled stored procedure can easily be several
      megabytes in size. Thus calling SHOW CREATE PROCEDURE for all stored
      procedures, like mysqldump does, can require significant amount of memory.
      
      Fixed by bypassing the cache for "SHOW CREATE". This should normally be
      fine also perfomance-wise, as cache is meant to be used for repeated
      execution, not repeated SHOW CREATEs.
      
      Added a test to verify that CREATE PROCEDURE + SHOW CREATE PROCEURE do not
      cache, i.e amount of allocated memory does not change.
      
      Note, there is a change in existing behavior in an edge case :
      If "SHOW CREATE PROCEDURE p1" called from p1, after p1 was altered, now
      this will now return altered code. Previour behavior - relied on caching
      and would return old code. The previous behavior might was not necessarily
      correct.
      1f099418
    • Oleksandr Byelkin's avatar
      MDEV-24454 Crash at change_item_tree · 3690c549
      Oleksandr Byelkin authored
      Use in_sum_func (and so nest_level) only in LEX to which SELECT lex belong to
      
      Reduce usage of current_select (because it does not always point on the correct
       SELECT_LEX, for example with prepare.
      
      Change context for all classes inherited from Item_ident (was only for Item_field) in case of pushing down it to HAVING.
      
      Now name resolution context have to have SELECT_LEX reference if the context is present.
      
      Fixed feedback plugin stack usage.
      3690c549
    • Jan Lindström's avatar
  9. 24 Sep, 2021 12 commits
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · d7aa81c8
      Marko Mäkelä authored
      d7aa81c8
    • Marko Mäkelä's avatar
      Revert MDEV-25114 · f59f5c4a
      Marko Mäkelä authored
      Revert 88a4be75 and
      9d97f92f, which had been
      prematurely pushed by accident.
      f59f5c4a
    • Vladislav Vaintroub's avatar
      Fixup "Windows, mysqltest : cleanup, remove dead code USE_CYGWIN" · a5df5aec
      Vladislav Vaintroub authored
      last commit  8221708e removed too much,
      mtr is failing
      a5df5aec
    • Marko Mäkelä's avatar
      Update libmariadb · cfe1a258
      Marko Mäkelä authored
      cfe1a258
    • Vladislav Vaintroub's avatar
    • Vladislav Vaintroub's avatar
      MDEV-11499 mysqltest, Windows : improve diagnostics if server fails to shutdown · ca7046dc
      Vladislav Vaintroub authored
      Create minidump when server fails to shutdown. If process is being
      debugged, cause a debug break.
      
      Moves some code which is part of safe_kill into mysys, as both safe_kill,
      and mysqltest produce minidumps on different timeouts.
      
      Small cleanup in wait_until_dead() - replace inefficient loop with a single
      wait.
      ca7046dc
    • Julius Goryavsky's avatar
      MDEV-26360: Using hostnames breaks certificate validation · 77b11965
      Julius Goryavsky authored
      Fixed flaws with overly strict or, conversely,
      overly soft verification of certificates in some
      scenarios:
      
      1. Removed the check that the 'commonname' (CN) in the
         certificate matches the 'localhost' value on the side
         of the joiner node, which was performed earlier, even
         if the address was received by the script only as an
         argument (out of the exchange via the Galera protocol) -
         since for the joining node this argument always contains
         its own local address, not the address of the remote host,
         so it is always treated as 'localhost', which is not
         necessarily true (outside of mtr testing);
      2. Removed checking the domain name or IP-address of the
         peer node in the encrypt=2 mode;
      3. Fixed checking of compliance of certificates when
         rsync SST is used;
      4. Added the ability to specify CA not only as a file,
         but also as a path to the directory where the certificates
         are stored. To do this, the user just needs to specify the
         path to this directory as the value ssl-ca or tca parameter,
         ending with the '/' character.
      77b11965
    • Marko Mäkelä's avatar
      MDEV-26672 innodb_undo_log_truncate may reset transaction ID sequence · 4bfdba2e
      Marko Mäkelä authored
      trx_rseg_header_create(): Add a parameter for the value that is
      to be written to TRX_RSEG_MAX_TRX_ID. If we omit this write, then
      the updated test innodb.undo_truncate will fail for the 4k, 8k, 16k
      page sizes. This was broken ever since
      commit 947efe17 (MDEV-15158)
      removed the writes of transaction identifiers to the TRX_SYS page.
      
      srv_do_purge(): Truncate undo tablespaces also during slow shutdown
      (innodb_fast_shutdown=0).
      
      Thanks to Krunal Bauskar for noticing this problem.
      4bfdba2e
    • Alexey Bychko's avatar
      MDEV-26612 Two different ways to start MariaDB service can cause data corruption · 467011bc
      Alexey Bychko authored
      RedHat systems have both files for lsb and init functions.
      Old code was written as if/else, so second file (RedHat-specific) was not processed.
      So, systemd redirect didn't work, because its logic is described in
      RedHat-specific functions file
      467011bc
    • Jan Lindström's avatar
      Revert "MDEV-24978 : SIGABRT in __libc_message" · 47ba5523
      Jan Lindström authored
      This reverts commit 30dea459.
      47ba5523
    • sjaakola's avatar
      MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL) · 88a4be75
      sjaakola authored
      This patch is the plan D variant for fixing potetial mutex locking
      order exercised by BF aborting and KILL command execution.
      
      In this approach, KILL command is replicated as TOI operation.
      This guarantees total isolation for the KILL command execution
      in the first node: there is no concurrent replication applying
      and no concurrent DDL executing. Therefore there is no risk of
      BF aborting to happen in parallel with KILL command execution
      either. Potential mutex deadlocks between the different mutex
      access paths with KILL command execution and BF aborting cannot
      therefore happen.
      
      TOI replication is used, in this approach,  purely as means
      to provide isolated KILL command execution in the first node.
      KILL command should not (and must not) be applied in secondary
      nodes. In this patch, we make this sure by skipping KILL
      execution in secondary nodes, in applying phase, where we
      bail out if applier thread is trying to execute KILL command.
      This is effective, but skipping the applying of KILL command
      could happen much earlier as well.
      
      This patch also fixes mutex locking order and unprotected
      THD member accesses on bf aborting case. We try to hold
      THD::LOCK_thd_data during bf aborting. Only case where it
      is not possible is at wsrep_abort_transaction before
      call wsrep_innobase_kill_one_trx where we take InnoDB
      mutexes first and then THD::LOCK_thd_data.
      
      This will also fix possible race condition during
      close_connection and while wsrep is disconnecting
      connections.
      
      Added wsrep_bf_kill_debug test case
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      88a4be75
    • Jan Lindström's avatar
      Revert "MDEV-23328 Server hang due to Galera lock conflict resolution" and · 9d97f92f
      Jan Lindström authored
      Revert "MDEV-24873 galera.galera_as_slave_ctas MTR failed:..."
      
      This reverts commit 29bbcac0 and
      later commit 5ecaf52d.
      9d97f92f
  10. 22 Sep, 2021 5 commits
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · b46cf33a
      Marko Mäkelä authored
      b46cf33a
    • Marko Mäkelä's avatar
      MDEV-26450: Corruption due to innodb_undo_log_truncate · 1cb218c3
      Marko Mäkelä authored
      At least since commit 055a3334
      (MDEV-13564) the undo log truncation in InnoDB did not work correctly.
      
      The main issue is that during the execution of
      trx_purge_truncate_history() some pages of the newly truncated
      undo tablespace could be discarded.
      
      fsp_try_extend_data_file(): Apply the peculiar rounding of
      fil_space_t::size_in_header only to the system tablespace,
      whose size can be expressed in megabytes in a configuration parameter.
      Other files may freely grow by a number of pages.
      
      fseg_alloc_free_page_low(): Do allow the extension of undo tablespaces,
      and mention the file name in the error message.
      
      mtr_t::commit_shrink(): Implement crash-safe shrinking of a tablespace
      file. First, durably write the log, then shrink the file, and finally
      release the page latches of the rebuilt tablespace. Refactored from
      trx_purge_truncate_history().
      
      log_write_and_flush_prepare(), log_write_and_flush(): New functions
      to durably write log during mtr_t::commit_shrink().
      1cb218c3
    • Marko Mäkelä's avatar
      21d19ed4
    • Daniel Ye's avatar
      MDEV-26545 Spider does not correctly handle UDF and stored function in where conds · 9fc1ef93
      Daniel Ye authored
      - Handle stored function conditions correctly, with the same logic as with UDFs.
      - When running queries on Spider SE, by default, we do not push down WHERE conditions containing usage of UDFs/stored functions to remote data nodes, unless the user demands (by setting spider_use_pushdown_udf).
      - Disable direct update/delete when a udf condition is skipped.
      9fc1ef93
    • Daniel Ye's avatar
      MDEV-26545 Spider does not correctly handle UDF and stored function in where conds · ac1c6738
      Daniel Ye authored
      - Handle stored function conditions correctly, with the same logic as with UDFs.
      - When running queries on Spider SE, by default, we do not push down WHERE conditions containing usage of UDFs/stored functions to remote data nodes, unless the user demands (by setting spider_use_pushdown_udf).
      ac1c6738
  11. 21 Sep, 2021 2 commits