Commits · b31bb9b148e88c17a6b2d88e50d6bf77c6d285ce · nexedi / neoppod

02 Jul, 2009 12 commits

Document a bit a sleep in the code. · b31bb9b1

Vincent Pelletier authored Jul 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@759 71dcc9de-d417-0410-9af5-da40c76e7ee4

b31bb9b1

"time" is not imported. Only "sleep" is. · 14a5bca2

Vincent Pelletier authored Jul 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@758 71dcc9de-d417-0410-9af5-da40c76e7ee4

14a5bca2

Prepare notifyDeadStorage to be callable from outside app. · fcecacd2
Vincent Pelletier authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@757 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fcecacd2

Do not call "ask" on a connection we just closed. · bb077977

Vincent Pelletier authored Jul 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@756 71dcc9de-d417-0410-9af5-da40c76e7ee4

bb077977

Fix decorator definition, it was not returning the wrapper. · 2ae0285c
Vincent Pelletier authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@755 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2ae0285c

Make ask, notify and answer raise ConnectorConnectionClosedException when... · d8805792

Vincent Pelletier authored Jul 02, 2009

Make ask, notify and answer raise ConnectorConnectionClosedException when called on a closed connection.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@754 71dcc9de-d417-0410-9af5-da40c76e7ee4

d8805792

Move specifics actions in each sub-handler. Remove a intermediate handler no · 3304a165

Grégory Wisniewski authored Jul 02, 2009

more usefull. Storage clear its partition table before asking it, this prevent
duplicate entries but should not be required.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@753 71dcc9de-d417-0410-9af5-da40c76e7ee4

3304a165

Split storage handlers. As for the primary master, all incoming connections are · ecd05c50

Grégory Wisniewski authored Jul 02, 2009

handled by the identification handler which apply the right handler depending on
the peer node type. Client and storage incoming connections are refused until
the storage reach the operation state, but the listening port is open to ensure
it's available, tryAgain errors are sent to wrong nodes.
Remove decorators because connection type is implied by handler type.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@752 71dcc9de-d417-0410-9af5-da40c76e7ee4

ecd05c50

Remove unused parameter. · 733e7e90

Vincent Pelletier authored Jul 02, 2009

Update callers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@751 71dcc9de-d417-0410-9af5-da40c76e7ee4

733e7e90

Factorise master disconnection code. · afbd38a2

Vincent Pelletier authored Jul 02, 2009

Only close master_conn is it is set.
Add an assertion before closing to verify that if there is any master connection closed after primary master is set is the primary master connection itself.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@750 71dcc9de-d417-0410-9af5-da40c76e7ee4

afbd38a2

Remove this decorator because we don't accept incoming (non-client) connections · 86fd4cc7
Grégory Wisniewski authored Jul 02, 2009
```
during bootstrap stage.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@749 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
86fd4cc7
Add a log method on the node manager to help debugging. · cbde95b6
Grégory Wisniewski authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@748 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cbde95b6

01 Jul, 2009 14 commits

Don't restart a complete connection to primary master when... · 1a330a1d

Vincent Pelletier authored Jul 01, 2009

Don't restart a complete connection to primary master when requestNodeIdentification fails (for example if master is not ready).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@747 71dcc9de-d417-0410-9af5-da40c76e7ee4

1a330a1d

Don't disconnect from master when it responds NotReady. · 5f6ca700
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@746 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5f6ca700
Move "connected to a primary master node" log from handler to app for consistency. · baf58076
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@745 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
baf58076
Explicitely avoid loop exit condition when connecting to a server found by answerPrimaryMaster. · cea93513
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@744 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cea93513
Connection can be closed before we had the time to create a node from peer. · d3a96466
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@743 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d3a96466

Exit election loop when we know we are not the primary. · b43bf3b9

Vincent Pelletier authored Jul 01, 2009

Expect AcceptnodeIdentification message in secondary handler connected to primary master. It will be received just once (upon election state exit).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@742 71dcc9de-d417-0410-9af5-da40c76e7ee4

b43bf3b9

Replace a bare "pass" with a warning log, as this case should never happen (to... · 18e4cdc5

Vincent Pelletier authored Jul 01, 2009

Replace a bare "pass" with a warning log, as this case should never happen (to be upgraded to a raise someday).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@741 71dcc9de-d417-0410-9af5-da40c76e7ee4

18e4cdc5

Remove log line prefixes, as they are not in sync with the method name containing them. · bdf21345
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@740 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bdf21345
Add logs for each kind of connection closure caused by remote peer. · 94350c6f
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@739 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
94350c6f

Remove some overriden methods in storage base handler because they do not have · 6be5487f

Grégory Wisniewski authored Jul 01, 2009

to be implemented in each sub handler, especially in the operation handler.
Calls to those methods in a wrong handler will directely fallback to the neo
base handler.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@738 71dcc9de-d417-0410-9af5-da40c76e7ee4

6be5487f

Add a __repr__ method for SocketConnector class to make debugging easier. · c6c9b9a6
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@737 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c6c9b9a6

On the contrary of what said in commit #734, the connection argument is required · 36991be3

Grégory Wisniewski authored Jul 01, 2009

on _dropIt() method. Revert it but fix a wrong call at same time.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@736 71dcc9de-d417-0410-9af5-da40c76e7ee4

36991be3

Fix issue with replication, storager node ask for the partition table and the · 609531fa

Grégory Wisniewski authored Jul 01, 2009

node informations before entering in service/replication stage. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@735 71dcc9de-d417-0410-9af5-da40c76e7ee4

609531fa

Bug fix with _dropIt() internal method of master service handler. The connection · 127fe975

Grégory Wisniewski authored Jul 01, 2009

parameter isn't usefull and was missing in some calls.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@734 71dcc9de-d417-0410-9af5-da40c76e7ee4

127fe975

30 Jun, 2009 14 commits

Fix attribut access through self identifier. · 7f09dd87

Grégory Wisniewski authored Jun 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@733 71dcc9de-d417-0410-9af5-da40c76e7ee4

7f09dd87

Remove dropNode() calls where it's not safe to change the partition table · efb4da42

Grégory Wisniewski authored Jun 30, 2009

without give the choice to an admin to discard the node's content. Now a node
can be dropped only when requested by the admin node or when a storage has
changed its address (this case should be checked and discussed).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@732 71dcc9de-d417-0410-9af5-da40c76e7ee4

efb4da42

Define the close() method on BaseConnection instead of Connection to allow close · 2cc58316

Grégory Wisniewski authored Jun 30, 2009

a listening connection (as requested in the storage when connecting to the
primary master).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@731 71dcc9de-d417-0410-9af5-da40c76e7ee4

2cc58316

According to previous commit (#729), update bootstrap handler to not expected · 24a4b289

Grégory Wisniewski authored Jun 30, 2009

be applied on a server connection, thus connectionAccepted and
handleRequestNodeIdentification are removed. Remove also some code that should
not be reached, those king of errors should be checked by unit tests on app.py.
Remove handler method that ignore packets to improve the protocol weakness.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@730 71dcc9de-d417-0410-9af5-da40c76e7ee4

24a4b289

Save listenning connection reference in a class variable. Open the listening · 8bee3858

Grégory Wisniewski authored Jun 30, 2009

socket after the primary master connection succeed, because we don't want to any
incoming connections during bootstrap stage.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@729 71dcc9de-d417-0410-9af5-da40c76e7ee4

8bee3858

Same as previous commit but for the storage application. · 254243f5
Grégory Wisniewski authored Jun 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@728 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
254243f5

Accept (but ignore for now) NotifyClusterInformation packets in base master · 393da381

Grégory Wisniewski authored Jun 30, 2009

handler to avoid the application crash.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@727 71dcc9de-d417-0410-9af5-da40c76e7ee4

393da381

Send a notification to any identified node about the cluster state, and cut · 3acd52fa

Grégory Wisniewski authored Jun 30, 2009

any client connections when keaving the RUNNING state.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@726 71dcc9de-d417-0410-9af5-da40c76e7ee4

3acd52fa

Do not remove storage nodes from the partition table when got disconnect, this · 6da1b463

Grégory Wisniewski authored Jun 30, 2009

is a critical operation (can cause data loss) that should only be done by an
administrator.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@725 71dcc9de-d417-0410-9af5-da40c76e7ee4

6da1b463

Split master election handler in two: · d925f14d

Grégory Wisniewski authored Jun 30, 2009

- One the incoming (server) connections 
- Another for initiated (client) connections
Remove checks and decorators no more usefull.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@724 71dcc9de-d417-0410-9af5-da40c76e7ee4

d925f14d

Alias __del__() with close() method to ensure the connection is closed when the · b0fe5e6d
Grégory Wisniewski authored Jun 30, 2009
```
database manager is deleted.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@723 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b0fe5e6d
handleAnswerPrimaryMaster doesn't raise any more, removing a XXX from test. · d939c90f
Vincent Pelletier authored Jun 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@722 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d939c90f

propagate protocolError message to original connection · e712e586

Aurel authored Jun 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@721 71dcc9de-d417-0410-9af5-da40c76e7ee4

e712e586

-when sending an error message use answer method so that admin node · 5c20c924

Aurel authored Jun 30, 2009

retrieve the original connection
- simplify if...else condition


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@720 71dcc9de-d417-0410-9af5-da40c76e7ee4

5c20c924