Require a minimum setuptools version for Python 3.
- Loading...
When the setuptools_dso
module is used having older versions of
setuptools installed, the wheel
module (one of its dependencies)
sets up a handler for the root logging that writes to stdout
(https://github.com/pypa/wheel/issues/622).
This breaks the expected output of the programs, and thus the
wendeling.core tests.
However, if setuptools.logging
is available, wheel
will use it
instead and it won't set up a handler.
Thus, I added a explicit dependency to a version of setuptools above
60.2 for Python 3, as that is the first version that provides this
module.
Check out, review, and merge locally
Step 1. Fetch and check out the branch for this merge request
git fetch "https://lab.nexedi.com/vnmabus/pygolang.git" "fix/min_setuptools_version" git checkout -b "vnmabus/pygolang-fix/min_setuptools_version" FETCH_HEAD
Step 2. Review the changes locally
Step 3. Merge the branch and fix any conflicts that come up
git fetch origin git checkout "origin/master" git merge --no-ff "vnmabus/pygolang-fix/min_setuptools_version"
Step 4. Push the result of the merge to GitLab
git push origin "master"
Note that pushing to GitLab requires write access to this repository.
Tip: You can also checkout merge requests locally by following these guidelines.
- You're only seeing other activity in the feed. To add a comment, switch to one of the following options.