1. 07 Aug, 2015 7 commits
  2. 06 Aug, 2015 4 commits
    • Reinout van Rees's avatar
      Merge pull request #255 from mauritsvanrees/maurits-check-use-dependency-links-earlier · eb0bc6bd
      Reinout van Rees authored
      Check the 'use-dependency-links' option earlier.
      eb0bc6bd
    • Maurits van Rees's avatar
      Check the 'use-dependency-links' option earlier. · 30683a0d
      Maurits van Rees authored
      This can give a small speed increase.
      
      Before this, for each dist we would first check if it had a dependency
      links option, which is almost always the case, but it is usually
      empty: the package *will* have a dependency_links.txt in its EGG-INFO,
      but there is only an empty line in it.
      
      When you have a lot of packages and several buildout parts that use
      them, the dependency links can be checked a lot of times.
      
      On an extended Plone buildout with 'use-dependency-links=false', where
      get_dist was called over 2500 times, the difference was 0.1 seconds,
      so not much.  When I/O is slow, the difference could be more
      noticeable.
      
      Note that actually setting 'use-dependency-links' to false, already
      helps much more.  For this buildout it shaved off 1.5 seconds.
      
      Note that the 0.1 seconds win is because we do not have to call
      'os.exists' for all those files, and the 1.5 seconds win is because we
      do not have to actually read those files.
      
      Also, for completeness sake, note that in this buildout get_dist was
      called lots of times, but the list of dists that we checked for
      dependency links in this method was always just a list of one.  So we
      could have simply switched the order of the three parts of the
      condition around with the same effect (and a smaller diff).  Still,
      the way I did it now seems better.
      
      And I am probably explaining myself much much more than is needed. :-)
      30683a0d
    • Jim Fulton's avatar
      Merge pull request #254 from mauritsvanrees/maurits-fix-bootstrap-typo · 84053ef6
      Jim Fulton authored
      Fixed bootstrap help text: --buildout-version.
      84053ef6
    • Maurits van Rees's avatar
      9ba1e317
  3. 10 Jul, 2015 1 commit
    • Stefano Mazzucco's avatar
      Enable downloading behind a proxy by using urllib2 · 9299c184
      Stefano Mazzucco authored
      Behind a proxy, `urllib` does not work with Python2 due to [Python issue
      24599](https://bugs.python.org/issue24599).
      
      Instead of using `urllib`, let's implement `urlretrieve` with `urllib2`, which
      instead works and leave the Python3 implementation untouched (since that
      one works too).
      
      This fixes buildout issue #32.
      
      There's no need to change the `try: except:IOError` block where `urlretrieve` is
      used (line 195 in download.py) since the exceptions raised by `urllib2`
      are subclasses of `IOError` and will then be caught.
      9299c184
  4. 01 Jul, 2015 21 commits
  5. 30 Jun, 2015 7 commits