1. 07 Jan, 2025 14 commits
    • Xavier Thompson's avatar
      [dev] Change local versions to +slapos007 · 61db3f5a
      Xavier Thompson authored
      See merge request !36
      and merge request !34
      
      - Fixup "[feat] zc.recipe.egg: Support on the fly patches."
      61db3f5a
    • Alain Takoudjou's avatar
      [feat] allow to rewrite url before download using netrc and macdef · e3a552eb
      Alain Takoudjou authored
      This adds a generic mechanism in the Download API to rewrite the URL
      to be downloaded, possibly with extra headers. Substitued groups from
      the matching regular expression can be optionally quoted.
      
      .netrc:
      
      macdef buildout:HOSTNAME
        RULE_1_REGEX
          RULE_1_NEW_URL HEADER1=VALUE1 HEADER2=VALUE2 ...
        RULE_2_REGEX
          RULE_2_NEW_URL ...
        ...
      
      macdef buildout:OTHER_HOSTNAME
        ...
      
      A rewriting rule is defined by a pair of lines with optional indentation
      (only there for readability).
      
      The first line of a rule is a regex that matches fully against
      the path?query part of the URL.
      
      If the second line is empty, the request isn't changed.
      Else parts are parsed using shell-like syntax:
      - the first one must produce the full URL to download
      - the next ones are optional headers to send
      - each part is subject to regex substitution using the
        Python Format Specification Mini-Language:
        captured grouped from the first line are numbered starting from 1,
        {0} is the base URL (scheme://location) and
        the optional `quote` attribute returns the urlencoded value
      
      A use case is to work around
        https://gitlab.com/gitlab-org/gitlab/-/issues/19189
      for example with the following .netrc:
      
          macdef buildout:lab.nexedi.com
            /(.+)/-/raw/([^/]+)/(.+)
              {0}/api/v4/projects/{1.quote}/repository/files/{3.quote}/raw?ref={2} PRIVATE-TOKEN=<ACCESS_TOKEN>
      e3a552eb
    • Xavier Thompson's avatar
      [dev] Change local versions to +slapos006 · f1ae9625
      Xavier Thompson authored
      See merge request !37
      
      - Fixup "[feat] Use pip install --editable in easy_install.develop"
      f1ae9625
    • Xavier Thompson's avatar
      [dev] Change local versions to +slapos005 · 2039cf7f
      Xavier Thompson authored
      See merge request !35
      
      - Fixup "[feat] Use pip install --editable in easy_install.develop"
      - Fixup "[wkrd] Use pip install --editable --user"
      2039cf7f
    • Xavier Thompson's avatar
      [dev] Change local versions to +slapos004 · 42305865
      Xavier Thompson authored
      See merge request !33
      
      - Fixup "Use pip install --editable in easy_install.develop"
      42305865
    • Xavier Thompson's avatar
      82be1d02
    • Xavier Thompson's avatar
      [test] zc.recipe.egg: Fix tests for Python >= 3.10 · 7ffd0b3b
      Xavier Thompson authored
      Fix output renormalisation when the Python version string contains more
      than one digit in the minor version number, i.e for Python >= 3.10.
      7ffd0b3b
    • Xavier Thompson's avatar
      [fix] zc.recipe.egg: Reinstall missing develop egg metadata · 849f5458
      Xavier Thompson authored
      Let zc.recipe.egg:develop reinstall if .egg-info or .dist-info is
      missing from the folder referenced by .egg-link.
      849f5458
    • Xavier Thompson's avatar
      [feat] Let recipe.update access installed paths · 59de7e76
      Xavier Thompson authored
      Store a part's installed paths in `self[part].installed_files` before
      calling `recipe.update()`, to allow the part's recipe to read them if
      needed by looking up `options.installed_files`.
      
      Delete this attribute just after the call to ensure this data remains
      private to the part.
      
      This will allow zc.recipe.egg:develop to remember in `update()` which
      .egg-link it installed in `install()`; inferring this would otherwise
      require essentially reinstalling the egg from the setup path, as that
      is all the recipe gets as input.
      
      Storing this under `__buildout_installed__` in the part's options was
      considered, but some recipes take all the recorded key/value pairs as
      input, so it would be a breaking change.
      59de7e76
    • Xavier Thompson's avatar
      [feat] Enable build of pyproject.toml projects · b3436634
      Xavier Thompson authored
      Enable zc.buildout.easy_install.build, which builds a project manually
      from an unpacked sdist archive and is used by zc.recipe.egg:custom, to
      build a project which only has a pyproject.toml but no setup.py.
      b3436634
    • Xavier Thompson's avatar
      [fix] Sign develop eggs with directory hash · 9e48c17e
      Xavier Thompson authored
      Mark .dist-info eggs installed by buildout as develop to distinguish
      them from .dist-info eggs from the system and decide how to sign the
      egg accordingly (with directory hash or with version).
      9e48c17e
    • Xavier Thompson's avatar
      [test] Add test for PEP 625 workaround · 61e82f3d
      Xavier Thompson authored
      61e82f3d
    • Xavier Thompson's avatar
      [test] Fix tests after PEP 625 · 5ba397f9
      Xavier Thompson authored
      Adapt tests to ignore warning generated by setuptools not finding
      zc.recipe.egg on first index lookup, because it's indexed as
      zc-recipe-egg, because since PEP 625 the sdist filename is
      zc_recipe_egg-xyz.tar.gz.
      5ba397f9
    • Xavier Thompson's avatar
      [wkrd] Workaround package index & PEP 625 · 8140cf54
      Xavier Thompson authored
      Buildout relies on setuptools to fetch dists from package indexes like
      PyPI. Setuptools infers the project name of source distributions found
      in the index from their filename, as derived from their download link.
      
      This works on the assumption the sdist filename corresponds losslessly
      to the project name, and in the way setuptools expects.
      
      Setuptools normalizes any occurrence of a non alphanumeric and non '.'
      character into a '-'. This is actually already lossy for project names
      that contain other characters; therefore the assumption should instead
      be that the sdist filename is lossless with regards to this normalized
      project name - in general project names should respect this normalized
      form.
      
      Since PEP 625, that assumption is definitely broken, i.e. the filename
      is lossy with regards to the normalized project name:
      - in the sdist filename, characters . and - must both be replaced by _
      - in the sdist filename, all characters must be lowercased
      
      Internally, setuptools lowercases the normalized project name in order
      to compare dists. The possibles consequences of that broken assumption
      are thus:
      1. the sdist is discarded from the search
      2. the sdist is found but the project name may be cased differently
      
      For example, zc.buildout==3.0.1 yields zc_buildout-3.0.1.tar.gz, which
      results in setuptools interpreting the project name as zc-buildout and
      discarding it from the search.
      
      Workaround 1. by also looking up the name with . replaced by _.
      Workaround 2. by fixing the project names back to the looked-up name.
      8140cf54
  2. 13 Dec, 2024 26 commits
    • Xavier Thompson's avatar
      58c08402
    • Xavier Thompson's avatar
      [test] Test develop of PEP660 egg w/o packages · e96063d6
      Xavier Thompson authored
      This test is skipped for Python2 because pip and setuptools versions
      compatible with Python2 do not support PEP 660 (i.e. editable installs
      without setup.py).
      e96063d6
    • Xavier Thompson's avatar
      [wkrd] Use pip install --editable --user · 66712d2c
      Xavier Thompson authored
      Prior to pip 21.1, pip install --editable --target fails because it
      results in wrong parameters being passed to setup.py develop by pip.
      
      Prior to setuptools 45.2.0, both pip install --editable --target and
      pip install --editable --prefix fail because the temporary install
      directory used internally by pip is not added to PYTHONPATH prior
      to pip calling setup.py develop. In later version setuptools emits a
      warning instead of an error.
      
      Temporarily override PYTHONUSERBASE to point to the target directory,
      so as to emulate --prefix=<dir> with PYTHONUSERBASE=<dir> and --user.
      
      This is needed for Python2 because pip 21.1 and setuptools 45.2.0 are
      both Python3 only.
      66712d2c
    • Xavier Thompson's avatar
      [feat] Use pip install --editable in easy_install.develop · 7ffca476
      Xavier Thompson authored
      Instead of running python setup.py develop directly. This will allow
      using zc.buildout.easy_install.develop on recent projects that have
      only a pyproject.toml. It also fixes develop leaving build artifacts
      in the source directory that caused later runs to do nothing, e.g.
      preventing develop-eggs to be rebuilt when a build dependency passed
      in setup-eggs option of zc.recipe.egg:develop changed.
      
      A verbosity parameter to tune verbosity of pip is added, with adjusted
      values for the case of buildout:develop and of zc.recipe.egg:develop,
      so as to remain close to the previous behavior with regards to logs.
      
      Technical details:
      
      For packages using PEP-660-style editable installs, supported by more
      recent versions of pip, pip will not delegate to `setup.py develop` -
      enabling editable installs for pure pyproject.toml projects - and will
      instead generate a .dist-info metadata folder but not a .egg-link.
      
      Since buildout currently requires a .egg-link, as it does not support
      PEP 660's mechanism that relies on having a sites-packages directory,
      we need to create this .egg-link after the fact. The tricky part is
      finding out where the .egg-link should point: the path containing the
      pyproject.toml, or a subdirectory?
      
      For this we make use of *.dist-info/top_level.txt to first determine
      the list of top-level packages, and then importlib to extract info
      from the PEP-660-style install.
      
      If top_level.txt does not exist, is empty, or otherwise does not list
      any package that resolves to an import path, fallback to the path of
      the folder that contains the pyproject.toml as the .egg-link target.
      If it lists multiple packages that resolve to different import paths,
      arbitrarily use the first one and emit a warning.
      
      Support namespace packages where `spec.submodule_search_locations` is
      a `_NamespacePath` object instead of a simple `list` and also support
      cases where the layout of the source project does not follow the same
      structure as the package tree - meaning some custom magic might be
      involved in making editable imports work as intended.
      7ffca476
    • Xavier Thompson's avatar
      [tool] Gitignore *.dist-info · c60ddacb
      Xavier Thompson authored
      c60ddacb
    • Xavier Thompson's avatar
      [feat] zc.recipe.egg: Reinstall when setup-eggs versions change · 0e6ebfc6
      Xavier Thompson authored
      Trigger uninstall + install of eggs installed with zc.recipe.egg:custom
      or :develop when pinned versions of setup-eggs have changed. To achieve
      this the versions of setup-eggs are included in the section: this makes
      them part of its signature so that when they change, buildout will call
      `uninstall` and `install` for this section instead of just `update`.
      
      Unlike other zc.recipe.egg entry points, :custom stores the path of the
      installed egg; thus `uninstall` will remove it fully, leaving `install`
      to reinstall it cleanly from scrach.
      
      In the case of :develop, `uninstall` matters little as only the path of
      the installed `.egg-link` is stored. Instead `install` must be fixed to
      actually rebuild the egg in-place in the source directory and `develop`
      should do nothing.
      
      The main issue lies in `zc.buildout.easy_install.develop`: depending on
      the build process, it may leave build artifacts in the source directory
      that cause future runs to do nothing.
      0e6ebfc6
    • Xavier Thompson's avatar
      [dev] Change local versions to +slapos002 · f5e164e5
      Xavier Thompson authored
      See merge request !31
      
      Note: all changes with +slapos001 are tests-related.
      
      - Fixup "[test] Add tests for build dependencies"
      - Fixup "[feat] zc.recipe.egg: Improve on the fly patches."
      - Fixup "[fix] Fix working set sorting".
      - Fixup "[feat] Add dependencies in __buildout_signature__"
      f5e164e5
    • Xavier Thompson's avatar
      [fix] Fix invalid specifier in test · 0d216988
      Xavier Thompson authored
      Pinning zc.buildout = >.1 is now invalid, so use >0.1 instead.
      0d216988
    • Xavier Thompson's avatar
      [fix] Fix pip Py2 deprecation filter in tests · 1d782469
      Xavier Thompson authored
      Adapt filter in tests for pip emitting Python2.7 deprecation warnings
      to pip >= 20.2.2 and < 21.0 - these versions seem to accidentally add
      a redundant bit of message to the warning.
      1d782469
    • Xavier Thompson's avatar
      [fix] Ignore setuptools deprecation warnings · 3b4ceeec
      Xavier Thompson authored
      The testing framework, some individual tests and 'buildout:develop'
      call python setup.py <command> manually, which is deprecated by
      setuptools. Depending on the setuptools version, suppress the
      warning for now to avoid polluting the logs.
      3b4ceeec
    • Xavier Thompson's avatar
      [fix] Fix logging filters for Python2 · 94ceec02
      Xavier Thompson authored
      94ceec02
    • Xavier Thompson's avatar
      78b29d49
    • Xavier Thompson's avatar
      [fix] Adapt to setuptools>=65.6.0 logging on root · b3d79956
      Xavier Thompson authored
      INFO logs from setuptools which were previously not emitted because
      setuptool's ad-hoc legacy logger defaulted to WARNING and above may
      now be emitted because setuptools now logs to the root logger, thus
      the global root logger's level configuration applied.
      
      This caused undesired 'root: <some setuptools info>' messages to be
      emitted and caused many tests to fail due to unexpected outputs.
      b3d79956
    • Xavier Thompson's avatar
      [dev] Change local versions to +slapos001 · d4c84a3e
      Xavier Thompson authored
      See merge request !30
      d4c84a3e
    • Julien Muchembled's avatar
    • Julien Muchembled's avatar
      [feat] download: add support for slapos.libnetworkcache · 037cf6ef
      Julien Muchembled authored
      When specifying an alternate URL as fallback, the main URL is always
      used for both downloading & uploading from/to networkcache.
      037cf6ef
    • Xavier Thompson's avatar
      [feat] Propagate libnetworkcache installation · 86de7243
      Xavier Thompson authored
      If slapos.libnetworkcache is importable, install it in bootstrap and
      in buildout upgrade - the places where bin/buildout is (re)generated
      - as though it were a dependency of zc.buildout.
      
      This is a hack to propagate libnetworkcache as a soft dependency.
      86de7243
    • Julien Muchembled's avatar
      [feat] download: add netrc file support · 178aff36
      Julien Muchembled authored
      Like for URL that contain credentials, we still skip auth challenge
      because it's faster and:
      - we only support one auth scheme (basic)
      - netrc provides no way to specify realms, which seem anyway to be
        less and less used (https://stackoverflow.com/q/69303610 reports
        that recent browsers don't display them anymore)
      
      See merge request !25
      178aff36
    • Julien Muchembled's avatar
      [feat] Extend Download API to use an alternate URL as fallback · d7b6e684
      Julien Muchembled authored
      This retries with the alternate URL in case of HTTPError with the main
      one.
      
      Used by slapos.recipe.build:download* and slapos.recipe.cmmi recipes.
      d7b6e684
    • Julien Muchembled's avatar
      [fix] Rewrite 'urlretrieve' helper to fix various download-related issues · d615bcde
      Julien Muchembled authored
      - Py3: stop using legacy API of urllib.request and
             fix download of http(s) URLs containing user:passwd@
      - Py2: avoid OOM when downloading huge files
      
      This is implemented as a method in case we want to make it configurable
      via [buildout].
      d615bcde
    • Julien Muchembled's avatar
      [fix/opti] download: clean-up, fix, optimization · eafe5829
      Julien Muchembled authored
      An optimization is to avoid temporary file when possible: a rename
      (or hard link) is not always possible (different mount points).
      
      Another one is to not check md5sum twice when using cache file.
      
      Fall-back mode is ignored if an MD5 checksum is given.
      
      In case of checksum mismatch for a cached path, remove it and
      download again, mainly to cover the following cases:
      - the url content changes and the user updates the checksum
      - buildout killed while downloading directly to cache
        (see above optimization)
      - shutil.copyfile is interrupted
      eafe5829
    • Jérome Perrin's avatar
      [fixup] Ignore _profile_base_location_ when computing signatures · 3076bf8e
      Jérome Perrin authored
      We want two identical sections at different URL to be able to produce
      same signature. This feature is useful for slapos.recipe.cmmi's
      shared parts.
      
      This commit may fixup "Support ${:_profile_base_location_}." but is
      purposefuly kept separate because it concerns parts signatures which
      are an orthogonal feature.
      3076bf8e
    • Kazuhiko Shiozaki's avatar
      87f838fa
    • Kazuhiko Shiozaki's avatar
      0632fb65
    • Xavier Thompson's avatar
      0d38fede
    • Xavier Thompson's avatar
      cea3a8c8