SlapPopen: Close stdout and stderr

0fe309cd · Xavier Thompson · 6393f62f · 0fe309cd
Commit 0fe309cd authored Nov 30, 2022 by Xavier Thompson
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

slapos/grid/utils.py slapos/grid/utils.py +7 -0

No files found.
--- a/slapos/grid/utils.py
+++ b/slapos/grid/utils.py
@@ -199,6 +199,13 @@ class SlapPopen(subprocess.Popen):
      e.output = e.stdout = ''.join(buffers.get(stdout_fileno, ()))
      e.stderr = ''.join(buffers.get(stderr_fileno, ()))
      raise
+    finally:
+      for s in (self.stdout, self.stderr):
+        if s:
+          try:
+            s.close()
+          except OSError:
+            pass

    self.output = ''.join(buffers.get(stdout_fileno, ()))
    self.error = ''.join(buffers.get(stderr_fileno, ()))