version up : SQLite3 3.8.10.2.

component/sqlite3/buildout.cfg

@@ -5,11 +5,13 @@ parts =
 
 [sqlite3]
 recipe = slapos.recipe.cmmi
-url = http://sqlite.org/2015/sqlite-autoconf-3080900.tar.gz
-md5sum = 6a18d4609852f4b63f812a1059df468f
+url = http://sqlite.org/2015/sqlite-autoconf-3081002.tar.gz
+md5sum = a18bfc015cd49a1e7a961b7b77bc3b37
 configure-options =
   --disable-static
   --enable-readline
+make-options =
+  -j1
 environment =
   CPPFLAGS=-I${readline:location}/include -I${ncurses:location}/include
   LDFLAGS=-L${buildout:parts-directory}/${:_buildout_section_name_} -Wl,-rpath=${readline:location}/lib -Wl,-rpath=${ncurses:location}/lib -L${readline:location}/lib -L${ncurses:location}/lib

[Kirill Smelkov]

@kazuhiko, why this -j1 is needed?

The commit log only says that sqlite version is updated, but does not give rationale nor mentions why parallel build is now disabled.

I would prefer we try not to disable parallel builds, but if something does not build the parallel way, give rationale in commit log and in buildout.cfg why it is disabled.

Could you please clarify?

Thanks beforehand,
Kirill

[Kazuhiko Shiozaki]

Because it failed in reality... but I should write something in the commit log, indeed. It can be good to check the diff with older version, but AFAIK parallel build does not accelerate sqlite3 build so much, that has a very big concatenated source file.

[Kirill Smelkov]

I understand.

Imho it makes a good rule to do such things with care, else it is -j1 here and another -j1 there with each being not a large loose in their own separately, but going this way the net effect is visible.

The current state of slapos is that builds are already slow, so imho we should try a bit harder to save them from slowing down more.

[Kazuhiko Shiozaki]

fixed in f3024a9c.

For now I reverted https://github.com/mackyle/sqlite/commit/ef49becba4acd5a6bcae1d2674e339ef8636fd94 . I guess that it will be fixed in next released version including https://github.com/mackyle/sqlite/commit/7da458d10104f35b9e3b841753e8222094b162ef .

[Kirill Smelkov]

Thanks