Commit 458068a9 authored by Xavier Thompson's avatar Xavier Thompson

software/slapos-testing: Fix Python2-incompatible versions

statsmodels and websocket-client were pinned to Python3-only versions,
and slapos.toolbox was installed in develop mode from a Python3-only
revision.
parent c10c837c
Pipeline #35199 failed with stage
in 0 seconds
......@@ -9,5 +9,10 @@ extends =
eggs +=
${re6stnet-setup:egg}
[slapos.toolbox-setup]
recipe = zc.recipe.egg
eggs = ${:egg}
[versions]
pathlib = 1.0.1
slapos.toolbox = 0.128.1
  • maybe this part was not needed and something like this was enough ?

    [slapos.toolbox-repository]
    branch = py2
    

    when building on test nodes something like this is used by the testnode configuration, but this is missing in the bare profile.

  • maybe this part was not needed and something like this was enough ?

    [slapos.toolbox-repository]
    branch = py2

    If that seems better we can do that; I preferred installing with the pinned version for Python2 (like a normal egg, not in develop mode) because my understanding is that development is frozen for Python2, so I thought it made more sense to test against the precise Python2 pin and not a revision (even if that revision points to the same release commit).

    If it is desired to still be able to override the revision with testnode configuration, I have no objection to something like branch = py2.

  • Oh sorry, I thought that we were still running the test for SlapOS.Eggs.UnitTest-Master.Python2 on python2, we are not so let's ignore all this. Thanks !

Please register or sign in to reply
......@@ -409,9 +409,10 @@ selectors34 = 1.2
slapos.toolbox = 0.128.1
smmap = 0.9.0
smmap2 = 2.0.5
statsmodels = 0.11.1
statsmodels = 0.11.0
traitlets = 4.3.3
uritemplate = 3.0.0
websocket-client = 0.59.0
Werkzeug = 1.0.1
zipp = 1.2.0:whl
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment