fixup! version up: MariaDB 10.3.18

component/mariadb/buildout.cfg

@@ -32,6 +32,10 @@ url = https://downloads.mariadb.org/f/mariadb-${:version}/source/mariadb-${:vers
 version = 10.3.18
 md5sum = b3524c0825c3a1c255496daea38304a0
 location = ${buildout:parts-directory}/${:_buildout_section_name_}
+pre-configure =
+  set -e '\bSET(PLUGIN_AUTH_PAM YES)' cmake/build_configurations/mysql_release.cmake
+  grep -q "$@"
+  sed -i "/$1/d" "$2"
 configure-command = ${cmake:location}/bin/cmake
 configure-options =
   -DCMAKE_INSTALL_PREFIX=${:location}

[Julien Muchembled]

This is related to ensure that pam plugin is present in release packages.

@kazuhiko Can we do better ?

(I tried -DPLUGIN_AUTH_PAM=NO without success)

[Kazuhiko Shiozaki]

Hmm... If -DPLUGIN_AUTH_PAM=NO does not work, I'm ok with your change above.

[Thomas Gambier]

didn't you want to set PLUGIN_AUTH_PAM to NO @jm ?

/cc @vnmabus

[Thomas Gambier]

Ah sorry, I didn't see the /d at the end of the sed command.

Anyway, I think it is better to explicitly set PLUGIN_AUTH_PAM to NO to be sure that PAM is not enabled.

[Julien Muchembled]

I find that a line that does nothing is worse.

Why are you looking at this ?

[Carlos Ramos Carreño]

Just I problem that I had during my compilation, but I did not notice that it was being overwritten in my software.cfg. No need to change it for now, IMHO.