software/theia/test: adjust test for slapos.core 1.6.15

Now that slapos-node-software service does not use --all we have to use another
approach for this test which re-installs an already installed software.

Use the slapos-node-software-all services which was made for similar use cases.

software/theia/test/test.py

@@ -281,6 +281,8 @@ class TestTheiaEnv(TheiaTestCase):
     }
 
   def test_theia_env(self):
+    """Make sure environment variables are the same wether we use shell or supervisor services.
+    """
     # The path of the env.json file expected to be generated by building the dummy software release
     env_json_path = os.path.join(self.computer_partition_root_path, 'srv', 'runner', 'software', 'env.json')
 
@@ -315,18 +317,21 @@ class TestTheiaEnv(TheiaTestCase):
     # Remove the env.json file to later be sure that a new one has been generated
     os.remove(env_json_path)
 
-    # Launch slapos-node-software from the embedded supervisord
+    # Launch slapos node software service from the embedded supervisord.
+    # Note that we have two services, slapos-not-software and slapos-not-software-all
+    # The later uses --all which is what we want to use here, because the software
+    # is already installed and we want to install it again, this time from supervisor
     embedded_run_path = os.path.join(self.computer_partition_root_path, 'srv', 'runner', 'var', 'run')
     embedded_supervisord_socket_path = _getSupervisordSocketPath(embedded_run_path, self.logger)
     with getSupervisorRPC(embedded_supervisord_socket_path) as embedded_supervisor:
-      previous_stop_time = embedded_supervisor.getProcessInfo('slapos-node-software')['stop']
-      embedded_supervisor.startProcess('slapos-node-software')
+      previous_stop_time = embedded_supervisor.getProcessInfo('slapos-node-software-all')['stop']
+      embedded_supervisor.startProcess('slapos-node-software-all')
       for _retries in range(20):
         time.sleep(1)
-        if embedded_supervisor.getProcessInfo('slapos-node-software')['stop'] != previous_stop_time:
+        if embedded_supervisor.getProcessInfo('slapos-node-software-all')['stop'] != previous_stop_time:
           break
       else:
-        self.fail("the supervisord service 'slapos-node-software' takes too long to finish")
+        self.fail("the supervisord service 'slapos-node-software-all' takes too long to finish")
 
     # Get the supervisord environment
     with open(env_json_path) as f: