erp5: restore ZODB using the --with-verify option of "repozo --recover"

"repozo --verify" is not working as this code expects it to: it simply
prints errors in stdout, and doesn't return an error code in case of
error. Thus, running it had absolutely no effect, except wasting IO
and CPU time.

This commit introduces the use of "repozo --recover --with-verify",
which runs the verify and the recover in a same step, and has the
advantage to raise (it doesn't exit with 0) in case of error. Also, as
it does the verification and the recovery at the same time, it uses
half the IO for the read. On a production server using SSDs, with a
ZODB of 1Tb, runner-import-restore now takes 14h instead of 26h, iow a
performance increase of 46%.

stack/erp5/buildout.hash.cfg

@@ -78,7 +78,7 @@ md5sum = 07012cab8738836bb315f61bcc09c0c3
 
 [template-zeo]
 filename = instance-zeo.cfg.in
-md5sum = d86d6808b745ee66be3a914487b25744
+md5sum = a9d42d8b2aee3c329913d46e0e3cd108
 
 [template-zodb-base]
 filename = instance-zodb-base.cfg.in

stack/erp5/instance-zeo.cfg.in

@@ -154,13 +154,7 @@ input = inline: #!/bin/sh
   fi
   echo "Removing $zodb_path..."
   echo "Restoring $storage_name into $zodb_path..."
-  $repozo --verify --repository="$zodb_backup_directory/$storage_name"
-  CURRENT_EXIT_CODE=$?
-  if [ ! "$CURRENT_EXIT_CODE"="0" ]; then
-    echo "$storage_name Backup verification failed. Backup data is inconsistent."
-    exit "$CURRENT_EXIT_CODE"
-  fi
-  $repozo --recover --output="$zodb_directory/$zodb_path" --repository="$zodb_backup_directory/$storage_name"
+  $repozo --recover --with-verify --output="$zodb_directory/$zodb_path" --repository="$zodb_backup_directory/$storage_name"
   CURRENT_EXIT_CODE=$?
   if [ ! "$CURRENT_EXIT_CODE"="0" ]; then
     EXIT_CODE="$CURRENT_EXIT_CODE"

[Jérome Perrin]

"repozo --verify" is not working as this code expects it to: it simply prints errors in stdout, and doesn't return an error code in case of error.

for reference we fixed this in https://github.com/zopefoundation/ZODB/pull/396 but it's anyway much better to use --recover --with-verify and do only one pass.

( I'm even wondering why --with-verify isn't the default in repozo )