Commit 807512ec authored by Ivan Tyagov's avatar Ivan Tyagov

Add comments.

parent 941ae3d1
"""
This script is used in Ingestion Policy objects to parse provided by fluentd / ebulk reference.
In this case it expects a reference in this format for example:
'sensor1'
  • @Tyagov Please note that this script only works in following cases:

    1. product_reference==sensor_reference
    2. product_reference==sensor_reference.something

    This should be mentioned in comment.

    Also the implementation of this script is quite confusing so I think it would be better to add a deprecation note to the script and keep it only for backwards compatibility.

    It would be easier for all of us to follow the changes on default ingestion policy, data supplies and scripts if they would be done in a merge request. This is not necessary for all commits, but in this particular case of "default way to ingest data" it would help a lot.

  • @klaus , generally I agree.

    But MR for comments which should have been added at the first step by author (which is not me) I find useless waste of time. I will add your note to comment.

Please register or sign in to reply
i.e. no special characters and one name only.
If you need to use more complex hierachical reference notations like:
'sensor1.product1'
you can use script: 'IngestionPolicy_parseSimpleIngestionTag'
"""
project_reference = reference.split('.')[0]
return {'resource_reference' : reference,
'specialise_reference': project_reference,
......
"""
This script is used in Ingestion Policy objects to parse provided by fluentd / ebulk reference.
In this case it expects a reference in this format for example:
'sensor1.product1'
"""
sensor_reference = reference.split('.')[0]
data_product_reference = reference.split('.')[1]
return {'resource_reference' : data_product_reference,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment