- 07 Dec, 2018 2 commits
-
-
Ayush Tiwari authored
[erp5_core] Follow guidelines for Actions on portal types Catalog and Catalog Tool by adding dialog before executing Also, Cleanup useless actions and functions /reviewed-on nexedi/erp5!811
-
Jérome Perrin authored
* Assorted small fixes so that form comply to conventions * Minimal fixes of invalid html * make `mixin` usable in type definition The context is I was working on a custom configurator involving some matrixboxs, so I needed a simple business configuration item just to store the matrix result. This was possible with mixin, I just made a portal type based on Item class, enabling mxins for `Matrix` and `BusinessConfiguratorItem` and I did not have to define a class ( not sure this is really better ). Then the matrixbox was not rendering properly, because browser was confused by the broken html and build a "different DOM" and selectors did not apply. This is what `configurator: fix (a bit) invalid HTML` addresses. While doing this, fix some minor problems found with forms. /reviewed-on nexedi/erp5!814
-
- 06 Dec, 2018 13 commits
-
-
Jérome Perrin authored
Insert fields in a <div>, not in a <table>, fields are not valid table elements (they are not <tr>). Configurator still produce invalid HTML, this seem to be the minimal fix to have matrixboxs rendered properly without having to rewriting all configurator page templates.
-
Jérome Perrin authored
So that all string fields have same width
-
Jérome Perrin authored
-
Jérome Perrin authored
If user still has a cookie from a previous run this this will cause problems. This is a dirty workaround. Why configurator has to use cookies ?
-
Jérome Perrin authored
https://www.erp5.com/erp5-HowTo.Create.Action.Dialogs > The action must use an intermediate dialog, where the user can enter parameters. Also allow to set a name for the business configuration that will be created.
-
Jérome Perrin authored
* fix typo in column name * add editable field for correct display
-
Jérome Perrin authored
I'm not sure this workflow is used, just fix the transition which were using non existant dialog or wrong transitions names.
-
Jérome Perrin authored
-
Jérome Perrin authored
... otherwise when nothing is selected it looks like something is set. Also translate and sort output.
-
Jérome Perrin authored
Slapos build does not seem to support gif.
-
Jérome Perrin authored
* it should be a *list* mode listbox (it was a view mode) * listbox column title should be the portal type name ( no written rule for this apparently ) * listbox title should be plural of portal type https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#set-listbox-title-to-plural-of-portal-type-title-if-applicable
-
Jérome Perrin authored
my_view_mode_listbox_configuration_save should use my_view_mode_listbox as target, not my_list_mode_listbox
-
- 05 Dec, 2018 4 commits
-
-
Vincent Bechu authored
-
Sven Franck authored
/reviewed-on nexedi/erp5!810
-
Nicolas Wavrant authored
As source reference is the public reference of the Mandates (ie: RUM in the case of SEPA debits), it is even more useful than the simple reference
-
Nicolas Wavrant authored
also disble in testI18NSearch the test which depends on catalog_full_text
-
- 04 Dec, 2018 13 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
Tests: do not depend on previous test executions.
-
Romain Courteaud authored
See nexedi/erp5@cfa45fd8
-
Romain Courteaud authored
Shamelessly copy Listbox.py implementation, which limits acquisition usage For compatibility, do not check local properties when the listbox uses contentValues (ListMethodWrapper).
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Keeping the browser's back button usable is a requirement to keep users happy.
-
Jérome Perrin authored
First, cleanup `testERPSecurity`, moving related tests in sub-classes instead of big classes with lots of tests (diff is big, because methods are moved around) Change google and facebook login to reuse `portal.setAuthCookie`, which is the central point to set a cookie securely so that it can be used for authentication. Refactor management of oauth keys to fix [#20181121-1A36AE2](https://nexedi.erp5.net/bug_module/20181121-1A36AE2). Some minor fixes in business template definition. /reviewed-on nexedi/erp5!803
-
Jérome Perrin authored
Originally, there was a regression introduce in my recent changes that "Comment Author" column was always empty. This MR contains some more refactoring for "Comment Date" and "Comment Author" columns: ![image](/uploads/7b07a6a5610d533f1435af45b3716104/image.png) On the visible side, "Comment Date" column has been simplified, it used to show "hour:minutes" if the message was posted today, and "year/month/day" if the post was older. It's now a simple date time field (using `Base_viewCRMFieldLibrary/my_event_start_date`), for consistency. On the implementation side, they now use existing `SupportRequest_getCommentPostListAsJson` script, which simplified code a lot. That script was also renamed as `SupportRequest_getCommentPostList`, because it's no longer returning JSON. /reviewed-on nexedi/erp5!804
-
Jérome Perrin authored
Some tickets (for example Support Request or Bugs) are focus on one small thing being discussed where usually a small number of events are posted. Unlike for example a campaign where there is a large number of events sent to a large number of recipients, in the case of these "small, self contained" tickets, it makes a lot of sense to see that the ticket was modified when a new event is posted on this ticket. This is what we sometimes customize in some support request fast input. It was the case in Support Request App, but this was removed in 74fc68a7 , this time it's done at a lower level and such customisations are no longer needed. /reviewed-on nexedi/erp5!807
-
Jérome Perrin authored
Because this was displaying all worklists from ticket_worklist, which is also used for all tickets (including for example Campaigns) and that displaying other kind of tickets that Support Request is not supported on this app, we should filter the worklists to display only support requests. /reviewed-on nexedi/erp5!808
-
Yusei Tahara authored
testERP5Core: jump_related_object is lower priority now. See 9e152672.
-
- 30 Nov, 2018 4 commits
-
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Nicolas Wavrant authored
Also add a comment in getSearchableText to explain why
-
Nicolas Wavrant authored
As it will get the string represenation of the dates, and not even the date formatted given the system / user preferences. Thus it makes no sense to fulltext search on it.
-
- 29 Nov, 2018 1 commit
-
-
Jérome Perrin authored
-
- 28 Nov, 2018 1 commit
-
-
Jérome Perrin authored
also make testTemplateTool.test_updateBusinessTemplateFromUrl_keep_list more isolated ( but testTemplateTool still has isolation issues )
-
- 27 Nov, 2018 2 commits