- 04 Jul, 2019 5 commits
-
-
Roque authored
-
Jérome Perrin authored
This works only for medusa, using the same approach as CMFCore's CookieCrumbler Also increase test coverage of google/facebook plugins. /reviewed-on nexedi/erp5!901
-
Jérome Perrin authored
What I'm trying to prevent, is that when we have a document with leading/trailing space ![image](/uploads/8a00a1019cdcb5d76bd589917548a515/image.png) and it's set in a relation ![image](/uploads/925aa9895c7d15f3ef9f3bdc9926d7fd/image.png) just clicking save will complain that document is not found ![image](/uploads/a559eea23fc8ba0df19c23dfcda26138/image.png) this is because validator have stripped whitespace and search for `"leading and trailing space"` - and find nothing (unless title is a keyword key, but that's another story ) /reviewed-on nexedi/erp5!897
-
Sebastien Robin authored
Until know, in the preference we defined list of uri for conversion server, and then we were trying always in the order defined in the preference. But this is not optimal, when a server start to fail, it's better to try using another one. So sort list of uri in such a way to use first server having the most chance to work.
-
Arnaud Fontaine authored
Useful for SolverType._configuration_property_dict but more generally the whole history should be displayed as this view is used by developers.
-
- 02 Jul, 2019 1 commit
-
-
Georgios Dagkakis authored
erp5_web_renderjs_ui: Don't crash if form has 'Update Action Title' but no 'Form update action' defined. Even though this is inconsistent form definition, form_dialog gadget should not crash
-
- 01 Jul, 2019 8 commits
-
-
Sebastien Robin authored
in MRP, we have manufacturing execution having a mix of lines with positive and negative values. It must be possible to use split and defer solver in that case.
-
Georgios Dagkakis authored
For example, Categories in "expired" state. As a consequence, user is included in cache key. /reviewed-on !899
-
Romain Courteaud authored
-
Jérome Perrin authored
This works only for medusa, using the same approach as CMFCore's CookieCrumbler
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
- 28 Jun, 2019 3 commits
-
-
Julien Muchembled authored
-
Bryton Lacquement authored
-
Jérome Perrin authored
This function have evolved to something very trivial not accessing anything from database, so caching this no longer really makes sense, also the cache keys are really big. On a quick benchmark of calling ERP5Site_getTabList 10000 times: with cache: ERP5Site_getTabList took 12.961781 without cache: ERP5Site_getTabList took 5.395873
-
- 27 Jun, 2019 6 commits
-
-
Romain Courteaud authored
Only send line data if the text is not empty and ensure there is no hole in the uid list. This will fix the edition when the field already contains some homonyms. Only append empty input if the latest one is not empty. Replace verify by assert in the tests.
-
Romain Courteaud authored
Fixup 18415f4d
-
Sebastien Robin authored
When we ignore variations, we should also ignore them when looking to update existing orders
-
Julien Muchembled authored
erp5_web_manifest_test:testManifest leave a -1 activity.
-
Bryton Lacquement authored
W3Validator seems obsolete now since it does not validate HTML5. nu became the default validator in 417ff1ae. /reviewed-on nexedi/erp5!786
-
Jérome Perrin authored
Add some tests and fix bugs: * https://nexedi.erp5.net/bug_module/20170426-A3962E * another bug that columns names were not escaped ( in a project we have a custom table with a column named `use` and this breaks `upgradeSchema` ) /reviewed-on !854
-
- 26 Jun, 2019 3 commits
-
-
Sebastien Robin authored
-
Jérome Perrin authored
Note that we can't really use " " in test tables, for input selenium supports ${space} magic that types a space characters, but to check the values, we cannot just use assertValue which strips the leading/trailing spaces, so we use a custom assertEval expression.
-
Jérome Perrin authored
We want to search for what user entered, if we strip whitespaces we would not match trailing or leading spaces
-
- 25 Jun, 2019 2 commits
-
-
Klaus Wölfel authored
Since 8a6c4394 Item_getTrackingList sets parent and id on brain instead of url. testItem now passes: https://nexedijs.erp5.net/#/test_result_module/20190625-614B59A1 /reviewed-on nexedi/erp5!898
-
Jérome Perrin authored
This will apply to newly created relation fields.
-
- 24 Jun, 2019 10 commits
-
-
Bryton Lacquement authored
This first work on WSGI is only to stop using ZServer (Medusa), which is a required step before moving to Zope 4. This means that Zope should behave almost exactly the same way as before, notably: - We don't take advantage yet of what WSGI offers, like IPv6. - There's extra code to handle errors the same way as before (this is something we'll have to change for Zope 4). The most significant change in behaviour is that the chosen WSGI server (waitress) does some of the HTTP work in worker threads (Medusa does it entirely in the IO thread), and the biggest consequence concerns the deadlock debugger that is now run from the worker thread: - it does not work if all threads are blocked - doing better would require to patch waitress in a quite ugly way About TimerService, we simplify things by removing the egg. In zope.conf, it's possible to import from the product. /reviewed-on nexedi/erp5!883
-
Bryton Lacquement authored
At the same time, timerserver is no longer distributed as an egg.
-
Bryton Lacquement authored
-
Bryton Lacquement authored
-
Bryton Lacquement authored
zope.globalrequest is a new dependency of Zope 4 and it is already used by the backported WSGIPublisher.
-
Bryton Lacquement authored
Parts of ZPublisher.utils are also backported.
-
Bryton Lacquement authored
This is a preliminary commit that only adds a verbatim copy of WSGIPublisher.py
-
Sebastien Robin authored
-
Klaus Wölfel authored
Clinking on the rows of item tracking view was not working in renderjs ui. /reviewed-on nexedi/erp5!894
-
Georgios Dagkakis authored
Since BankAccount_view already has a my_comment field
-
- 22 Jun, 2019 1 commit
-
-
Bryton Lacquement authored
Example for erp5_web_renderjs_ui_test:testFunctionalRJSRelationField, which was failing randomly (fixed in ca229c3e): ====================================================================== FAIL: testFunctionalTestRunner (erp5.component.test.erp5_version.testFunctionalRJSRelationField.TestRenderJSUIRelationField) ---------------------------------------------------------------------- Traceback (most recent call last): File ".../product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py", line 372, in testFunctionalTestRunner self.fail('\n'.join(error)) AssertionError: These messages are pending: [('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_catalog', 'unindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/3', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -2, 1)] Last error message: RuntimeError tic is looping forever. Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish request, bind=1) Module ZPublisher.mapply, line 77, in mapply if debug is not None: return debug(object,args,context) Module ZPublisher.Publish, line 48, in call_object result=apply(object,args) # Type s<cr> to step into published object. Module Products.ERP5Type.patches.ExternalMethod, line 113, in __call__ return _f[0](self.aq_parent, *args, **kw) Module erp5.component.extension.erp5_version.ERP5Zuite, line 21, in waitForActivities raise RuntimeError('tic is looping forever.') RuntimeError: tic is looping forever. testAccessUnauthorizedRelationValue testBreadcrumbCanNotAccessRelationSearchPage testMultiRelationDefaultSortAndParameterList testMultiRelationFieldEmptySearchWithListbox testMultiRelationFieldHomonyms testMultiRelationFieldSearchWithListbox testMultiRelationFieldSearchWithProxyListbox testMultiRelationFieldUnknownIcon testMultiRelationFieldWithNonSavedPageContent testProxyListBox testRelationDefaultSortAndParameterList testRelationFieldEmptySearchWithListbox testRelationFieldRefresh testRelationFieldSearchWithListbox testRelationFieldWithNonSavedPageContent testSimpleMultiRelationField ---------------------------------------------------------------------- Ran 1 test in 199.267s
-
- 21 Jun, 2019 1 commit
-
-
Romain Courteaud authored
-