<h1>, <h2> ... currently have a style applied by gadget_nojqm.css that
does not make them look like header.

Apply a local override for now.

The vertial space between two <p> was not different from the vertical
space between two lines in a <p> making it hard to visualize the
boundaries of paragraphs.

On both the "create new support request" and "post new message on an
existing support request", enable the "Maximize" button so that users
can author their message in larger editor.

If we have a dialog with an editor field in bottom group, then dialog
action buttons does not fit on the screen.
Until rjs_gadget_erp5_nojqm.css allows using editor in bottom groups of
dialog, let's put them in center group, because editor in center group
have "normal" size and the action button fits.

This reverts commit 11b815bc.

This approach was not enough to solve on all dialogs the problem that
button is not always on the screen and it can still be confusing.

nexedi/erp5!800 (comment 69514)

- introduce a `form_dialog` class on dialog gadget, so that we can apply
different styles.
- add a rule overriding the rule making "big" editors in bottom group so
that in dialog mode they are not so big.
- force the maximize class to apply its height as !important, because
the added selector being more specific, it has priority over the one
from maximize.

http://lesscss.org/less-preview/ has been used to compile .less in .css

The default "don't style list item" rules from gadget_erp5_nojqm where
not good here, because user expects list items to be displayed in the
"standard" way (like in the CKeditor)

Before this change, `index_html` for Catalog Tool was None that means trying to
access view for CatalogTool from UI always make a function call to the
` __call__` which function was overridden with `searchResults`, which
means everytime someone tried to access `portal_catalog/`, a useless query was
being made and an undesirable query result was displyed on the UI.

In this case, `index_html` is prefered whenever we try to access portal_catalog
from UI.

Also, add test for proper display of view when CatalogTool is accessed from XHTML UI

/reviewed-on nexedi/erp5!793

* Problems with data migration ( some events had no source, the logic of using current user was anyway wrong ) 
* Problems with security
* RSS too small

( see commits for details )

/reviewed-on nexedi/erp5!792

.pop .popitem and .setdefault where returning None

/reviewed-on nexedi/erp5!791

Security might be configured in a way that even if user can see the
support request he cannot see all events related to that support
request. We should handle this case by filtering out the event and not
letting Unauthorized error happen.

There was an issue that RSS was failing with Unauthorized errors when there was some events users cannot access.

(once again, thank you zope security, it was not leaking information just causing error)

default of 5 is not enough and must have caused people to miss messages ( when more than 5 messages are posted between 2 refreshes from their RSS reader)

Project use case: Use modification_date instead of operation_date to export
ATs modified the day before.

erp5_accounting_l10n_fr: Allow to pass additional Catalog parameters to select Accounting Transaction to FEC export.

Introduced for customer Unit Tests to be able to FEC export only ATs of the
current Unit Test FEC based on 'title'.

Called by TransformationSimulationRule and did not work with the
following use case:

  BL(trade_phase=TP1, successor=trade_state/TS1):
    * child_BL1(predecessor=trade_state/TS1,
                trade_phase=TP1/InventoryAccounting)
    * child_BL2(predecessor=trade_state/TS1,
                trade_phase=Transforming)

.. not the current logged in user.
This way, it's possible to run the post ingestion as another user, for example
running by an alarm or as a data migration.

bt5/erp5_scalability_test: Remove a Permission Configurator Item. It depends on standard_module_permission_access.ods, but it was already removed from erp5_configurator_standard skin folder.

in accounting_module and sale_order_module listbox.

The "Sale Trade Condition" column was showing first found specialise title
instead of the Sale Trade Condition one.

This adds z_related_specialise_trade_condition with related key specialise_trade_condition_title
and an accessor getSpecialiseTradeConditionTitle

We edited the HTML, but did not include the accompanying increase of modification date.

See nexedi/erp5!662 (comment 65953) for more on this issue.

/reviewed-on nexedi/erp5!790

When a workflow transition was not used by any state,
calling some_module.Module_listWorkflowTransitionItemList was raising:
    [..]
      Module script, line 49, in Module_listWorkflowTransitionItemList
       - <PythonScript at /tsxx/Module_listWorkflowTransitionItemList used for /tsxx/some_module>
       - Line 49
        result['listbox_parameter_dict'][transition_id] = [(state_variable, allowed_state_dict[transition_id])]
      Module AccessControl.ZopeGuards, line 83, in guarded_getitem
        v = object[index]
    KeyError: 'some_action'

Now, pick transition among the allowed_state_dict instead of workflow.transitions.

This also fixes mass change state dialog "??? ()" issue.
This commit adds a transition that allows to reproduce that issue.
And this line covers the case :
bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_zuite/testMassWorkflowTransition.zpt (line 61)

/reviewed-on nexedi/erp5!788

Some things in support request app where working apparently a bit by chance and they no longer work with new erp5_hal_json (
09d00cae )

This aims at using erp5_hal_json as intended and simplifying the customisations by customising "only" the header gadget and not the page gadget.

/reviewed-on nexedi/erp5!787

erp5_real_time_inventory_accounting: Accounting Transaction state should be 'Posted to General Ledger' (stopped), not draft.

erp5_hal_json does not seem to allow using gadgets by page name,
anymore, so instead of using a custom "page template" gadget (
disclaimer: I have not really understood this fully at this point).

Instead of using a custom page gadget, just use a header gadget that
"extends" the default gadget but removes the add_url

Because the fast input should be used.

Also simplify a bit the test, there's no need to add a SR in this case.

This reverts commit 463855b6.

unlike RSVP.all, RSVP.hash is not patched to support cancellation, so
it's not safe to use it at the moment.

Such as:
  - getStartTransitionDateList() and getStartTransitionDate().
  - getDeliverTransitionDateList() and getDeliveryTransitionDate().
  - ...

Where the non-List accessors returned the last element.

Use Case: Set AT.{start,stop}_date from PPL stop transition date.

Until this commit, loading a ZODB Component would add it to the current Request
object to prevent its reference counter reaching 0 (thus its global being reset to
None and then being later GC'ed) when a reset happens in another Request.

This problem was found when investigating testFunctionalConfigurator failure
when installing bt5s as requested by the Configurator:
  1. Request R1 calls Zuite_waitForActivities importing extension.erp5.ERP5Zuite (M1).
     => Add M1 to R1._module_cache_set.
     => M1 ref counter equals to 2 (sys.modules and R1._module_cache_set references).
  2. R1 terminates and is GC'ed.
     => M1 ref counter equals to 1 (sys.modules).
  3. Request R2 runs Configurator configuring the Site.
  4. testFunctionalConfigurator calls Zuite_waitForActivities to wait for the
     Configurator to finish (request R3 which may take ~15 minutes). This calls
     time.sleep() in a loop where 'time' module is imported at top-level.
  5. R2 installs bt5 triggering reset.
     => M1 ref counter equals to 0.
        ===> M1 global variables are reset to None and thus 'time' is set to None
             raising an Exception in the next call of time.sleep() in the loop.

The easiest way would be to have a hook on sys.modules dict lookup and thus add M1
to R2._module_cache_set when being imported, but this is not supported... Instead
create a global cache on erp5.component package.

There is no action with referecne `list` on support request module.