- use environment variables to pass SLAPOS_TEST_LOG_DIRECTORY and SLAPOS_TEST_SHARED_PART_LIST, as discussed on nexedi/nxdtest!2
- Fix #20200514-218C705 - [testnode] frontend for log access

See merge request nexedi/erp5!1304

This is used and should not be disabled.

There was an error when clicking this dialog, fix that error instead.

See merge request nexedi/erp5!1301

In ERP5JS when redirecting we can use `portal_status_level` to control the appearance of the notification.

This updates the cases when user action could not be performed to redirect with an error level, so that notification appears in orange, not in green (in ERP5JS - in erp5_xhtml_style this has no effect).

accounting, base, trade were updated

See merge request nexedi/erp5!1303

See merge request nexedi/erp5!1302

so that installed objects are owned by System Processes and we can have faster ownership checking for proxy role scripts.

Portal is the Skinnable object, skin magic belongs there.

Also, modernise it a bit.

testnode use to publish the URL of logs so that Nexedi ERP5 can
display link to "view logs". This URL was an IPv6 URL on a certificate
which does not validate.

Now testnode software release request a shared frontend for these
logs and generate a config file with log_frontend_url set.

testnode now advertise the URL of log using the log frontend url
from config.

Also simplify frontend_url key to manage it using the same way.

SLAPOS_TEST_LOG_DIRECTORY and SLAPOS_TEST_SHARED_PART_LIST have been
introduced recently, they are passed to runTestSuite using the usual
way of running runTestSuite once with --help to inspect supported
arguments and passing the argument only if runTestSuite supports them,
but these arguments are not necessarily heavy to compute and are always
known (unlike for example firefox path which is only known if seleniumrunner
extra software was installed), so simplify all this by passing the
parameters are environment variables.

because title is acquire from id, we want to edit title first for the
case where we change ID, otherwise saving would save the old ID as
title.

 * don't set "hide rows on no search criterion", this should not display
too much and search is broken.
 * use preference to get number of lines

This action was working fine the first time displayed, but clicking
again on "View Diff" button was causing an IndexError: list index out of range
when used on one document.

This was because in this case list_selection_name exists in REQUEST, but
is an empty string. Instead of checking that this selection name is not
None to detect if we are in module mode or in document mode, check that
its true-ish to also tolerate an empty string.

This reverts commit 06a7737f.

Base_getDialogSectionCategoryItemList was supporting the case of
users from zodb_users plugin, but not the case of ERP5 users with
roles set from zodb_roles.

It's a more and more common case to make manager users using a
"normal" ERP5 user as person (so that we can reset password etc)
and to give Manager role by zodb_roles, but this was not supported
by this script.

Now that we properly detect 0 tests as errors/UNKNOWN, this test was reported
as UNKNOWN state. Run the tests, but as expectedFailure since they have not
been updated since b4b5bcf8.

See merge request nexedi/erp5!1259

See merge request nexedi/erp5!1293

The space between listbox column header and icon used to display the sort order
was a bit too small, making it hard to see if the sort was ascending or descending
sometimes.

To have more space, set a margin-right on the before pseudo-element, like we are
already doing for buttons with text and icon.

erp5_web_renderjs_ui: Change date separator from a dash to a slash before sending query to Zope. If date separator was a dash, Zope DateTime does not use local timezone and date search does not work.

Now that this is supported, make it available also for default sales,
purchase or internal supply lines directly on resources. Until now,
this was only available on supply line view.

So far price were always assumed to be defined in the default
quantity unit of the resource, even though supply lines had a
quantity unit field, it was ignored. But it can be useful to
define prices using another quantity unit than the default quantity
unit of the resource, for example when a resource is purchased
in kg but managed in m³.

To support such scenario, we adjust the priced quantity unit
when applying price.

At the end of test result, we calculate the sum of test result line
retries and set it as a property on test result. Listbox will then
show for each test result line the number of retries. Problem is
that we did not set retry count property on test result lines which
were not retried, so they acquired this from the parent test result.

To prevent this, always set a retry count property on test result
and set it to 0 when they are not retried.

In 4bcf5c6a (CatalogTool: Introduce new dynamic related key syntax, 2017-07-25)
we introduced a new syntax to solve some ambiguities in the previous syntax, but
the test suite was still testing the old syntax only.

Update tests to test the new syntax and to also check the old legacy syntax.