For most of theses, we can not change without risking to break
compatibility. Some of them are misnamed legacy fields library or some
forms that still needs to be updated to use field libraries.

Checking some conventions for form, dialog and reports based on
https://www.erp5.com/documentation/developer/guideline/programming/
and https://www.erp5.com/documentation/developer/guideline/module/

For now we implement only a few checks, we will extend later.

jsl complains about "class" in object literals, but there's nothing wrong
with this.

portal_skins/erp5_vcs/gadget_vcs_status.js
(17): SyntaxError: invalid property id
      class: true,

This fixes the testNamingConvention failure:

    AssertionError: erp5_vcs/BusinessTemplate_viewVcsStatusDialog : your_commit_json : can't be empty

Since this field is in bottom group, the label is not rendered, so it's
not needed to hide field name with some TALES.

This dialog had a proxy field to another field from the same dialog (
BusinessTemplate_viewGitLogin/your_auth ).
When dialog was renamed, proxy field got broken.

To ease maintenance, proxy to the same field as BusinessTemplate_viewGitLoginDialog/your_auth
is using.

Follow naming convention: https://www.erp5.com/documentation/developer/guideline/programming/erp5-Guideline.Programming.Naming.Conventions/#dialog-form-name-is-postfixed-with-dialog

* update template tool configuration
* create working copy
* create skin folder
* throw away local changes

Add a gadget to display and select the list of changes.

The gadget will show the selected diff to change the selection if needed.

Changelog can also be directly entered in the gadget to quickly switch the view while writing it.

Use usual ERP5 page template to commit bt5 changes from ERP5.

Use an hidden field to propagate all needed input values in case of an exception.
This single field will keep a json value, to simplify the maintainance of all forms using it (instead of many string fields).

Stop accessing the REQUEST directly, and rely on ERP5 navigation scripts (like Base_redirect) instead.

See ea219b74

See d7a4c3fc

Fixes #20200630-BB32 and #20200630-48F9FA

See merge request nexedi/erp5!1318

in c361a8c3 (erp5_pdm: improve product invividual variation, 2020-03-09)
we changed to allow default images in product individual variation and modified
IndividualVariation_view to add a file upload field to upload an image, but this
form is shared with other individual variations portal types.

Without setting the default image property sheet and allowing Embedded Files as
sub-documents, saving the form was causing an error.

Possible services depend on the selected project.

If we only refresh this list when user selects another project, we don't
support the case where there's only one project available for user, because
the list of services is the default one, not the one filtered for the
select project.

Now that we have an empty item, we should make sure user selects something.

If we have more than two options to project and resource

RSVP.Promise cancel callback do not expect a Promise as result.
In order to handle potential errors triggered by setButtonTitle, run it in an renderjs's job.

See merge request !1285

We no longer run tests with `python setup.py`, but simply with `python -m unittest`

With nexedi/slapos!862 we no longer need this

See merge request nexedi/erp5!1316

See also https://github.com/zopefoundation/ZEO/pull/63
     and !1095

No error in testCMFActivity and testConflictResolution.
For the only error in testInvalidationBug, see comment.

But this commit is not enough for ZODB5. The only known issue so far
is the use of newer pickle protocol, which breaks export of ZODB data
and requires non-trivial changes in our XMLExportImport/ppml code.
So for the moment, many failures in testBusinessTempate.

erp5_web_renderjs_ui_test: reproduce validation error issue and add asserts to make sure field has expected class

* Trigger focus and blur to test renderjs functions properly
* Add asserts to make sure we don't lose value after raise Invalid Date
* Cover issue that invalid class does not disappear after click to create new object Foo in relation input
* Make sure fifth_failure input has invalid class
* Cover validation error to multicheckbox, checkbox and radio fields

* change the label field to not display the error text by default
* change all html5 fields (input, select, textarea) to add a custom *invalid* class when the field is invalid
* change all html5 fields to listen to the `focus` and `blur` event (with the renderjs onEvent method)
  Then, acquire (with `declareAcquiredMethod`) and call `notifyFocus` / `notifyBlur` methods respectively.
* change the label field to handle `notifyFocus` / `notifyBlur` (with `allowPublicAcquisition`).
  Change the validation error text display state depending on the field status
* Trigger onStateChange to set invalid class. If error comes from input field, we need to change state locally to set invalid class
* Regenerate gadget_erp5_nojqm.css from  erp5less.css using http://lesscss.org/less-preview/
* Textarea gadget should not prevent default when invalid event is triggered
* Support notifyFocus and notifyBlur in panel

Users with only view permissions in accounting should not be offered to use
the grouping reference fast inputs, because grouping transactions is a kind
of modification.

Listbox title is automatically translated, calling translation explicitly
is wrong here.