- 14 Apr, 2022 4 commits
-
-
Jérome Perrin authored
follow up of 8a335cca (component: fix error_message saved in every line of history, 2022-02-18)
-
Jérome Perrin authored
re-exporting a business template that was just installed should not be different. By having a test reporting diffs in export, we can detect changes in ERP5 or dependencies which would cause the business template format to become different. The primary reason for doing this was to make sure that on the way to Zope4 we don't have changes in exported data, especially lossly changes that would not be detected in test suite, but this is also good because it helps detecting changes that cause a difference in output - then if we introduce a change that cause different business template export, we also have to make a change to re-export everything to new format, which helps keeping the git history cleaner because there's one big commit with all the changes instead of having many small commits. This is also good because it detects mistakes when modifying business templates files directly with a text editor. The test can be configured to ignore some paths, using fnmatch pattern (which unlike business patterns do not support ** for recursive match). This is also helpful when using this test case to check customer configuration business templates, where we may want to ignore some PathTemplateItem for conveniance. This also include fix for almost all current cases where re-exporting produce a diff, except a few cases that the reason for the diff was not understood, they were added to the ignore list instead. See merge request nexedi/erp5!1575
-
Jérome Perrin authored
This way, clicking on the label is enough to select the radio button, or tick the checkbox, no need to click on the small button. This is also probably better for accessibility. CSS is adjusted a bit, so that the style for "general" field labels do not apply to this new label.
-
Jérome Perrin authored
The status message no longer use system-msg class, use simpler "assertTextPresent" that should be enough. Simplify the waiting for static pages, clickAndWait is enough.
-
- 12 Apr, 2022 1 commit
-
-
Romain Courteaud authored
Always recalculate the full matrixbox content if one change is found. Add mutex to prevent raise condition between render and getContent.
-
- 11 Apr, 2022 1 commit
-
-
Kazuhiko Shiozaki authored
-
- 08 Apr, 2022 3 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
See ed0c1297
-
- 07 Apr, 2022 2 commits
-
-
Jérome Perrin authored
With the new workflow implementation, error_message variable is required, because we intentionally clone previous workflow history entries when passing transition, as this leads to smaller pickle size See merge request nexedi/erp5!1560
-
Romain Courteaud authored
Use the html_viewer gadget
-
- 05 Apr, 2022 8 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Jérome Perrin authored
fix internal API mis-use and other small fixes See merge request !1583
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This was creating different message for each number of tasks
-
Jérome Perrin authored
This uses an internal API that has changed in 0aeea3c4 (Validation message translation, 2021-01-06)
-
- 31 Mar, 2022 5 commits
-
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Gabriel Monnerat authored
With this, user can see stop_date from events
-
Gabriel Monnerat authored
With TALES in default, we prevent acquisition from the start date. When default is None, the field will try to display now on the stop date. The goal is, if stop_date is None, we don't display anything in this field.
-
Gabriel Monnerat authored
stop date is very useful to Phone Call and Visit. For example, if you want to calculate the time spent in one phone call, you can handle it using start and stop date. But, Event_view does not display stop_date. So, we display stop_date if hasDuration is True.
-
- 30 Mar, 2022 1 commit
-
-
Georgios Dagkakis authored
No need to introduce one more random number here, anyway the tag that is passed to this script contains one, so use that
-
- 29 Mar, 2022 1 commit
-
-
Georgios Dagkakis authored
Base_report needs to get also the cleanup_tag to make sure it is launched before active process is deleted
-
- 24 Mar, 2022 2 commits
-
-
Julien Muchembled authored
When rendering a proxy field, 3 different fields can come in play: 1. the field to be rendered 3. the template field (i.e. not a proxy field) that knows how to render 2. possibly an intermediate proxy field that contains the value to render What's difficult when rendering a proxy field is to take the above 3 fields into account and this commit does it by creating a temporary field: 1. 'field' variable in TALES 2. the value 3. the code Before this commit, 1 could be wrong.
-
Jérome Perrin authored
This was deprectated because we don't have get*ById for other modules and tools, we just use OFS API. This should also be slightly faster because one less method call (and one less call to warning)
-
- 23 Mar, 2022 4 commits
-
-
Jérome Perrin authored
exiting the context manager restores the original DateTime behavior
-
Jérome Perrin authored
This tests the test framework, because this code is tricky.
-
Jérome Perrin authored
-
Jérome Perrin authored
I'm not sure if this is used, but not being valid python code cause problems with code analysis tools
-
- 22 Mar, 2022 1 commit
-
-
Jérome Perrin authored
Maybe this made sense long time ago, but nowadays we are using equivalence testers which tolerate date differences with more flexibility. createDateTimeFromMillis was also problematic as it uses internal private attributes of DateTime which is a pylint error with more recent DateTime
-
- 21 Mar, 2022 2 commits
-
-
Romain Courteaud authored
Permissions are managed by the document_publication_worflow
-
Xiaowu Zhang authored
-
- 18 Mar, 2022 1 commit
-
-
Jérome Perrin authored
Most service worker precache scripts reference a favicon.ico, but this is using the default favicon.ico from Zope and even though it was included in all ERP5JS and OfficeJS web sites, this was mostly not used, only web_renderjs_ui web pages reference favicon.ico. There's a favicon.ico in erp5_xhtml_style skin folder, but the skin folder is not in ERP5JS skin selection. On Zope2, this caused ERP5JS and OfficeJS application use the default Zope favicon. On Zope4, the service worker can not fill its cache because of 404 errors, because since Zope commit 4f0770941 (Retired icons from the `Zope Management Interface` and various smaller cleanups of ZMI screens., 2011-07-02) there's no default favicon.ico anymore. To solve this, provide a favicon.ico in ERP5JS skin selection, by copying the one from erp5_xhtml_style. We also reference it explicitly in web site layout properties so that it remain in the cache. OfficeJS applications do not use favicon.ico explicitly. They use icons in their web application manifest, but this does not seem to be use as favicon unless the PWA is installed. This part is not addressed by this commit.
-
- 17 Mar, 2022 4 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
For now only checks that error_message is missing, but later we might extended this to perform more check on the workflow definition.
-
Jérome Perrin authored
After df85ef46 (ERP5Workflow: DC Workflows are now ERP5 objects (!1378)., 2020-11-18) we increased the expected value from 24 to 36, because it was just different with new workflow implementation and what was important is to have large buckets. After that, the test was flaky and eventually we changed the assertion from checking that the value equal the expected value to checking that it's larger to checking that it's larger to a satisfying value and we used the initial 24 for satisfying value. A large value here means the bucket contain many items, which happens when the pickle size is small We now understand that pickle are short when the pickler was able to deduplicate some strings because they were the same instances (as compared by `is` operator). Note that this deduplication happens before the one operated by Products.ERP5Type.Workflow.dedupStrings after bucket rotation, it's the "normal" deduplication from pickle happening when element are added to list. Because it's a good thing for disk usage to have small pickles, we raise our expectation and increase the expected minimal value to be 30.
-