slapos_crm: Open Sale Order are archived earlier

    If the user has just archived OSO, it means he destroyed everything (also).

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm/RegularisationRequest_cancelInvoiceIfPersonOpenOrderIsEmpty.py

@@ -10,38 +10,61 @@ person = context.getSourceProjectValue(portal_type="Person")
 if (state != 'suspended') or \
    (person is None):
   return mail_message, invoice_list
-else:
-  portal = context.getPortalObject()
 
-  open_order = portal.portal_catalog.getResultValue(
+portal = context.getPortalObject()
+
+open_order = portal.portal_catalog.getResultValue(
+  portal_type="Open Sale Order",
+  validation_state="validated",
+  default_destination_decision_uid=person.getUid())
+
+if (open_order is not None) and (
+     (open_order.getValidationState() != "validated") or \
+     (len(open_order.contentValues(portal_type="Open Sale Order Line")) != 0)):
+  return mail_message, invoice_list
+
+if open_order is None:
+  # No open order was found, check if the latest archived order
+  # exists and contains no line.
+  open_order_list = portal.portal_catalog(
     portal_type="Open Sale Order",
-    validation_state="validated",
-    default_destination_decision_uid=person.getUid())
+    validation_state="archived",
+    sort_on=(('creation_date', 'DESC'),),
+    default_destination_decision_uid=person.getUid(),
+    limit=10)
 
-  if (open_order is None) or \
-   (open_order.getValidationState() != "validated") or \
-   (len(open_order.contentValues(portal_type="Open Sale Order Line")) != 0):
-    return mail_message, invoice_list
+  if len(open_order_list):
+    # Ensure the list is indeed sorted to maximum know presicision 
+    open_order = sorted(open_order_list, key=lambda x: x.getCreationDate(), reverse=True)[0]
+    if len(open_order.contentValues(portal_type="Open Sale Order Line")) != 0:
+      raise ValueError("Something is wrong, this Open Sale Order should had no Line")
   else:
-    assert open_order.getDestinationDecisionUid() == person.getUid()
-    ticket = context
-
-    for payment in portal.portal_catalog(
-          portal_type="Payment Transaction", 
-          payment_mode_uid=portal.portal_categories.payment_mode.payzen.getUid(),
-          default_destination_section_uid=person.getUid(),
-          simulation_state=["started"],
-          ):
-      
-      if payment.PaymentTransaction_getPayzenId()[1] is None:
-        invoice = payment.getCausalityValue(portal_type="Sale Invoice Transaction")
-        assert payment.getDestinationSectionUid() == person.getUid()
-        invoice.SaleInvoiceTransaction_createReversalPayzenTransaction()
-        invoice_list.append(invoice.getRelativeUrl())
-
-    # XXX Hardcoded
-    cancel_service = portal.service_module.slapos_crm_invoice_cancellation
-    mail_message = ticket.RegularisationRequest_checkToSendUniqEvent(
+    return mail_message, invoice_list
+
+assert open_order.getDestinationDecisionUid() == person.getUid()
+ticket = context
+
+for payment in portal.portal_catalog(
+    portal_type="Payment Transaction", 
+    payment_mode_uid=[
+      portal.portal_categories.payment_mode.wechat.getUid(), 
+      portal.portal_categories.payment_mode.payzen.getUid()],
+    default_destination_section_uid=person.getUid(),
+    simulation_state=["started"],
+  ):
+  
+  if payment.getPaymentMode() == "payzen" and payment.PaymentTransaction_getPayzenId()[1] is None:
+    invoice = payment.getCausalityValue(portal_type="Sale Invoice Transaction")
+    assert payment.getDestinationSectionUid() == person.getUid()
+    invoice.SaleInvoiceTransaction_createReversalPayzenTransaction()
+    invoice_list.append(invoice.getRelativeUrl())
+
+  # Missing wechat cancellation
+
+
+if len(invoice_list) > 0:
+  cancel_service = portal.service_module.slapos_crm_invoice_cancellation
+  mail_message = ticket.RegularisationRequest_checkToSendUniqEvent(
       cancel_service.getRelativeUrl(),
       'Cancellation of your bill',
       """Hello,