slapos_erp5: Make pylint happier

master/bt5/slapos_erp5/SkinTemplateItem/portal_skins/slapos_administration/ERP5Site_assertDumpedConfiguration.py

@@ -78,7 +78,7 @@ if show_all or configuration == "skins":
 if show_all or configuration == "web_content":
   expected_file = portal.expected_web_page_module_configuration
   found = portal.ERP5Site_dumpWebPageModuleContent(
-    ignore_string_on_reference=["rapid_"])
+    ignore_string_on_reference_list=["rapid_"])
   print resolveDiff("Web Content Configuration Diff", expected_file, found)
 
 if show_all or configuration == "actions":

master/bt5/slapos_erp5/SkinTemplateItem/portal_skins/slapos_administration/ERP5Site_dumpWebPageModuleContent.py

 import hashlib
 portal = context.getPortalObject()
 
+if not ignore_string_on_reference_list:
+  ignore_string_on_reference_list = []
 
 def getWebContentHash(document):
   content = document.getTextContent("ignore")
@@ -20,7 +22,7 @@ for document in portal.web_page_module.searchFolder(
 
   print_web_content = 1
   document_reference = str(document.getReference(""))
-  for ignore_string in ignore_string_on_reference:
+  for ignore_string in ignore_string_on_reference_list:
     if ignore_string in document_reference:
       print_web_content = 0
       break

master/bt5/slapos_erp5/SkinTemplateItem/portal_skins/slapos_administration/ERP5Site_dumpWebPageModuleContent.xml

@@ -50,7 +50,7 @@
         </item>
         <item>
             <key> <string>_params</string> </key>
-            <value> <string>ignore_string_on_reference=["rapid"]</string> </value>
+            <value> <string>ignore_string_on_reference_list=None</string> </value>
         </item>
         <item>
             <key> <string>id</string> </key>

master/bt5/slapos_erp5/SkinTemplateItem/portal_skins/slapos_administration/ERP5Site_getSecurityUidStat.py

@@ -2,14 +2,12 @@ portal = context.getPortalObject()
 
 uid_groups_columns_dict = portal.portal_catalog.getSQLCatalog().getSQLCatalogSecurityUidGroupsColumnsDict()
 uid_groups_columns_items = sorted(uid_groups_columns_dict.items())
-security_column_list = sorted(uid_groups_columns_dict.values())
+#security_column_list = sorted(uid_groups_columns_dict.values())
 
-user_id_list = ['claudie', 'rafael', 'vifib-admin', 'nexedi_development_service']
-#for user in portal.person_module.searchFolder(
-#          reference='%',
-#          validation_state='validated',
-#          default_role_uid=portal.portal_categories.role.internal.getUid()):
-#  user_id_list.append(user.getReference())
+user_id_list = [ user.getReference() for user in portal.person_module.searchFolder(
+          reference='%',
+          validation_state='validated',
+          default_role_uid=portal.portal_categories.role.internal.getUid())]
 
 info_list = []
 for user_id in sorted(user_id_list):
@@ -19,7 +17,7 @@ for user_id in sorted(user_id_list):
   groups = user.getGroups()
   uid_dict_and_roles_column_dict = portal.Base_getSecurityUidDictAndRoleColumnDictForUser(user_id)
   info = [user_id, len(groups)]
-  for local_roles_group_id, security_column in uid_groups_columns_items:
+  for local_roles_group_id, security_column in uid_groups_columns_items: #pylint: disable=unused-variable
     info.append(len(uid_dict_and_roles_column_dict[0].get(local_roles_group_id,[])))
 
   info_list.append(info)

master/bt5/slapos_erp5/SkinTemplateItem/portal_skins/slapos_administration/ERP5Site_testPythonScriptTestCoverage.py

-import hashlib
 portal = context.getPortalObject()
 
 content_dict = {}

master/bt5/slapos_erp5/SkinTemplateItem/portal_skins/slapos_core/ERP5Type_acquireSecurityFromOwner.py

@@ -7,8 +7,7 @@ base_category_list - list of category values we need to retrieve
 object             - object which we want to assign roles to.
 """
 
-result_list = []
-user_name = object.Base_getOwnerId()
+user_name = object.Base_getOwnerId() #pylint: disable=redefined-builtin
 
 # XXX Hardcoded role
 return {