authentication: drop dead code

Login_isPasswordValid is no longer used.

bt5/erp5_authentication_policy/SkinTemplateItem/portal_skins/erp5_authentication_policy/Login_isPasswordValid.py

-"""
-  Form validator which will check if password is valid for the user.
-"""
-from Products.ERP5Type.Document import newTempBase
-from Products.Formulator.Errors import ValidationError
-
-portal = context.getPortalObject()
-
-def doValidation(login, password):
-  # raise so Formulator shows proper message
-  result_message_list = login.analyzePassword(password)
-  if result_message_list:
-    message = u' '.join([str(x) for x in result_message_list])
-    raise ValidationError('external_validator_failed', context, error_text=message)
-  return 1
-
-return doValidation(context, password)

bt5/erp5_authentication_policy/SkinTemplateItem/portal_skins/erp5_authentication_policy/Login_isPasswordValid.xml

-<?xml version="1.0"?>
-<ZopeData>
-  <record id="1" aka="AAAAAAAAAAE=">
-    <pickle>
-      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
-    </pickle>
-    <pickle>
-      <dictionary>
-        <item>
-            <key> <string>Script_magic</string> </key>
-            <value> <int>3</int> </value>
-        </item>
-        <item>
-            <key> <string>_bind_names</string> </key>
-            <value>
-              <object>
-                <klass>
-                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
-                </klass>
-                <tuple/>
-                <state>
-                  <dictionary>
-                    <item>
-                        <key> <string>_asgns</string> </key>
-                        <value>
-                          <dictionary>
-                            <item>
-                                <key> <string>name_container</string> </key>
-                                <value> <string>container</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_context</string> </key>
-                                <value> <string>context</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_m_self</string> </key>
-                                <value> <string>script</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_subpath</string> </key>
-                                <value> <string>traverse_subpath</string> </value>
-                            </item>
-                          </dictionary>
-                        </value>
-                    </item>
-                  </dictionary>
-                </state>
-              </object>
-            </value>
-        </item>
-        <item>
-            <key> <string>_params</string> </key>
-            <value> <string>password, request</string> </value>
-        </item>
-        <item>
-            <key> <string>_proxy_roles</string> </key>
-            <value>
-              <tuple>
-                <string>Manager</string>
-              </tuple>
-            </value>
-        </item>
-        <item>
-            <key> <string>id</string> </key>
-            <value> <string>Login_isPasswordValid</string> </value>
-        </item>
-      </dictionary>
-    </pickle>
-  </record>
-</ZopeData>

product/ERP5/tests/testAuthenticationPolicy.py

@@ -531,17 +531,6 @@ class TestAuthenticationPolicy(ERP5TypeTestCase):
     self._clearCache()
     self.tic()
 
-    # emulate Anonymous User
-    self.logout()
-    request.set('field_user_login', login.getReference())
-    self.assertRaises(ValidationError,  login.Login_isPasswordValid, 'abAB#12_%s' %person.getFirstName(), request) # contains name
-    self.assertRaises(ValidationError,  login.Login_isPasswordValid, 'abAB#12_%s' %person.getLastName(), request) # contains name
-    self.assertRaises(ValidationError,  login.Login_isPasswordValid, 'abAB#1', request) # too short
-    self.assertRaises(ValidationError,  login.Login_isPasswordValid, 'abABCDEFG', request) # too few groups
-    self.assertRaises(ValidationError,  login.Login_isPasswordValid, 'used_ALREADY_1234', request) # already used
-    self.assertEqual(1, login.Login_isPasswordValid('abAB#12_', request))
-    self.assertEqual(1, login.Login_isPasswordValid('not_used_ALREADY_1234', request))
-
   def test_PasswordExpire(self):
     """
       Test password expire.