slapos_accounting: do not crash if open order line is not linked to an instance

master/bt5/slapos_accounting/SkinTemplateItem/portal_skins/slapos_accounting/OpenSaleOrder_updatePeriod.py

@@ -58,31 +58,33 @@ if open_sale_order.getValidationState() == 'validated':
 
       hosting_subscription = open_order_line.getAggregateValue(portal_type='Hosting Subscription')
       instance_tree = open_order_line.getAggregateValue(portal_type='Instance Tree')
+
       assert current_start_date == hosting_subscription.HostingSubscription_calculateSubscriptionStartDate()
 
-      subscription_request = instance_tree.getAggregateRelatedValue(portal_type="Subscription Request")
-      # Define the start date of the period, this can variates with the time.
-      next_stop_date_delta = 0
-      if subscription_request is not None:
-        next_stop_date_delta = 46
-
-      # First check if the instance tree has been correctly simulated (this script may run only once per year...)
-      stop_date = calculateOpenOrderLineStopDate(open_order_line, hosting_subscription, instance_tree,
-                                                 start_date_delta=0, next_stop_date_delta=next_stop_date_delta)
-      if current_stop_date < stop_date:
-        # Bingo, new subscription to generate
-        open_order_line.edit(
-          stop_date=stop_date,
-          activate_kw=activate_kw)
-        storeWorkflowComment(open_order_line,
-                             'Stop date updated to %s' % stop_date)
-
-      if instance_tree.getSlapState() == 'destroy_requested':
-        # Line should be deleted
-        assert instance_tree.getCausalityState() == 'diverged'
-        instance_tree.converge(comment="Last open order: %s" % open_order_line.getRelativeUrl())
-
-        open_sale_order.archive()
-        storeWorkflowComment(open_sale_order, "Instance Tree destroyed: %s" % instance_tree.getRelativeUrl())
-      elif (instance_tree.getCausalityState() == 'diverged'):
-        instance_tree.converge(comment="Nothing to do on open order.")
+      if instance_tree is not None:
+        subscription_request = instance_tree.getAggregateRelatedValue(portal_type="Subscription Request")
+        # Define the start date of the period, this can variates with the time.
+        next_stop_date_delta = 0
+        if subscription_request is not None:
+          next_stop_date_delta = 46
+
+        # First check if the instance tree has been correctly simulated (this script may run only once per year...)
+        stop_date = calculateOpenOrderLineStopDate(open_order_line, hosting_subscription, instance_tree,
+                                                   start_date_delta=0, next_stop_date_delta=next_stop_date_delta)
+        if current_stop_date < stop_date:
+          # Bingo, new subscription to generate
+          open_order_line.edit(
+            stop_date=stop_date,
+            activate_kw=activate_kw)
+          storeWorkflowComment(open_order_line,
+                               'Stop date updated to %s' % stop_date)
+
+        if instance_tree.getSlapState() == 'destroy_requested':
+          # Line should be deleted
+          assert instance_tree.getCausalityState() == 'diverged'
+          instance_tree.converge(comment="Last open order: %s" % open_order_line.getRelativeUrl())
+
+          open_sale_order.archive()
+          storeWorkflowComment(open_sale_order, "Instance Tree destroyed: %s" % instance_tree.getRelativeUrl())
+        elif (instance_tree.getCausalityState() == 'diverged'):
+          instance_tree.converge(comment="Nothing to do on open order.")