Add the corresponding test.

  * fix JSLint
  * prevent the script from crashing when there is no data (no
partitions or no computer)

Now creation date is fast, there is no need for this custom code anymore.

This is only applied to the portal types that were in the "non index" list. Now that getCreationDate is fast, we reverted the custom change and index the change.

Contributed by Luke

/reviewed-on nexedi/slapos.core!130

Set proper limit.

This is follow-up of nexedi/slapos.core!127

/reviewed-on nexedi/slapos.core!128

This script is tested separatetly

Define smaler Unit Tests files is preferrable to make distribution easier for the test nodes.

This prevents re-declaration to set a diferent default.definition

Introduce this code in order to simplify the code and introduce some kind of reusable API.

Check if the software installation is really well installed before continue

The upgrade_scope is disabled, not never, so added disabled and kept never
for backward compatibility.

Software Installations should be accessible for the users who can also accesss the aggreagted computer

Filter by slap_state makes the alarm don't wait for computer contact (which is unnecessary).