- 22 Jan, 2018 3 commits
-
-
Yusei Tahara authored
Local variable `template` is used for different things, it is bad. Use different variable name for different thing.
-
Yusei Tahara authored
-
Yusei Tahara authored
compile function takes a lot of time, thus this change saves time when the same source is used many times in apache frontend SR.
-
- 11 Dec, 2017 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
- 18 Oct, 2017 1 commit
-
-
Julien Muchembled authored
-
- 16 Oct, 2017 1 commit
-
-
Cédric Le Ninivin authored
-
- 13 Oct, 2017 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
- 03 Jul, 2017 1 commit
-
-
Julien Muchembled authored
-
- 21 Jun, 2017 1 commit
-
-
Julien Muchembled authored
__init__ should only check options. By doing the actual work in install/update, it is now possible to use a template that is produced by another part. 'mode' was implemented like 'umask' but it has never been used this way, and the 'umask' option is deprecated: - remove support for unused 'umask' option - change 'mode' to actually apply the wanted mode, regardless the current umask - the default mode changes: if 'mode' is not given, the resulting file is only executable (actually 0777 & ~umask) if the content starts with '#!', else its mode is: 0666 & ~umask
-
- 23 May, 2017 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
This is an incompatible change. For example, you would now write: import easy_install zc.buildout.easy_install instead of: import zc zc.buildout.easy_install
-
- 14 Mar, 2017 2 commits
-
-
Rafael Monnerat authored
-
Rafael Monnerat authored
-
- 18 Jan, 2017 2 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
To be used for zope's inituser file, for example.
-
- 15 Feb, 2016 1 commit
-
-
Rafael Monnerat authored
-
- 18 Nov, 2015 3 commits
-
-
Julien Muchembled authored
-
Kirill Smelkov authored
UTF-8 encoding for template imports was hardcoded from the beginning - from 320f29b2 (Add jinja2 "import" directive support.) Since in the previous patch we added option for input/output encoding, it makes sense to also use it, instead of hardcoding utf-8. /reviewed-by @vpelletier (on !1)
-
Kirill Smelkov authored
Currently slapos.recipe.template:jinja2 fails if source contains non-ascii input: <BLANKLINE> An internal error occurred due to a bug in either zc.buildout or in a recipe being used: Traceback (most recent call last): File ".../site-packages/zc/buildout/buildout.py", line 1992, in main getattr(buildout, command)(args) File ".../site-packages/zc/buildout/buildout.py", line 550, in install [self[part]['recipe'] for part in install_parts] File ".../site-packages/zc/buildout/buildout.py", line 1135, in __getitem__ options._initialize() File ".../site-packages/zc/buildout/buildout.py", line 1239, in _initialize self.initialize() File ".../site-packages/zc/buildout/buildout.py", line 1248, in initialize self.recipe = recipe_class(buildout, name, self) File ".../slapos.recipe.template/slapos/recipe/template/jinja2_template.py", line 208, in __init__ env.compile(source, filename=template), File ".../site-packages/jinja2/environment.py", line 551, in compile source = self._parse(source, name, filename) File ".../site-packages/jinja2/environment.py", line 470, in _parse return Parser(self, source, name, encode_filename(filename)).parse() File ".../site-packages/jinja2/parser.py", line 31, in __init__ self.stream = environment._tokenize(source, name, filename, state) File ".../site-packages/jinja2/environment.py", line 501, in _tokenize source = self.preprocess(source, name, filename) File ".../site-packages/jinja2/environment.py", line 495, in preprocess self.iter_extensions(), text_type(source)) UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 219: ordinal not in range(128) it also fails writing-out non-ascii input (which could originate even programmatically even if source was purely ascii): <BLANKLINE> An internal error occurred due to a bug in either zc.buildout or in a recipe being used: Traceback (most recent call last): File ".../site-packages/zc/buildout/buildout.py", line 1992, in main getattr(buildout, command)(args) File ".../site-packages/zc/buildout/buildout.py", line 666, in install installed_files = self[part]._call(recipe.install) File ".../site-packages/zc/buildout/buildout.py", line 1407, in _call return f() File ".../slapos/slapos.recipe.template/slapos/recipe/template/jinja2_template.py", line 227, in install out.write(self.template.render(**self.context)) UnicodeEncodeError: 'ascii' codec can't encode characters in position 206-211: ordinal not in range(128) Fix it. @vpelletier suggested to add `encoding` option so it is flexible and 'utf-8' is not hardcoded. /reviewed-by @vpelletier (on !1)
-
- 25 Jun, 2015 1 commit
-
-
Julien Muchembled authored
-
- 18 May, 2015 1 commit
-
-
Saurabh authored
-
- 08 Dec, 2014 1 commit
-
-
Julien Muchembled authored
-
- 30 Oct, 2014 1 commit
-
-
Cédric de Saint Martin authored
-
- 07 Aug, 2013 1 commit
-
-
Julien Muchembled authored
-
- 02 Aug, 2013 2 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
Although very unlikely here, it's good pratice to write code without possible race conditions. The only remaining one here is when anouther process create a file (with the same output path) between its deletion and its creation.
-
- 20 Sep, 2012 1 commit
-
-
Cédric de Saint Martin authored
-
- 21 Aug, 2012 6 commits
-
-
Łukasz Nowak authored
-
Łukasz Nowak authored
-
Vincent Pelletier authored
They should not be needed when buildout handles its own serialisation.
-
Vincent Pelletier authored
Based largely on work by Timothée Lacroix <timothee.lacroix@tiolive.com>, plus: - reworked loader classes - reduced unnecessary diffs - added rawfile and rawfolder types - documented & tested
-
Vincent Pelletier authored
umask cannot set a regular file as executable, nor allows setting suid/sgid/sticky bits. Using chmod properly, there is no security problem.
-
Vincent Pelletier authored
Useful when extending another section from same file.
-
- 17 Aug, 2012 2 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
This test case was accidentally reusing a previous template.
-
- 16 Aug, 2012 1 commit
-
-
Vincent Pelletier authored
Noticed by Timothée Lacroix <timothee.lacroix@tiolive.com>
-
- 08 Aug, 2012 2 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Patch by Timothée Lacroix <timothee.lacroix@tiolive.com>
-