@rafael I think it would be useful if people can request an NBD server to hold custom image. What do you think ?

/reviewed-on !552

This reverts commit 6d2019b965f4a3521b651f2cb9ef241dce29af55, as new caddy
has issues with tls certificate configuration:
https://github.com/mholt/caddy/issues/2588

About nxd-v0.11.5-4-g9d3151db:

 * not released yet functionality for regular expression cookie rewriting
   is available: https://github.com/mholt/caddy/pull/2144

 * not released yet functionality for ca_certifices in proxy:
   https://github.com/mholt/caddy/pull/2380

 * support for builtin log rotation disabling

Since caddy 1.0.0 it is less fragile for PEMs with some garbage, and can
serve sites in such cases.

It revealed, that test was wrongly written, as now the certificate can be a
bit messy, and will be lodaded, but then won't be used, as it does not
match the site.

It's released, let's use the newest version.

This reverts commit 467269a1.

This is just a temporary revert until there is no failures
to build. Right now it fails with :
OSError: [Errno 2] No such file or directory

Building perl on chrome OS crashes because of probing,
during which LD_LIBRARY_PATH is overwritten.
Instead of fixing this bug we can just use this patch created for
another reason but that removes probing:
https://sources.debian.org/src/perl/5.28.1-6/debian/patches/fixes/storable-probing/

There is a test result for this, even if it fails for erp5 and seleniumserver, it feels like it's unrelated to this change: 
https://nexedijs.erp5.net/#/test_result_module/20190423-28D5C67E?uid=2020442141

/cc @tomo @kazuhiko @jm

/reviewed-on nexedi/slapos!551

Fixes FTBFS on recent gcc:
logrotate.c: In function 'prerotateSingleLog':
logrotate.c:1328:6: error: 'strncat' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
      strncat(tempstr, rotNames->baseName, baseLen - extLen);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
logrotate.c:1320:19: note: length computed here
  size_t baseLen = strlen(rotNames->baseName);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
logrotate.c:1347:2: error: 'strncat' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  strncat(tempstr, rotNames->baseName,
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   strlen(rotNames->baseName) - strlen(log->extension));
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
logrotate.c:1348:3: note: length computed here
   strlen(rotNames->baseName) - strlen(log->extension));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

To get new gnulib, fixing build on modern glibc.

4.6.0, the current latest release, is already years old and fails to build
on recent glibc (bundled gnulib is too old).

In order to fix (at least) gcc 5.5 build on gcc 8.3.0 .

Nothing uses it in this software release.

Nothing uses it in this software release.

By default whole slave makes websocket connection to the backend.
With websocket-path, only the path has websocket style connections,
the rest is standard HTTP.

There is no need anymore to have two processes for normal and nginx slaves,
as nginx ones are served by caddy anyway.

Also inform the requester that type:eventsource is not implemented.

Differences between tls and non-tls are minimal, so simplify the generation
as much as possible with simple tls switch.

It seems more readable than creating Jinja2 macros, which would be used only
twice.

notebook is implemented.

caddyserver/builds repository is obsoleted and this commit avoids fetching
it.

BTrees 4.4.1 is from early 2017. BTrees 4.5.0 contains fix for crash
when deallocating items:

https://github.com/zopefoundation/BTrees/issues/75  
https://github.com/zopefoundation/BTrees/commit/16e70dd337

It is similar crash and fix to this one in wendelin.core:

nexedi/wendelin.core@d97641d2

and in Python 2.7.15:

nexedi/slapos@8e098385 (comment 72575)

BTrees 4.5.1 is a small maintenance release over 4.5.0 and is currently
latest BTree release.

/cc @jm, @vpelletier, @kazuhiko, @jerome
/reviewed-on nexedi/slapos!550

A regression from nexedi/slapos!374 is that we made apache listening on one port for each zope backend instance.

/reviewed-on nexedi/slapos!548

For the test suite, all plugins are still loaded if no engine is specified.

Loading TokuDB whereas RocksDB is used is quite annoying because:
- TokuDB creates many threads
- RocksDB opens many files
We had systems where lsof takes a few minutes to output 10 million lines.

This will also make the datadir a bit cleaner.

QUIC implementation module is fixed.

Since Caddy v0.11.4 it is possible to disable log rotation, thus disable it
and rely purely on SlapOS defined log rotation.

See https://github.com/mholt/caddy/releases/tag/v0.11.4

A regression in the apache entries for testrunner used one apache port
for each zope - not one for each family as what was intended.
There was also a problem that these apache ports were used even when no
testrunner.

- Exercise how multiple families are supported
- Check the number of zope in each family respects `instance-count`
argument
- Check the number of listening sockets is what we expect for server
processes
- Check that when we don't request test runner, apache does not listen
for test runner proxy

About Zstd, commit a0d582ab was wrong.
WITH_<engine>_<comp>=ON compilation options are added to force a build
failure if dependencies are broken.