With a fix for the URLs query string being escaped twice.

Also fixes icons not cached in sercice worker for OfficeJS.


See merge request nexedi/erp5!1661

this change was made with:

    find product/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_ckeditor/ckeditor/ -type f  | xargs sed -i 's/\\?t=445cf24ebd//g'

This timestamp break officejs offline capabilities.

This reaplies 40f6c8fe ([erp5_xhtml_style] ckeditor: drop hardcoded
timestamp parameter in URL, 2017-10-16) on the updated CKEditor

This was done with:

    find product/ERP5/bootstrap/erp5_xhtml_style/SkinTemplateItem/portal_skins/erp5_ckeditor/ckeditor/ -type f  | xargs sed -i 's/"M6K9"/""/g'

M6K9 was the timestamp for this build, that we can see at the top of
ckeditor.js

done with an external method to upload the content of zip file in
skin folder.

    import zipfile
    from io import BytesIO

    def uploadZip(self):
      dest = self.getPortalObject().portal_skins.custom
      with zipfile.ZipFile(
          '/srv/slapgrid/slappart3/srv/project/erp5/ckeditor_4.19.1_4b98d281bc34.zip'
      ) as f:
        for m in f.namelist():
          current_dest = dest
          print(m)
          for part in m.split('/')[:-1]:
            if part not in current_dest.objectIds():
              current_dest.manage_addProduct['OFSP'].manage_addFolder(id=part)
            current_dest = current_dest[part]
          fname = m.split('/')[-1]
          if fname == '_translationstatus.txt':
            fname = 'translationstatus.txt'
          current_dest.manage_addProduct['OFSP'].manage_addFile(
            id=fname, file=BytesIO(f.read(m)))
      return repr(dest)

Using make_query makes sure that the query parameters are properly
encoded and also change selection_index to become an int, because
it keeps the type of parameters.

As a consequence, we had to adjust a few place in the code where
selection_index was tested for truthiness: because "0" as a string is
true, but 0 as an int is not. For that, we changed to test the presence
of selection_name instead of testing selection_index, as they are always
used together.

This fixes a problem that & in URL was encoded twice for listbox
anchor links ( bug_module/1137 )

02011d8e (immediateReindexObject: use super user to reindex script,
2015-12-14) did not apply for inventory, because they were overloading
immediateReindexObject.
Introduce a new level, _immediateReindexObject that will hold the actual
reindexing logic.

Previously this method was using PortalContent.reindexObject which was
monkey patched, to make things less complex and more future proof, move
the monkey patch to a method on base class.

This also drops alternateReindexObject on BalanceTransaction, because it
is already defined in Inventory

This is supposed to fix "Should not load state for ${oid of a skin} when
the connection is closed" sometimes happening with live tests (especially
when the test self.publish and the developer access the site while the
test is suspended on a debugger breakpoint).

The object accessed after the connection is closed was a skin (python
script, sometimes page template or form) that was cached in SKINDATA.
The mechanism to prune entries from the cache uses REQUEST.hold API
which expects that REQUEST.close is called on request, but because
requests were not closed at the end of the request, it happened that
the cache was reused from another connection.

This change to close the requests, like ERP5TypeTestCase is doing in
tearDown (the actual close is done by Testing.ZopeTestCase.connections).

By closing requests at the end of tests, we also have to change so that
at the beginning of the test we initialize the request, by using the same
setSite and setupCurrentSkin that are done in ERP5TypeTestCase.

SKINDATA is an implementation detail that should not be accessed from
this level.

In SkinTemplateItem.install, self._objects contains entries for skin
folders and for all skins. objectValues method calls was called for skin
folders (as expected) and also for all skins, which acquire objectValues
from skin folder and do the work again.

This simplifies this by only running this for skin folders.

"default" URL is the URL when listbox column does not use URL column
and when the brains do not have a getListItemUrl method.

Move the computation in a lazyMethod, so that it is computed only once
per line instead of once per cell.

Also remove a try/except, I don't think this code is supposed to get an
AttributeError

Do not call container.reindexObject every time, otherwise the number
of activities explode because of recurseCallMethod.

See merge request nexedi/erp5!1643

of Organisation_viewFinancialInformationList

In xhtml_style, just after clicking next or previous page in the listbox
buttons, the values selected in 'Section Category' and 'Section Category
Strict' were not used, because they were used from request and not from
as normal script parameters.

This fixes only the xhtml_style version, ERP5JS has another problem that
dialog fields values are reset when going to next page, so it would also
need this problem to be fixed.

Use correct portal type.

- Display the editor in ERP5 language, not browser language
 - Use PDF viewer for Drawing preview
 - Supports password protected PDFs
 - Others small changes

See merge request nexedi/erp5!1639