1. 28 Jun, 2019 1 commit
    • Jérome Perrin's avatar
      xhtml_style: drop useless CachingMethod · 7f920b14
      Jérome Perrin authored
      This function have evolved to something very trivial not accessing anything from database, so caching this no longer really makes sense, also the cache keys are really big.
      
      On a quick benchmark of calling ERP5Site_getTabList 10000 times:
      with cache: ERP5Site_getTabList took 12.961781
      without cache: ERP5Site_getTabList took 5.395873
      7f920b14
  2. 27 Jun, 2019 6 commits
  3. 26 Jun, 2019 1 commit
  4. 25 Jun, 2019 1 commit
  5. 24 Jun, 2019 10 commits
  6. 22 Jun, 2019 1 commit
    • Bryton Lacquement's avatar
      qa: always report unprocessed activities when functional tests fail · 8d6300da
      Bryton Lacquement authored
      Example for erp5_web_renderjs_ui_test:testFunctionalRJSRelationField, which
      was failing randomly (fixed in ca229c3e):
      
      ======================================================================
      FAIL: testFunctionalTestRunner (erp5.component.test.erp5_version.testFunctionalRJSRelationField.TestRenderJSUIRelationField)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File ".../product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py", line 372, in testFunctionalTestRunner
          self.fail('\n'.join(error))
      AssertionError: These messages are pending: [('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_catalog', 'unindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/3', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -2, 1)]
      Last error message:
      RuntimeError
      tic is looping forever.
      Traceback (innermost last):
        Module ZPublisher.Publish, line 138, in publish
          request, bind=1)
        Module ZPublisher.mapply, line 77, in mapply
          if debug is not None: return debug(object,args,context)
        Module ZPublisher.Publish, line 48, in call_object
          result=apply(object,args) # Type s<cr> to step into published object.
        Module Products.ERP5Type.patches.ExternalMethod, line 113, in __call__
          return _f[0](self.aq_parent, *args, **kw)
        Module erp5.component.extension.erp5_version.ERP5Zuite, line 21, in waitForActivities
          raise RuntimeError('tic is looping forever.')
      RuntimeError: tic is looping forever.
      
      testAccessUnauthorizedRelationValue
      testBreadcrumbCanNotAccessRelationSearchPage
      testMultiRelationDefaultSortAndParameterList
      testMultiRelationFieldEmptySearchWithListbox
      testMultiRelationFieldHomonyms
      testMultiRelationFieldSearchWithListbox
      testMultiRelationFieldSearchWithProxyListbox
      testMultiRelationFieldUnknownIcon
      testMultiRelationFieldWithNonSavedPageContent
      testProxyListBox
      testRelationDefaultSortAndParameterList
      testRelationFieldEmptySearchWithListbox
      testRelationFieldRefresh
      testRelationFieldSearchWithListbox
      testRelationFieldWithNonSavedPageContent
      testSimpleMultiRelationField
      
      ----------------------------------------------------------------------
      Ran 1 test in 199.267s
      8d6300da
  7. 21 Jun, 2019 11 commits
  8. 20 Jun, 2019 1 commit
  9. 18 Jun, 2019 1 commit
  10. 17 Jun, 2019 3 commits
  11. 13 Jun, 2019 1 commit
  12. 12 Jun, 2019 2 commits
    • Vincent Pelletier's avatar
      CMFActivity: Ignore None dependencies. · e598da95
      Vincent Pelletier authored
      Simplifies activity spawning when dependencies are conditionally set:
        activate(
          after_tag=some_value if some_condition else None,
        )
      instead of having to do a ** dance.
      All columns involved in dependency checking are declared NOT NULL, so providing
      "None" and expecting a dependency to happen was already not working.
      This change pushes this one step further by allowing activity
      auto-validation also happen on these activities.
      Also, simplify getOrderValidationText: avoid iterating on keys and then
      retrieving values, use a list-comprehension, simplify condition.
      Add a test for after_tag, also covering activity auto-validation.
      e598da95
    • Arnaud Fontaine's avatar
      Unit Tests: login*() with a non-ERP5TypeTestCase user was adding... · 66845855
      Arnaud Fontaine authored
      Unit Tests: login*() with a non-ERP5TypeTestCase user was adding ERP5TypeTestCase user anyway and failure was silently ignored.
      66845855
  13. 11 Jun, 2019 1 commit