- 29 Jan, 2021 3 commits
-
-
Jérome Perrin authored
This was not much tested
-
Jérome Perrin authored
This shows the asset price from `stock.total_price` which can be just the movement prices or the evaluated prices if getDestinationAssetPrice and/or getSourceAssetPrice type based methods are defined.
-
Jérome Perrin authored
erp5_trade contains Base_viewTradeFieldLibrary which contain my_dialog_mode_portal_type, which is a multi list field where user can select multiple lines portal types. It is used in DeliveryModule_viewDeliveryLineReportDialog/your_portal_type erp5_item also contains Base_viewTradeFieldLibrary , for cases where erp5_item extend trade module to select items. It also contains a my_dialog_mode_portal_type field, where user can select item portal type. That field is not a multi-list field, but a list-field. It is used in DeliveryLine_viewSelectItemListDialog So when erp5_item is installed, it overrides Base_viewTradeFieldLibrary/my_dialog_mode_portal_type with a list field instead of a multi-list field and breaks DeliveryModule_viewDeliveryLineReportDialog, because user can no longer select more than one portal type. This renames the field in erp5_item, now we have: * Base_viewTradeFieldLibrary/my_dialog_mode_portal_type for movement portal types * Base_viewTradeFieldLibrary/my_dialog_mode_item_portal_type for item portal type
-
- 28 Jan, 2021 4 commits
-
-
Romain Courteaud authored
-
Arnaud Fontaine authored
Until now it was only used in ERP5Catalog where the expression property is `expression` for both Python Script and SQL Method but this is a common pattern and will also needed for ERP5Workflow.
-
Jérome Perrin authored
Instead of generating the report in one big activity, split the calculation in several batches, so that the processing can be distributed on zope nodes. The limit for the number of lines was also increased from 10000 to 100000
-
Jérome Perrin authored
Using an absolute URL for gadgets cause the gadget to have a different URL per language when the web site uses "Language in URL" feature. Using absolute URL is not good for cache and also it seems to cause incompatibilities with recent versions of ERP5JS. Using relative URL is what we usually do, it does not have cache problem and works fine.
-
- 27 Jan, 2021 3 commits
-
-
Romain Courteaud authored
-
Kazuhiko Shiozaki authored
-
Jérome Perrin authored
See merge request !1345
-
- 26 Jan, 2021 7 commits
-
-
Jérome Perrin authored
for consistency
-
Jérome Perrin authored
for consistency
-
Jérome Perrin authored
-
Jérome Perrin authored
Even though it was enabled on packing list, this report was showing orders.
-
Jérome Perrin authored
This report can be used for purchase, then it shows supplier. In the report dialog, we have "By Third Party" report mode, so use consistent term.
-
Jérome Perrin authored
This report shows packing lists, but in the dialog we could only select the states of orders.
-
Jérome Perrin authored
a928abd2 (web_renderjs_ui: use lxml to extract data-i18n messages, 2020-12-14) was an old version of the patch that was pushed accidentally. This applies the missing bits.
-
- 25 Jan, 2021 9 commits
-
-
Vincent Pelletier authored
This is already working for multi-column conditions (among other malformed values), but in the monocolumn case the type-check treats None in the same branch as sequences, which cause the error: TypeError: 'NoneType' object is not iterable As the condition is already covered for multi-column case, put this test in the monocolumn codepath.
-
Jérome Perrin authored
form_discussion_view embeds an editor, but it did not expose notifySubmit method to child gadgets. Because using Ctrl+S in the editor calls notifySubmit on parent gadget, Ctrl+S was causing a page crash. Expose such a method that would submit a comment when called.
-
Jérome Perrin authored
The previous regular expression based approach sometimes could not extract message properly. Using xml parser simplify code and fix several messages that were not extracted properly, like messages containing ", [] or {} This also fix some problems when looking for messages sources: - archived web pages were sometimes used instead of published ones - messages from gadgets implemented as page templates/OFS files were not extracted. A few more unit tests for the scripts involved in this process are added.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Fixes the handling of: - non-sequence dependency_value - incorrect dependency_value length - None in dependency_value - None in dependency_value items
-
Vincent Pelletier authored
-
Vincent Pelletier authored
So more sequence types are accepted by _getExecutableMessageSet.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
- 22 Jan, 2021 1 commit
-
-
Kazuhiko Shiozaki authored
-
- 20 Jan, 2021 5 commits
-
-
Romain Courteaud authored
See 6c4f7600
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Allows to keep UI tests working independently of the login process implementation details.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
- 19 Jan, 2021 5 commits
-
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
This reverts commit e5c160bc.
-
Kazuhiko Shiozaki authored
-
Georgios Dagkakis authored
in API script AccountingTransaction_createReversalTransaction
-
Jérome Perrin authored
Opening an accounting period is refused if the start date of the period is more than one day after the stop date of the previous period, but this check did not take into account that "next day" might be more than 24 hours, like it's the case when daylight saving happen between these dates. Instead we check that the difference is less than 1.9 days. Reorganise tests to group accounting period related tests in a dedicated test class and add missing tests for period validation checks. Also fix a few race conditions with catalog indexing that are probably not a problem in real life but were revealed by the test.
-
- 18 Jan, 2021 2 commits
-
-
Vincent Pelletier authored
See SQLBase._getExecutableMessageSet for operation principle. Removes the notion of order_validation_text: activity validation is no longer evaluated per-activity , but per-dependency for multiple activities at a time. In this context, order_validation_text does not make sense as it flattens all dependency types for a given activity. Rework activity-dependency-to-SQL methods: use a dict rather dynamically-generated method names. Based on initial work by Julien Muchembled.
-
Vincent Pelletier authored
Seen happen on SQLDict with 94 indexation activities being stuck assigned to a processing node on which load failed because of an SQL deadlock.
-
- 14 Jan, 2021 1 commit
-
-
Jérome Perrin authored
The main reason for not using cache.addAll was to fill the cache as a low priority task, not to generate too much traffic, the safari compatibility was secondary. Now that safari seems to support cache.addAll, remove the comment about safari.
-