task_lists_spec.rb 10.3 KB
Newer Older
1 2
require 'spec_helper'

3
feature 'Task Lists', feature: true do
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
  include Warden::Test::Helpers

  let(:project) { create(:project) }
  let(:user)    { create(:user) }
  let(:user2)   { create(:user) }

  let(:markdown) do
    <<-MARKDOWN.strip_heredoc
    This is a task list:

    - [ ] Incomplete entry 1
    - [x] Complete entry 1
    - [ ] Incomplete entry 2
    - [x] Complete entry 2
    - [ ] Incomplete entry 3
    - [ ] Incomplete entry 4
    MARKDOWN
  end

Clement Ho's avatar
Clement Ho committed
23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38
  let(:singleIncompleteMarkdown) do
    <<-MARKDOWN.strip_heredoc
    This is a task list:

    - [ ] Incomplete entry 1
    MARKDOWN
  end

  let(:singleCompleteMarkdown) do
    <<-MARKDOWN.strip_heredoc
    This is a task list:

    - [x] Incomplete entry 1
    MARKDOWN
  end

39 40 41 42 43 44 45 46 47 48 49 50 51
  let(:nested_tasks_markdown) do
    <<-EOT.strip_heredoc
    - [ ] Task a
      - [x] Task a.1
      - [ ] Task a.2
    - [ ] Task b

    1. [ ] Task 1
      1. [ ] Task 1.1
      1. [x] Task 1.2
    EOT
  end

52 53 54 55 56 57 58 59 60 61 62 63 64 65
  before do
    Warden.test_mode!

    project.team << [user, :master]
    project.team << [user2, :guest]

    login_as(user)
  end

  def visit_issue(project, issue)
    visit namespace_project_issue_path(project.namespace, project, issue)
  end

  describe 'for Issues' do
Clement Ho's avatar
Clement Ho committed
66 67
    describe 'multiple tasks' do
      let!(:issue) { create(:issue, description: markdown, author: user, project: project) }
68

Clement Ho's avatar
Clement Ho committed
69 70
      it 'renders' do
        visit_issue(project, issue)
71

Clement Ho's avatar
Clement Ho committed
72 73 74 75 76 77 78 79 80
        expect(page).to have_selector('ul.task-list',      count: 1)
        expect(page).to have_selector('li.task-list-item', count: 6)
        expect(page).to have_selector('ul input[checked]', count: 2)
      end

      it 'contains the required selectors' do
        visit_issue(project, issue)

        container = '.detail-page-description .description.js-task-list-container'
81

Clement Ho's avatar
Clement Ho committed
82 83 84 85 86 87
        expect(page).to have_selector(container)
        expect(page).to have_selector("#{container} .wiki .task-list .task-list-item .task-list-item-checkbox")
        expect(page).to have_selector("#{container} .js-task-list-field")
        expect(page).to have_selector('form.js-issuable-update')
        expect(page).to have_selector('a.btn-close')
      end
88

Clement Ho's avatar
Clement Ho committed
89 90 91
      it 'is only editable by author' do
        visit_issue(project, issue)
        expect(page).to have_selector('.js-task-list-container')
92

Clement Ho's avatar
Clement Ho committed
93 94 95 96 97 98 99 100 101 102 103
        logout(:user)

        login_as(user2)
        visit current_path
        expect(page).not_to have_selector('.js-task-list-container')
      end

      it 'provides a summary on Issues#index' do
        visit namespace_project_issues_path(project.namespace, project)
        expect(page).to have_content("2 of 6 tasks completed")
      end
104 105
    end

Clement Ho's avatar
Clement Ho committed
106 107
    describe 'single incomplete task' do
      let!(:issue) { create(:issue, description: singleIncompleteMarkdown, author: user, project: project) }
108

Clement Ho's avatar
Clement Ho committed
109 110
      it 'renders' do
        visit_issue(project, issue)
111

Clement Ho's avatar
Clement Ho committed
112 113 114 115 116 117 118 119 120
        expect(page).to have_selector('ul.task-list',      count: 1)
        expect(page).to have_selector('li.task-list-item', count: 1)
        expect(page).to have_selector('ul input[checked]', count: 0)
      end

      it 'provides a summary on Issues#index' do
        visit namespace_project_issues_path(project.namespace, project)
        expect(page).to have_content("0 of 1 task completed")
      end
121 122
    end

Clement Ho's avatar
Clement Ho committed
123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
    describe 'single complete task' do
      let!(:issue) { create(:issue, description: singleCompleteMarkdown, author: user, project: project) }

      it 'renders' do
        visit_issue(project, issue)

        expect(page).to have_selector('ul.task-list',      count: 1)
        expect(page).to have_selector('li.task-list-item', count: 1)
        expect(page).to have_selector('ul input[checked]', count: 1)
      end

      it 'provides a summary on Issues#index' do
        visit namespace_project_issues_path(project.namespace, project)
        expect(page).to have_content("1 of 1 task completed")
      end
138
    end
139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167

    describe 'nested tasks', js: true do
      let(:issue) { create(:issue, description: nested_tasks_markdown, author: user, project: project) }

      before { visit_issue(project, issue) }

      it 'renders' do
        expect(page).to have_selector('ul.task-list',      count: 2)
        expect(page).to have_selector('li.task-list-item', count: 7)
        expect(page).to have_selector('ul input[checked]', count: 1)
        expect(page).to have_selector('ol input[checked]', count: 1)
      end

      it 'solves tasks' do
        expect(page).to have_content("2 of 7 tasks completed")

        page.find('li.task-list-item', text: 'Task b').find('input').click
        page.find('li.task-list-item ul li.task-list-item', text: 'Task a.2').find('input').click
        page.find('li.task-list-item ol li.task-list-item', text: 'Task 1.1').find('input').click

        expect(page).to have_content("5 of 7 tasks completed")

        visit_issue(project, issue) # reload to see new system notes

        expect(page).to have_content('marked the task Task b as complete')
        expect(page).to have_content('marked the task Task a.2 as complete')
        expect(page).to have_content('marked the task Task 1.1 as complete')
      end
    end
168 169 170 171
  end

  describe 'for Notes' do
    let!(:issue) { create(:issue, author: user, project: project) }
Clement Ho's avatar
Clement Ho committed
172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
    describe 'multiple tasks' do
      let!(:note) do
        create(:note, note: markdown, noteable: issue,
                      project: project, author: user)
      end

      it 'renders for note body' do
        visit_issue(project, issue)

        expect(page).to have_selector('.note ul.task-list',      count: 1)
        expect(page).to have_selector('.note li.task-list-item', count: 6)
        expect(page).to have_selector('.note ul input[checked]', count: 2)
      end

      it 'contains the required selectors' do
        visit_issue(project, issue)

        expect(page).to have_selector('.note .js-task-list-container')
        expect(page).to have_selector('.note .js-task-list-container .task-list .task-list-item .task-list-item-checkbox')
        expect(page).to have_selector('.note .js-task-list-container .js-task-list-field')
      end

      it 'is only editable by author' do
        visit_issue(project, issue)
        expect(page).to have_selector('.js-task-list-container')

        logout(:user)

        login_as(user2)
        visit current_path
        expect(page).not_to have_selector('.js-task-list-container')
      end
204
    end
205

Clement Ho's avatar
Clement Ho committed
206 207 208 209 210
    describe 'single incomplete task' do
      let!(:note) do
        create(:note, note: singleIncompleteMarkdown, noteable: issue,
                      project: project, author: user)
      end
211

Clement Ho's avatar
Clement Ho committed
212 213
      it 'renders for note body' do
        visit_issue(project, issue)
214

Clement Ho's avatar
Clement Ho committed
215 216 217 218
        expect(page).to have_selector('.note ul.task-list',      count: 1)
        expect(page).to have_selector('.note li.task-list-item', count: 1)
        expect(page).to have_selector('.note ul input[checked]', count: 0)
      end
219 220
    end

Clement Ho's avatar
Clement Ho committed
221 222 223 224 225
    describe 'single complete task' do
      let!(:note) do
        create(:note, note: singleCompleteMarkdown, noteable: issue,
                      project: project, author: user)
      end
226

Clement Ho's avatar
Clement Ho committed
227 228
      it 'renders for note body' do
        visit_issue(project, issue)
229

Clement Ho's avatar
Clement Ho committed
230 231 232 233
        expect(page).to have_selector('.note ul.task-list',      count: 1)
        expect(page).to have_selector('.note li.task-list-item', count: 1)
        expect(page).to have_selector('.note ul input[checked]', count: 1)
      end
234 235 236 237 238 239 240 241
    end
  end

  describe 'for Merge Requests' do
    def visit_merge_request(project, merge)
      visit namespace_project_merge_request_path(project.namespace, project, merge)
    end

Clement Ho's avatar
Clement Ho committed
242 243
    describe 'multiple tasks' do
      let!(:merge) { create(:merge_request, :simple, description: markdown, author: user, source_project: project) }
244

Clement Ho's avatar
Clement Ho committed
245 246
      it 'renders for description' do
        visit_merge_request(project, merge)
247

Clement Ho's avatar
Clement Ho committed
248 249 250 251
        expect(page).to have_selector('ul.task-list',      count: 1)
        expect(page).to have_selector('li.task-list-item', count: 6)
        expect(page).to have_selector('ul input[checked]', count: 2)
      end
252

Clement Ho's avatar
Clement Ho committed
253 254
      it 'contains the required selectors' do
        visit_merge_request(project, merge)
255

Clement Ho's avatar
Clement Ho committed
256
        container = '.detail-page-description .description.js-task-list-container'
257

Clement Ho's avatar
Clement Ho committed
258 259 260 261 262 263
        expect(page).to have_selector(container)
        expect(page).to have_selector("#{container} .wiki .task-list .task-list-item .task-list-item-checkbox")
        expect(page).to have_selector("#{container} .js-task-list-field")
        expect(page).to have_selector('form.js-issuable-update')
        expect(page).to have_selector('a.btn-close')
      end
264

Clement Ho's avatar
Clement Ho committed
265 266 267
      it 'is only editable by author' do
        visit_merge_request(project, merge)
        expect(page).to have_selector('.js-task-list-container')
268

Clement Ho's avatar
Clement Ho committed
269
        logout(:user)
270

Clement Ho's avatar
Clement Ho committed
271 272 273 274 275 276 277 278 279 280
        login_as(user2)
        visit current_path
        expect(page).not_to have_selector('.js-task-list-container')
      end

      it 'provides a summary on MergeRequests#index' do
        visit namespace_project_merge_requests_path(project.namespace, project)
        expect(page).to have_content("2 of 6 tasks completed")
      end
    end
281

Clement Ho's avatar
Clement Ho committed
282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
    describe 'single incomplete task' do
      let!(:merge) { create(:merge_request, :simple, description: singleIncompleteMarkdown, author: user, source_project: project) }

      it 'renders for description' do
        visit_merge_request(project, merge)

        expect(page).to have_selector('ul.task-list',      count: 1)
        expect(page).to have_selector('li.task-list-item', count: 1)
        expect(page).to have_selector('ul input[checked]', count: 0)
      end

      it 'provides a summary on MergeRequests#index' do
        visit namespace_project_merge_requests_path(project.namespace, project)
        expect(page).to have_content("0 of 1 task completed")
      end
297 298
    end

Clement Ho's avatar
Clement Ho committed
299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
    describe 'single complete task' do
      let!(:merge) { create(:merge_request, :simple, description: singleCompleteMarkdown, author: user, source_project: project) }

      it 'renders for description' do
        visit_merge_request(project, merge)

        expect(page).to have_selector('ul.task-list',      count: 1)
        expect(page).to have_selector('li.task-list-item', count: 1)
        expect(page).to have_selector('ul input[checked]', count: 1)
      end

      it 'provides a summary on MergeRequests#index' do
        visit namespace_project_merge_requests_path(project.namespace, project)
        expect(page).to have_content("1 of 1 task completed")
      end
314 315 316
    end
  end
end