Add escaping for milestone values

app/assets/javascripts/filtered_search/dropdown_label.js.es6

@@ -12,21 +12,8 @@
       const dataValueSet = this.setDataValueIfSelected(e.detail.selected);
 
       if (!dataValueSet) {
-        let labelTitle = e.detail.selected.querySelector('.label-title').innerText.trim();
-
-        // Encapsulate label with quotes if it has spaces
-        if (labelTitle.indexOf(' ') !== -1) {
-          if (labelTitle.indexOf('"') !== -1) {
-            // Use single quotes if label title contains double quotes
-            labelTitle = `'${labelTitle}'`;
-          } else {
-            // Known side effect: Label's with both single and double quotes
-            // won't escape properly
-            labelTitle = `"${labelTitle}"`;
-          }
-        }
-
-        const labelName = `~${labelTitle}`;
+        const labelTitle = e.detail.selected.querySelector('.label-title').innerText.trim();
+        const labelName = `~${this.getEscapedText(labelTitle)}`;
         gl.FilteredSearchManager.addWordToInput(labelName);
       }
 

app/assets/javascripts/filtered_search/dropdown_milestone.js.es6

@@ -12,7 +12,8 @@
       const dataValueSet = this.setDataValueIfSelected(e.detail.selected);
 
       if (!dataValueSet) {
-        const milestoneName = `%${e.detail.selected.querySelector('.btn-link').innerText.trim()}`;
+        const milestoneTitle = e.detail.selected.querySelector('.btn-link').innerText.trim();
+        const milestoneName = `%${this.getEscapedText(milestoneTitle)}`;
         gl.FilteredSearchManager.addWordToInput(this.getSelectedText(milestoneName));
       }
 

app/assets/javascripts/filtered_search/filtered_search_dropdown.js.es6

@@ -18,6 +18,24 @@
       this.dropdown.removeEventListener('click.dl', this.itemClicked.bind(this));
     }
 
+    getEscapedText(text) {
+      let escapedText = text;
+
+      // Encapsulate value with quotes if it has spaces
+      if (text.indexOf(' ') !== -1) {
+        if (text.indexOf('"') !== -1) {
+          // Use single quotes if value contains double quotes
+          escapedText = `'${text}'`;
+        } else {
+          // Known side effect: values's with both single and double quotes
+          // won't escape properly
+          escapedText = `"${text}"`;
+        }
+      }
+
+      return escapedText;
+    }
+
     getSelectedText(selectedToken) {
       // TODO: Get last word from FilteredSearchTokenizer
       const lastWord = this.input.value.split(' ').last();