Rename to latest_succeeded, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13908017

app/controllers/projects/artifacts_controller.rb

@@ -34,7 +34,7 @@ class Projects::ArtifactsController < Projects::ApplicationController
     redirect_to namespace_project_build_path(project.namespace, project, build)
   end
 
-  def search
+  def latest_succeeded
     path = params[:path]
 
     if %w[download browse file].include?(path)

app/views/projects/branches/_branch.html.haml

@@ -46,7 +46,7 @@
                 %li.dropdown-header Previous Artifacts
               - artifacts.each do |job|
                 %li
-                  = link_to search_namespace_project_artifacts_path(@project.namespace, @project, branch.name, 'download', job: job.name), rel: 'nofollow' do
+                  = link_to latest_succeeded_namespace_project_artifacts_path(@project.namespace, @project, branch.name, 'download', job: job.name), rel: 'nofollow' do
                     %span Download '#{job.name}'
 
       - if can_remove_branch?(@project, branch.name)

app/views/projects/buttons/_download.html.haml

@@ -26,5 +26,5 @@
               %li.dropdown-header Previous Artifacts
             - artifacts.each do |job|
               %li
-                = link_to search_namespace_project_artifacts_path(@project.namespace, @project, @ref, 'download', job: job.name), rel: 'nofollow' do
+                = link_to latest_succeeded_namespace_project_artifacts_path(@project.namespace, @project, @ref, 'download', job: job.name), rel: 'nofollow' do
                   %span Download '#{job.name}'

app/views/projects/tags/_download.html.haml

@@ -24,5 +24,5 @@
           %li.dropdown-header Previous Artifacts
         - artifacts.each do |job|
           %li
-            = link_to search_namespace_project_artifacts_path(project.namespace, project, ref, 'download', job: job.name), rel: 'nofollow' do
+            = link_to latest_succeeded_namespace_project_artifacts_path(project.namespace, project, ref, 'download', job: job.name), rel: 'nofollow' do
               %span Download '#{job.name}'

config/routes.rb

@@ -765,9 +765,10 @@ Rails.application.routes.draw do
 
             resources :artifacts, only: [] do
               collection do
-                get :search, path: ':ref_name/*path',
-                             format: false,
-                             constraints: { ref_name: /.+/ } # could have /
+                get :latest_succeeded,
+                  path: ':ref_name/*path',
+                  format: false,
+                  constraints: { ref_name: /.+/ } # could have /
               end
             end
           end