Commits · 08fa5dcf29ac1d564c85a886c9de282d7dbd29ec · Tristan Cavelier / erp5

18 Feb, 2010 40 commits

getCell has exactly the same code; just call it directly · 08fa5dcf
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32754 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
08fa5dcf

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32753 20353a03-c40f-0410-a6d1-a30d3c3de9de

57254bdc

- check for expiration and deletion of existing category · 05d6287b
Łukasz Nowak authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32752 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
05d6287b

reindex object when updating local roles · 9fe5def9

Aurel authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32751 20353a03-c40f-0410-a6d1-a30d3c3de9de

9fe5def9

add a test to proove that local roles are not reindexed after business · 7d7f84f1

Aurel authored Feb 18, 2010

template installed new ones


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32750 20353a03-c40f-0410-a6d1-a30d3c3de9de

7d7f84f1

simplify control flow · 4bf9bd74

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32749 20353a03-c40f-0410-a6d1-a30d3c3de9de

4bf9bd74

Use proper activity tag to prevent creating default Knowledge Pads in... · 8bc725a3

Ivan Tyagov authored Feb 18, 2010

Use proper activity tag to prevent creating default Knowledge Pads in background in case we already have such a default one Pad being indexed.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32748 20353a03-c40f-0410-a6d1-a30d3c3de9de

8bc725a3

use setdefault · 951ca867

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32747 20353a03-c40f-0410-a6d1-a30d3c3de9de

951ca867

correct syntax/variable names after cleanups · adadb375

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32746 20353a03-c40f-0410-a6d1-a30d3c3de9de

adadb375

simplification · b02ba343

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32745 20353a03-c40f-0410-a6d1-a30d3c3de9de

b02ba343

use iteritems · 4fa521b2

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32744 20353a03-c40f-0410-a6d1-a30d3c3de9de

4fa521b2

Avoid clearing activities if portal_actvities already exists. · 5ffc0eda

Nicolas Delaby authored Feb 18, 2010

This is the responsability of site Manager to recreate Activity SQL Table
if their structure change.
Reviewed by Aurel


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32743 20353a03-c40f-0410-a6d1-a30d3c3de9de

5ffc0eda

use itervalues · 9834697f

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32742 20353a03-c40f-0410-a6d1-a30d3c3de9de

9834697f

Use proper activity tag to prevent creating default Knowledge Pads in... · bae11843

Ivan Tyagov authored Feb 18, 2010

Use proper activity tag to prevent creating default Knowledge Pads in background in case we already have such a default one Pad being indexed.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32741 20353a03-c40f-0410-a6d1-a30d3c3de9de

bae11843

avoid some lookups · 1ab06076

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32740 20353a03-c40f-0410-a6d1-a30d3c3de9de

1ab06076

use enumerate · f951aaba

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32739 20353a03-c40f-0410-a6d1-a30d3c3de9de

f951aaba

Check 'My Favourites' menu for Member. · 704504f9

Romain Courteaud authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32738 20353a03-c40f-0410-a6d1-a30d3c3de9de

704504f9

use a set to avoid linear list lookups · 2e3f7f91

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32737 20353a03-c40f-0410-a6d1-a30d3c3de9de

2e3f7f91

avoid a few unnecessary lookups · 8bb8e68a

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32736 20353a03-c40f-0410-a6d1-a30d3c3de9de

8bb8e68a

use a local addError() handler to avoid code duplication · 0ad56e83
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32735 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
0ad56e83

append instead of concatenate · 46391d12

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32734 20353a03-c40f-0410-a6d1-a30d3c3de9de

46391d12

use enumerate · aecde455

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32732 20353a03-c40f-0410-a6d1-a30d3c3de9de

aecde455

use more keyToId · a6915ef2

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32730 20353a03-c40f-0410-a6d1-a30d3c3de9de

a6915ef2

use keyToId instead of re-inventing the wheel =) · 2ad70624

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32729 20353a03-c40f-0410-a6d1-a30d3c3de9de

2ad70624

do not compute the whole portal type list to only take the first item · 2e5ffd51
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32728 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
2e5ffd51
check if payment transaction is built. more assertions are required. · 188ea99c
Kazuhiko Shiozaki authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32727 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
188ea99c

several list.append => one list.extend · d02ba61a

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32726 20353a03-c40f-0410-a6d1-a30d3c3de9de

d02ba61a

"_".join(item_list) is faster and more pythonic than several str += "_%" % item · dfb4a06b
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32725 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
dfb4a06b
a KeyError here is rare: a try..except block is better than "look before leap" · ae2d6d6f
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32724 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
ae2d6d6f
use enumerate() when we need an iterator's item AND index · 31089920
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32723 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
31089920

avoid a few dictionary lookups · 6707b95f

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32722 20353a03-c40f-0410-a6d1-a30d3c3de9de

6707b95f

for payment, we care source_payment for source case (cf. for section, we care... · cfb770d6

Kazuhiko Shiozaki authored Feb 18, 2010

for payment, we care source_payment for source case (cf. for section, we care destination_section for source case). thanks to Jérome.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32721 20353a03-c40f-0410-a6d1-a30d3c3de9de

cfb770d6

list.extend(iterable) is much better than list += [x for x in iterable] · 90a4640e
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32720 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
90a4640e

sorted() looks more appropriate · d364bd1b

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32719 20353a03-c40f-0410-a6d1-a30d3c3de9de

d364bd1b

key parameter is more efficient and clear than cmp · 2c039acb
Nicolas Dumazet authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32718 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
2c039acb

dict.itervalues() seems more appropriate here · ddc40b8d

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32717 20353a03-c40f-0410-a6d1-a30d3c3de9de

ddc40b8d

one statement per line · 4d9232d5

Nicolas Dumazet authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32716 20353a03-c40f-0410-a6d1-a30d3c3de9de

4d9232d5

set up a business process for payment rule. · f199ff09

Kazuhiko Shiozaki authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32715 20353a03-c40f-0410-a6d1-a30d3c3de9de

f199ff09

multiple business paths should be supported. · 1bb049b5

Kazuhiko Shiozaki authored Feb 18, 2010


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32714 20353a03-c40f-0410-a6d1-a30d3c3de9de

1bb049b5

* count number of unique mirror sections only in preparing listbox column list. · d086f5f9
Kazuhiko Shiozaki authored Feb 18, 2010
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32713 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
d086f5f9