Bank reconciliation cleanups

Make it pass coding style

"Hide" an action that is not really useful and problematic when used by mistake

/reviewed-on nexedi/erp5!1051

bt5/erp5_bank_reconciliation/ActionTemplateItem/portal_types/Bank%20Reconciliation/select_non_reconcilied_transaction_list.xml

@@ -32,9 +32,8 @@
         </item>
         <item>
             <key> <string>description</string> </key>
-            <value>
-              <none/>
-            </value>
+            <value> <string>This action selects all transactions from this account at a given date to reconcile them all.\n
+This is only useful to start using bank reconciliation after using accounting for some years.</string> </value>
         </item>
         <item>
             <key> <string>icon</string> </key>
@@ -48,7 +47,7 @@
             <key> <string>permissions</string> </key>
             <value>
               <tuple>
-                <string>Modify portal content</string>
+                <string>Manage portal</string>
               </tuple>
             </value>
         </item>

bt5/erp5_bank_reconciliation/SkinTemplateItem/portal_skins/erp5_bank_reconciliation/BankReconciliation_notifySelectNonReconciledFinished.py

 from Products.ERP5Type.Message import translateString
 context.getPortalObject().portal_workflow.doActionFor(
-  context, 'edit_action', comment=translateString('Select non reconciled transcations finished'))
+  context, 'edit_action', comment=translateString('Select non reconciled transactions finished'))

bt5/erp5_bank_reconciliation/WorkflowTemplateItem/portal_workflow/bank_reconciliation_validation_workflow/scripts/checkConsistency.py

-object = state_change['object']
-object.Base_checkConsistency()
+state_change['object'].Base_checkConsistency()

bt5/erp5_bank_reconciliation/bt/skip_coding_style_test

-1
\ No newline at end of file