Commit a697da76 authored by Rafael Monnerat's avatar Rafael Monnerat

erp5_json_editor: Only return editor.promise is enough to catch errors

parent 255cf060
...@@ -245,19 +245,11 @@ ...@@ -245,19 +245,11 @@
gadget.editor = editor; gadget.editor = editor;
gadget.editor.on('change', gadget.deferNotifyChangeBinded.bind(gadget)); gadget.editor.on('change', gadget.deferNotifyChangeBinded.bind(gadget));
// return complex object is not possible throught iframe // editor relies on async load function, so we must return the promise
// it seems to crash rjs somewhere. To check...
// https://lab.nexedi.com/nexedi/renderjs/blob/master/renderjs.js#L2070
//return editor;
// editor relies on async load function, so we need to await the promise
// to finish before continue, otherwise rendering errors wont throw Errors // to finish before continue, otherwise rendering errors wont throw Errors
// in the same stack as expected. // in the same stack as expected.
return editor.promise.catch(); return editor.promise
}) })
.push(undefined, function (err) {
throw new Error(err);
});
}) })
.declareMethod('getContent', function () { .declareMethod('getContent', function () {
var form_data = {}; var form_data = {};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment