slapos_crm: drop Person_getSubscriptionRequestFirstUnpaidInvoiceList

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm/Person_checkToCreateRegularisationRequest.py

@@ -16,7 +16,7 @@ ticket_portal_type = "Regularisation Request"
 
 ticket = portal.portal_catalog.getResultValue(
   portal_type=ticket_portal_type,
-  default_destination_uid=person.getUid(),
+  destination__uid=person.getUid(),
   simulation_state=['suspended', 'validated'],
 )
 
@@ -25,15 +25,8 @@ if ticket is not None:
 
 outstanding_amount = person.Entity_statSlapOSOutstandingAmount()
 
-# Amount to be ignored, as it comes from the first invoice generated
-# after the subscription. We do not take it into account as no service
-# was provided yet.
-unpaid_invoice_amount = 0
-for invoice in person.Person_getSubscriptionRequestFirstUnpaidInvoiceList():
-  unpaid_invoice_amount += invoice.getTotalPrice()
-
 # It can't be smaller, we are considernig all open invoices are from unpaid_payment_amount
-if round(float(outstanding_amount), 2) == round(float(unpaid_invoice_amount), 2):
+if round(float(outstanding_amount), 2) == round(float(0), 2):
   return ticket, None
 
 if int(outstanding_amount) > 0:

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm/Person_getSubscriptionRequestFirstUnpaidInvoiceList.py

-return []

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm/Person_getSubscriptionRequestFirstUnpaidInvoiceList.xml

-<?xml version="1.0"?>
-<ZopeData>
-  <record id="1" aka="AAAAAAAAAAE=">
-    <pickle>
-      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
-    </pickle>
-    <pickle>
-      <dictionary>
-        <item>
-            <key> <string>_bind_names</string> </key>
-            <value>
-              <object>
-                <klass>
-                  <global name="_reconstructor" module="copy_reg"/>
-                </klass>
-                <tuple>
-                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
-                  <global name="object" module="__builtin__"/>
-                  <none/>
-                </tuple>
-                <state>
-                  <dictionary>
-                    <item>
-                        <key> <string>_asgns</string> </key>
-                        <value>
-                          <dictionary>
-                            <item>
-                                <key> <string>name_container</string> </key>
-                                <value> <string>container</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_context</string> </key>
-                                <value> <string>context</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_m_self</string> </key>
-                                <value> <string>script</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_subpath</string> </key>
-                                <value> <string>traverse_subpath</string> </value>
-                            </item>
-                          </dictionary>
-                        </value>
-                    </item>
-                  </dictionary>
-                </state>
-              </object>
-            </value>
-        </item>
-        <item>
-            <key> <string>_params</string> </key>
-            <value> <string></string> </value>
-        </item>
-        <item>
-            <key> <string>id</string> </key>
-            <value> <string>Person_getSubscriptionRequestFirstUnpaidInvoiceList</string> </value>
-        </item>
-      </dictionary>
-    </pickle>
-  </record>
-</ZopeData>

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm/RegularisationRequest_invalidateIfPersonBalanceIsOk.py

@@ -10,15 +10,8 @@ if (state not in ('suspended', 'validated')) or \
 
 outstanding_amount = person.Entity_statSlapOSOutstandingAmount()
 
-# Amount to be ignored, as it comes from the first invoice generated
-# after the subscription. We do not take it into account as no service
-# was provided yet.
-unpaid_invoice_amount = 0
-for invoice in person.Person_getSubscriptionRequestFirstUnpaidInvoiceList():
-  unpaid_invoice_amount += invoice.getTotalPrice()
-
 # It can't be smaller, we are considernig all open invoices are from unpaid_payment_amount
-if round(float(outstanding_amount), 2) == round(float(unpaid_invoice_amount), 2):
+if round(float(outstanding_amount), 2) == round(float(0), 2):
   context.invalidate(comment="Automatically disabled as balance is %s" % outstanding_amount)
   return