slapos_pdm: non validated allocation supply do not impact the software installation deletion

master/bt5/slapos_pdm/SkinTemplateItem/portal_skins/slapos_pdm/SoftwareInstallation_destroyIfUnused.py

@@ -43,9 +43,8 @@ for allocation_cell in portal.portal_catalog(
   resource__uid=software_product.getUid(),
   software_release__uid=software_release.getUid()
 ):
-  if allocation_cell.isAllocable():
+  if allocation_cell.isAllocable() and (allocation_cell.getValidationState() == 'validated'):
     return
-  # XXX check validation state
 
 partition = portal.portal_catalog.getResultValue(
   portal_type='Compute Partition',

master/bt5/slapos_pdm/TestTemplateItem/portal_components/test.erp5.testSlapOSPDMDestroySoftwareInstallation.py

@@ -109,5 +109,5 @@ class TestSlapOSDestroySoftwareInstallation(SlapOSTestCaseMixin):
     self.tic()
 
     software_installation.SoftwareInstallation_destroyIfUnused()
-    self.assertEqual('start_requested', software_installation.getSlapState())
+    self.assertEqual('destroy_requested', software_installation.getSlapState())
     self.assertEqual('validated', software_installation.getValidationState())