This code is present on erp5 repository, and "me" already comes with the request for person, instance and computer, so it is not required to wrapper.

Include minimal test to ensure code is consistent.

getTitle relies on acessors, it would not return "" but the id (revert as it introduce a regression)
use a diferent append on generateNewId on the test for this bt5

  Include SlapOSTestCaseMixin on portal_components and update the tests to use
  it instead directly use SlapOSMixin from SlapOS Product

Payment State gadget translate the State of Sale Invoice Transaction and the Payment Transaction into a message meaningful to the User. (Unpaied, Waiting for Payment, Pay Now...).

Payment State gadget, in case of Payment Required, can include the Link to Pay Now using Payzen API.

The code result.portal_type.replace(' ', '_') gives Sale_Invoice Transaction

The code result.portal_type.replace(/ /g, '_') gives Sale_Invoice_Transaction

This may sabe a bit of miliseconds per call.

Those portal types sets acquire_local_roles definition (security), so it is more appropriated to place it on slapos_erp5 bt5.

Remove all code which will become obsolete after the launch of SlapOS 2.0

use profile to log promises resource consumption

/reviewed-on !37

needed for example for wendelin.core arrays + connections

@alain.takoudjou , @rafael  if no objections can you please accept & merge it?

/reviewed-on nexedi/slapos.core!36

slapos/slap/slap.py slap.initializeConnection: Cache master node's Hateoas URL and do not ask many times. Communication to master node is expensive.

slapos/slap/slap.py: Fix ComputerPartition.setConnectionDict. Declare connection_parameter_hash explicitly, UnboundLocalError may occur.

rename checkPromises to checkPromiseList, and move the method to grid/utils so it can be imported by monitor to check promises.


`raise_on_failure` will be used to check all promises without raise. All promises result will be returned.

`profile` True/False will log promise execution time.

/reviewed-on !35