This constraint will have to be enabled by configurator/upgrader.

Instead of selecting already stopped payments, introduce a new "mode" field in
the dialog, where user can choose the previous behavior of selecting stopped
payments, or a new behavior where user would select planned or confirmed payments,
in that case the payments will be automatically stopped before being added to
the group.

Functional test for erp5_payment_mean with ERP5JS

Functional test for erp5_payment_mean

Rename the field, because on xhtml_style, submitting the field with an
empty limit now cause an error like:

    ValueError: invalid literal for int() with base 10: ''

and on ERP5JS it is ignoed.

Also, make the field required and set a small default value and a range,
to prevent accidentally displaying/selecting too much when there's lot of
data matching.

We don't want to show the ID which has a prefix, but the reference

By default, tesseract runs on 4 CPU and this can be controlled by
OMP_THREAD_LIMIT=1 to run on only one CPU (as documented on
https://tesseract-ocr.github.io/tessdoc/FAQ.html)

In ERP5, we tend to use one zope node per CPU, so we don't want each
of these zope nodes to spawn a process which will run on 4 CPU.

In a quick benchmark it's not slower, even a bit faster to disable threads:

    ## a big image in france (a picture of an invoice)
    $ time ./bin/tesseract /tmp/input.tiff /tmp/out.txt
    Tesseract Open Source OCR Engine v4.1.1 with Leptonica
    Page 1
    Error in pixClipBoxToForeground: box not within image
    Error in pixClipBoxToForeground: box not within image

    ________________________________________________________
    Executed in   14.41 secs   fish           external
      usr time   27.88 secs  1002.00 micros   27.88 secs
      sys time    0.74 secs    0.00 micros    0.74 secs

    $ time OMP_THREAD_LIMIT=1 ./bin/tesseract /tmp/input.tiff /tmp/out.txt
    Tesseract Open Source OCR Engine v4.1.1 with Leptonica
    Page 1
    Error in pixClipBoxToForeground: box not within image
    Error in pixClipBoxToForeground: box not within image

    ________________________________________________________
    Executed in   12.58 secs   fish           external
      usr time   11.84 secs  955.00 micros   11.84 secs
      sys time    0.52 secs  503.00 micros    0.52 secs

    ## a small japanese image

    $ time ./tesseract -l jpn+eng /tmp/inputjp.tiff /tmp/out.txt
    Tesseract Open Source OCR Engine v4.1.1 with Leptonica
    Page 1

    ________________________________________________________
    Executed in    2.16 secs   fish           external
      usr time    3.77 secs  590.00 micros    3.77 secs
      sys time    0.27 secs  209.00 micros    0.27 secs

    $ time OMP_THREAD_LIMIT=1 ./tesseract -l jpn+eng /tmp/inputjp.tiff /tmp/out.txt
    Tesseract Open Source OCR Engine v4.1.1 with Leptonica
    Page 1

    ________________________________________________________
    Executed in    2.02 secs   fish           external
      usr time  1766.07 millis  1437.00 micros  1764.63 millis
      sys time  214.06 millis  522.00 micros  213.54 millis

because DMS extends image portal types with interaction workflows etc,
it's better to also cover the case where DMS is installed.

This fixes problem that some formats such as tiff were not supported.

testSQLCachedWorklist is now part of a dedicated erp5_worklist_sql_test
business template.

We had two mimetypes entries, which caused inconsistencies depending on
wether the lookup was done by mimetype, by glob or by extension.

We had:

- name:
   "Windows BMP image"
- mimetypes:
    image/bmp
    image/x-bmp
    image/x-MS-bmp
- extensions:
- globs:
    *.bmp

and

- name:
   "image/x-ms-bmp"
- mimetypes:
    image/x-ms-bmp
- extensions:
    bmp
- globs:

With this commit they are merged into one:

- name:
   "Windows BMP image"
- mimetypes:
    image/x-ms-bmp
    image/bmp
    image/x-bmp
    image/x-MS-bmp
- extensions:
    bmp
- globs:
    *.bmp

This way we only have one consistent mimetype.

For compatibility with extension lookups (that are done in
Document_guessMimeType interaction workflow from DMS), image/x-ms-bmp is
kept as default. This might not be the best choice, according to
https://www.iana.org/assignments/media-types/media-types.xhtml

This script creates Web Message, not Mail Message

When updating ghostscript, the rendering of images seems slightly different, as we can observe on the logos.

Fixes [#20210517-960A47](https://erp5js.nexedi.net/#/bug_module/20210517-960A47)

The most important changes are:
 - coding style is enabled again for workflow scripts and starts to be enabled for ERP5 Python scripts
 - monaco editor support for workflow scripts, SQL methods and .less
 - small fixes for python/workflow scripts forms and ZMI

See merge request nexedi/erp5!1422

Changing state directly in Base_contribute was only functional for the case
where metadata was discovered asynchronously. In the case of synchronous
discovery, the state was first changed state, and Document_convertToBaseFormatAndDiscoverMetadata
was executed - but this this was causing Unauthorized like this:

      Module script, line 10, in Document_convertToBaseFormatAndDiscoverMetadata
      - <PythonScript at /erp5/Document_convertToBaseFormatAndDiscoverMetadata used for /erp5/document_module/163>
      - Line 10
        return context.discoverMetadata(filename=filename,
    Unauthorized: You are not allowed to access 'discoverMetadata' in this context

because once we have already changed state, regular user no longer have
permission to access discoverMetadata, because that method needs ModifyPortalContent
permission.

Instead, of handling publication_state only in Base_contribute, treat it
like others user input parameter and change state during discovery.

Tests were also re-organised to move Base_contribute related test in testIngestion
and also to run Base_contribute tests as a non-manager user.

This was never supported, we support only [state in $workflow_id]

See also:

  https://erp5js.nexedi.net/#/bug_module/1740

  b6dcbc19 (l10n_fr,l10n_jp: Fix translation of "Open", 2021-04-30)

Generated from this script:

    #!/srv/slapgrid/slappart3/srv/runner/software/cc0326f0dcb093f56c01291c300c8481/parts/erp5/venv/bin/python

    import polib
    import sys
    import re

    pofile = polib.pofile(sys.argv[1])

    msgs = dict()
    for entry in pofile:
      msgs[entry.msgid] = entry.msgstr

    transition_re = re.compile(r'(.*) \[transition in .*\]')

    fixed_messages = dict()
    for entry in pofile:
      match = transition_re.match(entry.msgid)
      if match:
        # in erp5_l10n_de some msgstr also have the [transition in ...], we drop them
        if transition_re.match(entry.msgstr):
          continue
        short = match.groups()[0]
        if short.endswith('Action'):
          continue
        if short not in msgs:
          print(f"🤔  {short} not translated ( from {entry.msgid} )")
          fixed_messages[short] = entry.msgstr
      else:
        fixed_messages[entry.msgid] = entry.msgstr

    pofile.clear()
    for k, v in fixed_messages.items():
      pofile.append(polib.POEntry(msgid=k, msgstr=v))

    pofile.save(sys.argv[1])

    import subprocess
    subprocess.check_output(
      [
        '/opt/slapos-shared/gettext/4df93a547efd86e0eb70495b88a5d3b1/bin/msgattrib',
        sys.argv[1],
        "--no-fuzzy",
        "--translated",
        "-s",
        "--no-wrap",
        "-o",
        sys.argv[1]

      ]
    )

using:

    msgattrib translation.po --no-fuzzy --translated -s --no-wrap -o translation.po

translated_title is used in listbox search columns, so it's very confusing
for users if they can not use the usual % character for partial matches.

This changes the behaviour of translated_title to autodetect the presence of
% and use LIKE comparison operator in such case.

these ERP5 Python Scripts were not covered by coding style tests

This ERP5 Python script was not checked until now, and add wrong indentation

The ID is calculated from reference, showing reference is enough.
There is no "callable_type" property on workflow script