Commit 85d2424f authored by Stefan Behnel's avatar Stefan Behnel

Clarify a variable name and simplify its usage.

parent 492fd0cf
...@@ -1284,9 +1284,11 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode): ...@@ -1284,9 +1284,11 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode):
cpp_class_attrs = [entry for entry in scope.var_entries cpp_class_attrs = [entry for entry in scope.var_entries
if entry.type.is_cpp_class] if entry.type.is_cpp_class]
new_func_entry = scope.lookup_here("__new__") cinit_func_entry = scope.lookup_here("__cinit__")
if base_type or (new_func_entry and new_func_entry.is_special if cinit_func_entry and not cinit_func_entry.is_special:
and not new_func_entry.trivial_signature): cinit_func_entry = None
if base_type or (cinit_func_entry and not cinit_func_entry.trivial_signature):
unused_marker = '' unused_marker = ''
else: else:
unused_marker = 'CYTHON_UNUSED ' unused_marker = 'CYTHON_UNUSED '
...@@ -1394,14 +1396,14 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode): ...@@ -1394,14 +1396,14 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode):
if cclass_entry.cname == '__pyx_memoryviewslice': if cclass_entry.cname == '__pyx_memoryviewslice':
code.putln("p->from_slice.memview = NULL;") code.putln("p->from_slice.memview = NULL;")
if new_func_entry and new_func_entry.is_special: if cinit_func_entry:
if new_func_entry.trivial_signature: if cinit_func_entry.trivial_signature:
cinit_args = "o, %s, NULL" % Naming.empty_tuple cinit_args = "o, %s, NULL" % Naming.empty_tuple
else: else:
cinit_args = "o, a, k" cinit_args = "o, a, k"
needs_error_cleanup = True needs_error_cleanup = True
code.putln("if (unlikely(%s(%s) < 0)) goto bad;" % ( code.putln("if (unlikely(%s(%s) < 0)) goto bad;" % (
new_func_entry.func_cname, cinit_args)) cinit_func_entry.func_cname, cinit_args))
code.putln( code.putln(
"return o;") "return o;")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment