Avoid unlocking never-locked objects at the end of functions

a8d56eae · gsamain · Xavier Thompson · 2508d906 · a8d56eae
Commit a8d56eae authored Jun 04, 2019 by gsamain Committed by Xavier Thompson Jun 18, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

Cython/Compiler/Nodes.py Cython/Compiler/Nodes.py +2 -1

No files found.
--- a/Cython/Compiler/Nodes.py
+++ b/Cython/Compiler/Nodes.py
@@ -2216,7 +2216,8 @@ class FuncDefNode(StatNode, BlockNode):
                code.put_var_xdecref(entry, have_gil=gil_owned['success'])

        for node in lenv.autolocked_nodes:
-            code.putln("Cy_UNLOCK(%s);" % node.result())
+            if node.entry.needs_rlock or node.entry.needs_wlock:
+                code.putln("Cy_UNLOCK(%s);" % node.result())

        # Decref any increfed args
        for entry in lenv.arg_entries: