Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Xavier Thompson
cython
Commits
b96c2f36
Commit
b96c2f36
authored
Nov 03, 2020
by
Xavier Thompson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid incref-ing and decref-ing around cypclass locks when possible
parent
39620fff
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
5 deletions
+14
-5
Cython/Compiler/ExprNodes.py
Cython/Compiler/ExprNodes.py
+14
-5
No files found.
Cython/Compiler/ExprNodes.py
View file @
b96c2f36
...
...
@@ -14175,13 +14175,18 @@ class CoerceToLockedNode(CoercionNode):
# This node is used to lock a node of cypclass type around the evaluation of its subexpressions.
# rlock_only boolean
# needs_decref boolean used internally
def
__init__
(
self
,
arg
,
env
=
None
,
rlock_only
=
False
):
self
.
rlock_only
=
rlock_only
self
.
type
=
arg
.
type
arg
=
arg
.
coerce_to_temp
(
env
)
arg
.
postpone_subexpr_disposal
=
True
super
(
CoerceToLockedNode
,
self
).
__init__
(
arg
)
temp_arg
=
arg
.
coerce_to_temp
(
env
)
temp_arg
.
postpone_subexpr_disposal
=
True
# Avoid incrementing the reference count when assigning to the temporary
# but ensure it will be decremented if it was already incremented previously.
self
.
needs_decref
=
not
temp_arg
.
use_managed_ref
temp_arg
.
use_managed_ref
=
False
super
(
CoerceToLockedNode
,
self
).
__init__
(
temp_arg
)
def
result
(
self
):
return
self
.
arg
.
result
()
...
...
@@ -14219,8 +14224,12 @@ class CoerceToLockedNode(CoercionNode):
def
generate_disposal_code
(
self
,
code
):
# Close the scope to release the lock.
code
.
putln
(
"}"
)
# Dispose of subexpressions.
super
(
CoerceToLockedNode
,
self
).
generate_disposal_code
(
code
)
# Dispose of and free subexpressions.
self
.
arg
.
generate_subexpr_disposal_code
(
code
)
self
.
arg
.
free_subexpr_temps
(
code
)
# Decref only if previously incref-ed.
if
self
.
needs_decref
:
code
.
put_xdecref_clear
(
self
.
result
(),
self
.
ctype
(),
have_gil
=
not
self
.
in_nogil_context
)
class
ProxyNode
(
CoercionNode
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment