1. 04 Jun, 2021 6 commits
    • Jérome Perrin's avatar
      ERP5Security: ignore leading/trailing spaces in usernames · d76b8d8e
      Jérome Perrin authored
      We received a few support requests from users who are able to change their
      password but not to log-in afterwards. These users probably copy and pasted
      their user name with an extra leading or trailing space. In the reset
      password dialog, these spaces are stripped, because Formulator by default
      strips the input (unless "whitespace preserve" is on, but we usually don't
      set it except in text areas).
      
      Historically we have been completely avoiding the extra spaces and made the
      login/user_id case insensitive, because login and user id were the same
      thing and there have been issues when looking up user id in mariadb because
      of mariadb collations, so we took the easy way of saying "logins are case
      sensitives and spaces also mater", but with separate login / user id,
      this can be revisited, because the login is only used to check the password
      and find an user ID.
      
      Stripping spaces from logins is a common thing these days (google, twitter,
      facebook strip logins) which simplifies user experience and reduces support.
      
      The risk of conflicts seems very low, if users are created with ERP5 Forms
      Formulator already had stripped the login anyway. After this change in case
      of two user names ('alice' and ' alice ') conflict, none of them would be
      able to login.
      We keep compatibility with users with trailing spaces, so if there is only
      a user named ' alice ', without other users that would conflict (for
      example 'alice' or ' alice'), this user remain able to login anyway. This
      last part is probably not so important in reality, it is for compatibility
      with testPasswordTool.TestPasswordTool.test_login_with_trailing_space
      d76b8d8e
    • Jérome Perrin's avatar
      officejs: fix typo · 21c271cd
      Jérome Perrin authored
      21c271cd
    • Jérome Perrin's avatar
      trade/accounting: fix "Trade Condition" column on accounting module · d7bfd46d
      Jérome Perrin authored
      Rename this column from "Sale Trade Condition" to "Trade Condition", so
      that it can be used also for purchase and internal trade conditions.
      d7bfd46d
    • Jérome Perrin's avatar
      Payment mean and SEPA credit transfer · 66670bd2
      Jérome Perrin authored
       - update for ERP5JS compatibility
       - prevent an error with "Select Payments" update action, when limit was empty
       - export to generate SEPA credit transfer ( pain.001.001.02 )
       - new mode in "Select Payment" to select planned/confirmed payment and validate them at the same time
       - allow selecting lines individually in "Select Payments"
       - allow filtering by third party in "Select Payments" (only supported in xhtml_style for now)
       - fix issue that Deliver transaction leaves PTG in Delivering state 
       - french translations
      
      See merge request nexedi/erp5!1400
      66670bd2
    • Jérome Perrin's avatar
      corporate_identity_test: update expected images after updating ghostscript 9.54.0 · f6637a16
      Jérome Perrin authored
      Changes following up nexedi/slapos!985
      
      It seems the logo is a bit bigger, or at least a bit different
      
      See merge request nexedi/erp5!1424
      f6637a16
    • Jérome Perrin's avatar
      Lighter processing for OCR activities · 9e375b8e
      Jérome Perrin authored
      When running OCR, we sometimes have issues because processing is "too heavy":
       - [x] use 2 or 3 Go of disk space for a one page PDF created by erp5_document_scanner, because we convert pdf -> png -> tiff before sending to tesseract. Modern Ghostscript supports running tesseract directly, so we use it if it's available.
       - [x] use 300% of CPU. Fixed by setting `OMP_THREAD_LIMIT` when running tesseract. This will only apply when OCR from Images. OCR embedded in Ghostscript does not seem to need this.
       - [x] ... and often crash, so is restarted. This is fixed by updated tesseract.
      
      Updates of ghostscript and tesseract are part of nexedi/slapos!985
      
      See merge request nexedi/erp5!1420
      9e375b8e
  2. 03 Jun, 2021 2 commits
    • Jérome Perrin's avatar
      Base: support more image formats · f084c646
      Jérome Perrin authored
      By relying on PIL after our monkey-patched OFS.Image.getImageInfo.
      
      We keep this monkey-patch for now, because it adds supports to svg
      
      See merge request nexedi/erp5!1426
      f084c646
    • Jérome Perrin's avatar
      dms: drop PDF thumbnail view · 6dce55b0
      Jérome Perrin authored
      Since 7f32f8cd (erp5_dms: Add PDF Reader using the pdf.js, 2016-06-24)
      we have a PDF preview with a javascript PDF view, which is much better way
      of viewing PDF.
      
      This commit made the Thumbnail preview obsolete, also it does not really
      work on ERP5JS, so remove the thumbnail preview.
      6dce55b0
  3. 02 Jun, 2021 14 commits
  4. 01 Jun, 2021 1 commit
  5. 31 May, 2021 17 commits