- 08 Nov, 2023 1 commit
-
-
Jérome Perrin authored
We were setting the value to a string with seconds like `2010-01-01T00:00:00` and all the tests were testing that the value of the input element was exactly the same (ie. with seconds), but [the spec] mentions that value is: - A valid date string representing the date. - A U+0054 LATIN CAPITAL LETTER T character (T). - A valid time string representing the time, expressed as the shortest possible string for the given time (e.g. omitting the seconds component entirely if the given time is zero seconds past the minute). The test works fine when running on firefox 68 (the one from testnodes), because this version does not implements datetime-local and such field behave like text inputs, but when running with a modern browser implementing the spec, the test fails because the value from the fields `.value` does not have seconds. While the change to rjs_gadget_erp5_datetimefield_js is not strictly necessary, because when setting the value on a datetime-local the value will be normalized and having 00 seconds or omitting the seconds is same, this is done to keep the test passing on old browsers without support for datetime-local fields. [the spec]: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#concept-datetime-local
-
- 07 Nov, 2023 2 commits
-
-
Jérome Perrin authored
so that we can see them on testnode.
-
Jérome Perrin authored
Because they depend on the browser version, the window size, the available fonts and maybe other things, snapshot tests basically only work when running on testnode and fail when we run the tests from our browsers locally. With this option, the difference of snapshot are not considered a failure. Also adjust snapshots, because this adds a checkbox in the upper frame, the viewport of the test frame is now a little bit taller.
-
- 27 Oct, 2023 4 commits
-
-
Jérome Perrin authored
This code seems to have been pushed accidentally as part of 6e5e8e8c (fixup! test: follow recent ImageMagick spec., 2023-10-11)
-
Jérome Perrin authored
This reverts commit 14831fae. As discussed in 14831fae (comment 188678) this change breaks test and it seems more natural to implement this with listbox's sort parameter. This change will be pushed again, probably as part of !1305
-
Jérome Perrin authored
This is what browsers do when user selects a file.
-
Jérome Perrin authored
testnode uses ProcessManager.killall to terminate all processes from a path. To determine if a process is from a path, it looks at the command line. This does not work for processes using setproctitle to change their command line. We can see in ps: $ ps -edf | grep nginx slapuse+ 115059 45574 0 16:14 ? 00:00:00 nginx: master process /srv/slapgrid/slappart46/t/cvt/i/0/tmp/shared/nginx/6d79cb0e7d81dce1be97eec8a5712f08/sbin/nginx -c /srv/slapgrid/slappart46/t/cvt/i/0/tmp/inst/T-0/etc/nginx-master-introspection.conf slapuse+ 115090 115059 0 16:14 ? 00:00:00 nginx: worker process or by looking at cmdline, which is what psutil.Process.cmdline is using: $ cat /proc/115090/cmdline nginx: worker process and that's why sometimes when cancelling a software release test while it is running tests from a software using nginx, some processes are leaked, they keep using the port and next test running on this testnode fail. In that case, killall is called with /srv/slapgrid/slappart46/t/cvt , we can not find such process with cmdline, but we can extend this heuristic to use the current working directory: $ ls -al /proc/115090/cwd lrwxrwxrwx 1 slapuser46 slapuser46 0 Oct 19 16:16 /proc/115090/cwd -> /srv/slapgrid/slappart46/t/cvt/i/0/tmp/inst/T-0 This also applies an optimization of only considering processes of the current unix user.
-
- 20 Oct, 2023 3 commits
-
-
Vincent Pelletier authored
Products.ERP5Types.patches.CMFCoreSkinnable: Only add portal_callables to skin selection when tool exists Avoids a noisy log: WARNING Products.ERP5Type.patches.CMFCoreSkinnable Skin folder portal_callables is in selection list but does not exist.
-
Vincent Pelletier authored
As already documented in this code, unrestrictedTraverse provides a flat dict as "request" argument. PAS plugins cannot work with such fake request, so such _extractUserIds call will not succeed in authenticating the user, and instead produces (suppressed) exceptions within PAS. As a result, neither codepaths can be followed: - PAS cannot find any user, hence "if len(user_list) > 0:" is false - the "else" codepath starts with "request._auth", which obviously raises when request is a dict So, reorder the code so that the nature of the request is checked before either codepath is entered, skipping the bulk of this code and avoiding calling into PAS.
-
Vincent Pelletier authored
-
- 19 Oct, 2023 2 commits
-
-
Levin Zimmermann authored
The default soft limit of open file descriptors is usually set to 1024 in order to avoid breaking old software which still uses select. In many projects we may need a higher limit: particularly in Wendelin based projects we easily reach this limit. Before this patch it was therefore necessary to either patch ERP5 in the project specific SR or to manually increase the limit of the zope processes (or the parent supervisor) with a tool like prlimit [1]. With this patch it becomes possible to increase the soft limit to the hard limit with a command line argument of the zopewsgi bin. This simplifies setting the soft limit for any Wendelin project. [1] https://man7.org/linux/man-pages/man1/prlimit.1.html /reviewed-by @vpelletier, @jerome /reviewed-on nexedi/erp5!1827
-
Jérome Perrin authored
test_suite and tests_require are for the deprecated `setup.py test` command that we no longer use.
-
- 18 Oct, 2023 3 commits
-
-
Jérome Perrin authored
During initial install in most cases we just want to install everything, showing the listbox to choose install options is not necessary. The problem is that this listbox is really big when installing multiple business templates. This introduces a "detailed install" checkbox, that is unchecked by default, to make it possible to show the list to choose from anyway.
-
Jérome Perrin authored
so that we can view in inline with firefox for Zelenium tests This was applied manually on http://www.erp5.org/dists/snapshot/test_bt5
-
Léo-Paul Géneau authored
-
- 17 Oct, 2023 4 commits
-
-
Roque authored
See merge request nexedi/erp5!1830
-
Roque authored
-
Roque authored
See merge request nexedi/erp5!1826
-
Roque authored
- randomize flag scores and weights - limit drone message size - new rule: extra score point for drones that returned to base - refactor x-y-z / lat-lon-alt method/properies to be consistent - update api doc
-
- 13 Oct, 2023 2 commits
-
-
Jérome Perrin authored
A typical problem which prevents grouping is that the line is used in an internal invoice and while all the conditions for grouping seems OK for one side, they are not OK for the other side, because the accounts are different from the mirror side. By showing the mirror account it should be a bit easier for users to figure out what is wrong.
-
Jérome Perrin authored
-
- 11 Oct, 2023 3 commits
-
-
Jérome Perrin authored
FCK Editor is old name https://ckeditor.com/old/forums/CKEditor-3.x/Should-FCKeditor-change-its-name
-
Kazuhiko Shiozaki authored
-
Jérome Perrin authored
This linter is too old and no longer relevant
-
- 10 Oct, 2023 5 commits
-
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
Note that raster image to SVG conversion no longer works without potrace.
-
Vincent Pelletier authored
Thanks to Jérôme for digging these resources up.
-
Vincent Pelletier authored
The way Zope4 logs the authenticated user is radically different from Zope2, and makes this function useless. So, unless when running on Zope2, do nothing when this function is called.
-
Vincent Pelletier authored
So that msec=1 is logged as ",001" and not as ",1".
-
- 06 Oct, 2023 1 commit
-
-
Georgios Dagkakis authored
Because if we have for example a Web Site for which default language is 'fr' it would not get gadget Web Pages for which the language is 'en' The scope here is to match as many documents as possible
-
- 04 Oct, 2023 2 commits
-
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
- 03 Oct, 2023 1 commit
-
-
Yusei Tahara authored
-
- 02 Oct, 2023 4 commits
-
-
Roque authored
See merge request nexedi/erp5!1824
-
Roque authored
- grid of blocks - set of block templates - randomization conditions - new terrarin texture - refine enemy drone collision - more aggressive enemies
-
Roque authored
- drop import/export json - API for operator script - map utils class update - doc api update - all visible map parameters are geo - allow to run twice - fix default ai drone script distance fn - fix flag elements position (altitude) - better error handling
-
Roque authored
- add a new operator script editor - update finish rules and scoring system - refactor map parameters - map randomization is done now by new class map utils - update init flag info msg - import/export script feature - update web site CSP - ui: activate js syntax in user script editor - ui: styles, section titles, etc - doc api update - fixes/refactoring -- fix default target coordinates bug -- control empty/invalid user scripts -- raise an error on user script syntax error -- fix onUpdate timestamp parameter (to integer milliseconds) -- fix drone loiter (based on nexedi/erp5!1817/)
-
- 29 Sep, 2023 1 commit
-
-
Yusei Tahara authored
-
- 28 Sep, 2023 2 commits
-
-
Jérome Perrin authored
-
Georgios Dagkakis authored
PDF_viewPDFJSPreview/my_data Anyway, we are in PDF context, it can work even if content_type is not set
-