- 06 Mar, 2019 2 commits
-
-
Łukasz Nowak authored
As leaving close_fds=False can result in subtle bugs (see http://zderadicka.eu/subtle-evil-of-close_fds-parameter-in-subprocess-popen/ ) close descriptors before launching anything with ProcessManager, especially useful for starting things like supervisord. /reviewed-on nexedi/erp5!841
-
Jérome Perrin authored
This solves the race condition that leaves stdout as a StringIO when this is executed twice in parrallel ( #20180928-1D89375 ) But this prints No config file found, using default configuration on sys.stderr at every execution, but that's acceptable. Once we update pylint, we can disable this warning by setting verbose=false ( this is not yet available on pylint 1.4.4 ) /reviewed-on !758
-
- 05 Mar, 2019 2 commits
-
-
Sebastien Robin authored
-
Sebastien Robin authored
supervirord when stopping might need several seconds to kill properly sub processes. So give him some time before killing more brutaly with killall. This should solve issue with functional tests are not working due to apache not starting. Apache when killed to brutally let unclosed semaphore, and after some time, we have too many semaphore to start new apache, making functional tests failing.
-
- 04 Mar, 2019 1 commit
-
-
Julien Muchembled authored
This implements a special case of node specialization, to make better use of the ZODB Storage cache. By default, a non-grouped message is marked to be executed by the same node that created it, if the object is not a tool and if it was not activated by path. This can be overridden (either forced or prevented) using a new 'node' activate() parameter. See message of the first merged commits for details, and also ActiveObject.activate() docstring. For SQLDict & SQLQueue only. In the future, the new 'node' argument could accept any other string value that refers to a group of nodes. Groups would be defined on the activity tool, and be assigned negative integers. Contrary to what is implemented here, such specialization would be strict, in that a node would never process a message for a group it does not belong. /reviewed-on nexedi/erp5!836
-
- 01 Mar, 2019 1 commit
-
-
Georgios Dagkakis authored
instead of crashing. This can happen in workflow if we have: - transition_x is declared as possible in state_x - then transition_x gets deleted In this case in state_x in manage_properties nothing is visible, which creates an inconsistent in its data, yet functional generally workflow Since it is easy to create such cases, just ignore them in Module_listWorkflowTransitionItemList so that mass change state can work
-
- 27 Feb, 2019 1 commit
-
-
Arnaud Fontaine authored
-
- 26 Feb, 2019 6 commits
-
-
Arnaud Fontaine authored
-
Jérome Perrin authored
This also fixups b9b14bc7 for the case where the consumption range is different from consumed budget or engaged budget (for exemple when we have only engaged movements on a given node).
-
Jérome Perrin authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
Until now, only bt5 Extension/Test/Document could be migrated from filesystem. From migration dialog, allow to select any Products.ERP5.Document.* (only, for now) to be migrated. By default, automatically select Products Documents used by the current bt5 Portal Types (by looking at the mro() of its erp5.portal_type classes). Also, to easily identified where it was migrated from, source_reference is set to 'bt.getTitle():ID' for bt5 Extension/Test/Document and 'Products.ERP5.Document.XXX' for filesystem Products.
-
Arnaud Fontaine authored
One Mixin to handle {Document,Interface,Mixin,Test,Extension} code from: * deprecated local (instancehome/XXX). * ZODB Components. * Products migration (in a later commit).
-
- 25 Feb, 2019 3 commits
-
-
Julien Muchembled authored
In this specific case, the number of grouped messages is bound, and actually not greater than the number of grouped messages being processed for normal indexing.
-
Sebastien Robin authored
-
Sebastien Robin authored
-
- 22 Feb, 2019 2 commits
-
-
Sebastien Robin authored
-
Sebastien Robin authored
-
- 21 Feb, 2019 4 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
The goal is to make better use of the ZODB Storage cache. It is common to do processing on a data set in several sequential transactions: in such case, by continuing execution of these messages on the same node, data is loaded from ZODB only once. Without this, and if there are many other messages to process, processing always continue on a random node, causing much more load from ZODB. To prevent nodes from having too much work to do, or too little compared to other nodes, this new parameter is only a hint for CMFActivity. It remains possible for a node to execute a message that was intended for another node. Before this commit, a processing node selects the first message(s) according to the following ordering: priority, date and now: priority, node_preference, date where node_preference is: -1 -> same node 0 -> no preferred node 1 -> another node The implementation is tricky for 2 reasons: - MariaDB can't order this way in a single simple query, so we have 1 subquery for each case, potentially getting 3 times the wanted maximum of messages, then order/filter on the resulting union. - MariaDB also can't filter efficiently messages for other nodes, so the 3rd subquery returns messages for any node, potentially duplicating results from the first 2 subqueries. This works because they'll be ordered last. Unfortunately, this requires extra indices. In any case, message reservation must be very efficient, or MariaDB deadlocks quickly happen, and locking an activity table during reservation reduces parallelism too much. In addition to better cache efficiency, this new feature can be used as a workaround for a bug affecting serialiation_tag, causing IntegrityError when reindexing many new objects. If you have 2 recursive reindexations for both a document and one of its lines, and if you have so many messages than grouping is split between these 2 messages, then you end up with 2 nodes indexing the same line in parallel: for some tables, the pattern DELETE+INSERT conflicts since InnoDB does not take any lock when deleting a non-existent row. If you have many activities creating such documents, you can combine with grouping and appropriate priority to make sure that such pair of messages won't be executed on different nodes, except maybe at the end (when there's no document to create anymore; then activity reexecution may be enough). For example: from Products.CMFActivity.ActivityTool import getCurrentNode portal.setPlacelessDefaultReindexParameters( activate_kw={'node': 'same', 'priority': priority}, group_id=getCurrentNode()) where `priority` is the same as the activity containing the above code, which can also use grouping without increasing the probability of IntegrityError.
-
Sebastien Robin authored
Kill any process having in command line the path reserved for unit test. This would really allows to kill any remaining process if any. Do not look if processes are child of testnode, because processes like mariadb and others are not running as child
-
Nicolas Wavrant authored
-
- 20 Feb, 2019 4 commits
-
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
portal.portal_simulation.getInventoryList(section_category='', src__=True) use query like AND (`related_stock_section_category_uid_1_category`.`category_uid` = 281(Uid of portal_categories)
-
Sebastien Robin authored
Kill any process having in command line the path reserved for unit test. This would really allows to kill any remaining process if any. Do not look if processes are child of testnode, because processes like mariadb and others are not running as child
-
Sebastien Robin authored
-
- 18 Feb, 2019 3 commits
-
-
Łukasz Nowak authored
It was incorrectly assuming style of passed information.
-
Łukasz Nowak authored
SlapOS will publish directly SQLBENCH_PATH in environment, so start using it also trusting that PATH is correctly set to find proper perl, with fetching old OPENSSL_BINARY and finding perl in the old wayas fallback.
-
Kazuhiko Shiozaki authored
otherwise Firefox (with default configuration) may display strange colors, especially if the original uses ICC v4 profile.
-
- 16 Feb, 2019 1 commit
-
-
Tatuya Kamada authored
-
- 15 Feb, 2019 7 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
Notify the user and redirect to the storage page to force user to enter credentials if needed
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Vincent Pelletier authored
-
- 14 Feb, 2019 3 commits
-
-
Julien Muchembled authored
-
Jérome Perrin authored
* Review SMS sending API to move the complexity and the various parameters from the interface script `ShortMessage_send` to the gateway interfaces. * Fix problem with mobyt with messages longer than 140 characters * Fix [#20170709-17309B6](https://nexedi.erp5.net/bug_module/20170709-17309B6) * add an (incomplete) test /reviewed-on nexedi/erp5!580
-
Jérome Perrin authored
![image](/uploads/f86e89066db17979735f892c5c36a90f/image.png) This introduces a new portal type group "payment request" /reviewed-on nexedi/erp5!831
-