Commit f72165fd authored by Cédric Le Ninivin's avatar Cédric Le Ninivin

PreferenceTool: fix _getPreference Unauthorized

parent d8373308
...@@ -30,7 +30,6 @@ ...@@ -30,7 +30,6 @@
from AccessControl import ClassSecurityInfo from AccessControl import ClassSecurityInfo
from AccessControl.SecurityManagement import getSecurityManager,\ from AccessControl.SecurityManagement import getSecurityManager,\
setSecurityManager, newSecurityManager setSecurityManager, newSecurityManager
from AccessControl.ZopeGuards import guarded_getattr
from MethodObject import Method from MethodObject import Method
from Products.ERP5Type.Globals import InitializeClass, DTMLFile from Products.ERP5Type.Globals import InitializeClass, DTMLFile
...@@ -73,7 +72,7 @@ class PreferenceMethod(Method): ...@@ -73,7 +72,7 @@ class PreferenceMethod(Method):
# there is a design problem in current archive API. # there is a design problem in current archive API.
sql_catalog_id = kw.pop('sql_catalog_id', None) sql_catalog_id = kw.pop('sql_catalog_id', None)
for pref in instance._getSortedPreferenceList(sql_catalog_id=sql_catalog_id): for pref in instance._getSortedPreferenceList(sql_catalog_id=sql_catalog_id):
value = guarded_getattr(pref, self._preference_getter)(_marker, *args, **kw) value = getattr(pref, self._preference_getter)(_marker, *args, **kw)
# XXX Due to UI limitation, null value is treated as if the property # XXX Due to UI limitation, null value is treated as if the property
# was not defined. The drawback is that it is not possible for a # was not defined. The drawback is that it is not possible for a
# user to mask a non-null global value with a null value. # user to mask a non-null global value with a null value.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment