An error occurred fetching the project authors.
  1. 19 Dec, 2018 1 commit
  2. 12 Dec, 2018 1 commit
  3. 11 Dec, 2018 1 commit
    • Yorick Peterse's avatar
      Refactor Project#create_or_update_import_data · 26378511
      Yorick Peterse authored
      In https://gitlab.com/gitlab-org/release/framework/issues/28 we found
      that this method was changed a lot over the years: 43 times if our
      calculations were correct. Looking at the method, it had quite a few
      branches going on:
      
          def create_or_update_import_data(data: nil, credentials: nil)
            return if data.nil? && credentials.nil?
      
            project_import_data = import_data || build_import_data
      
            if data
              project_import_data.data ||= {}
              project_import_data.data = project_import_data.data.merge(data)
            end
      
            if credentials
              project_import_data.credentials ||= {}
              project_import_data.credentials =
                project_import_data.credentials.merge(credentials)
            end
      
            project_import_data
          end
      
      If we turn the || and ||= operators into regular if statements, we can
      see a bit more clearly that this method has quite a lot of branches in
      it:
      
          def create_or_update_import_data(data: nil, credentials: nil)
            if data.nil? && credentials.nil?
              return
            else
              project_import_data =
                if import_data
                  import_data
                else
                  build_import_data
                end
      
              if data
                if project_import_data.data
                  # nothing
                else
                  project_import_data.data = {}
                end
      
                project_import_data.data =
                  project_import_data.data.merge(data)
              end
      
              if credentials
                if project_import_data.credentials
                  # nothing
                else
                  project_import_data.credentials = {}
                end
      
                project_import_data.credentials =
                  project_import_data.credentials.merge(credentials)
              end
      
              project_import_data
            end
          end
      
      The number of if statements and branches here makes it easy to make
      mistakes. To resolve this, we refactor this code in such a way that we
      can get rid of all but the first `if data.nil? && credentials.nil?`
      statement. We can do this by simply sending `to_h` to `nil` in the right
      places, which removes the need for statements such as `if data`.
      
      Since this data gets written to a database, in ProjectImportData we do
      make sure to not write empty Hash values. This requires an `unless`
      (which is really a `if !`), but the resulting code is still very easy to
      read.
      26378511
  4. 07 Dec, 2018 2 commits
    • Zeger-Jan van de Weg's avatar
      Allow public forks to be deduplicated · 896c0bdb
      Zeger-Jan van de Weg authored
      When a project is forked, the new repository used to be a deep copy of everything
      stored on disk by leveraging `git clone`. This works well, and makes isolation
      between repository easy. However, the clone is at the start 100% the same as the
      origin repository. And in the case of the objects in the object directory, this
      is almost always going to be a lot of duplication.
      
      Object Pools are a way to create a third repository that essentially only exists
      for its 'objects' subdirectory. This third repository's object directory will be
      set as alternate location for objects. This means that in the case an object is
      missing in the local repository, git will look in another location. This other
      location is the object pool repository.
      
      When Git performs garbage collection, it's smart enough to check the
      alternate location. When objects are duplicated, it will allow git to
      throw one copy away. This copy is on the local repository, where to pool
      remains as is.
      
      These pools have an origin location, which for now will always be a
      repository that itself is not a fork. When the root of a fork network is
      forked by a user, the fork still clones the full repository. Async, the
      pool repository will be created.
      
      Either one of these processes can be done earlier than the other. To
      handle this race condition, the Join ObjectPool operation is
      idempotent. Given its idempotent, we can schedule it twice, with the
      same effect.
      
      To accommodate the holding of state two migrations have been added.
      1. Added a state column to the pool_repositories column. This column is
      managed by the state machine, allowing for hooks on transitions.
      2. pool_repositories now has a source_project_id. This column in
      convenient to have for multiple reasons: it has a unique index allowing
      the database to handle race conditions when creating a new record. Also,
      it's nice to know who the host is. As that's a short link to the fork
      networks root.
      
      Object pools are only available for public project, which use hashed
      storage and when forking from the root of the fork network. (That is,
      the project being forked from itself isn't a fork)
      
      In this commit message I use both ObjectPool and Pool repositories,
      which are alike, but different from each other. ObjectPool refers to
      whatever is on the disk stored and managed by Gitaly. PoolRepository is
      the record in the database.
      896c0bdb
    • Steve Azzopardi's avatar
      Add endpoint to download single artifact by ref · 401f65c4
      Steve Azzopardi authored
      Add a new endpoint
      `projects/:id/jobs/artifacts/:ref_name/raw/*artifact_path?job=name`
      which is the close the web URL for consistency sake. This endpoint can
      be used to download a single file from artifacts for the specified ref
      and job.
      
      closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54626
      401f65c4
  5. 06 Dec, 2018 2 commits
  6. 05 Dec, 2018 3 commits
  7. 04 Dec, 2018 5 commits
    • Thong Kuah's avatar
      Unify into :group_clusters feature flag · ebf87fd9
      Thong Kuah authored
      With this MR, group clusters is now functional, so default to enabled.
      
      Have a single setting on the root ancestor group to enabled or disable
      group clusters feature as a whole
      ebf87fd9
    • Thong Kuah's avatar
      Various improvements to hierarchy sorting · f85440e6
      Thong Kuah authored
      - Rename ordered_group_clusters_for_project ->
      ancestor_clusters_for_clusterable
      - Improve name of order option. It makes much more sense to have `hierarchy_order: :asc`
      and `hierarchy_order: :desc`
      - Allow ancestor_clusters_for_clusterable for group
      - Re-use code already present in Project
      f85440e6
    • Thong Kuah's avatar
      Create k8s namespace for project in group clusters · d54791e0
      Thong Kuah authored
      AFAIK the only relevant place is Projects::CreateService, this gets
      called when user creates a new project, forks a new project and does
      those things via the api.
      
      Also create k8s namespace for new group hierarchy
      when transferring project between groups
      
      Uses new Refresh service to create k8s namespaces
      
      - Ensure we use Cluster#cluster_project
      
      If a project has multiple clusters (EE), using Project#cluster_project
      is not guaranteed to return the cluster_project for this cluster. So
      switch to using Cluster#cluster_project - at this stage a cluster can
      only have 1 cluster_project.
      
      Also, remove rescue so that sidekiq can retry
      d54791e0
    • Thong Kuah's avatar
      Teach Project about #all_clusters · 9c5977c8
      Thong Kuah authored
      This returns a union of the project level clusters and group level
      clusters associated with this project.
      9c5977c8
    • Thong Kuah's avatar
      Add association project -> kubernetes_namespaces · 703233e1
      Thong Kuah authored
      kubernetes_namespaces is not needed for project import/export as it
      tracks internal state of kubernetes integration
      703233e1
  8. 03 Dec, 2018 1 commit
  9. 29 Nov, 2018 1 commit
  10. 28 Nov, 2018 1 commit
  11. 27 Nov, 2018 1 commit
  12. 26 Nov, 2018 2 commits
  13. 16 Nov, 2018 1 commit
  14. 15 Nov, 2018 2 commits
  15. 07 Nov, 2018 2 commits
    • Shinya Maeda's avatar
      Revert add action column changes · 9c811566
      Shinya Maeda authored
      9c811566
    • Shinya Maeda's avatar
      Squashed commit of the following: · 060c5687
      Shinya Maeda authored
      commit 5aa6032526c7270b8793f62b9a5e66c0ce79c3b9
      Merge: cfb05ed27a3 1cf4aa02
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 22:07:12 2018 +0900
      
          Merge branch 'master-ce' into fix-environment-status-in-merge-request-widget
      
      commit cfb05ed27a37f815721372731882af8c6a6efd54
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 20:59:15 2018 +0900
      
          Add proxy status for frontend
      
      commit e6b3d65c53d97285b4f1575146b44a540e3fc4bf
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 20:47:23 2018 +0900
      
          Prevent nil exception in environment status
      
      commit 23d4e37ebd83615326e749cce43178208e5ff76c
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 18:36:06 2018 +0900
      
          Fix typo in spec
      
      commit 963b0fcedeaf22b949d9f3cef4b662146c9c003d
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 18:22:20 2018 +0900
      
          Add feature spec
      
      commit 9cff0225cc8da1b787207b06858ef6a63ad7513f
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 17:19:55 2018 +0900
      
          Fix 19 environments fixtures
      
      commit 7c8eaf7b1fc95fea4f0ae4cf21d291ce7009fb05
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 16:18:08 2018 +0900
      
          Remove spec for first_deployment_for
      
      commit d42cc1e0894a8132a4c543f7ff133e37a4670a2b
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 16:16:52 2018 +0900
      
          Fix 14_pipelines fixture
      
      commit ef12bdcb4e82f8347f6b8ced253e98c804f3ad4f
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 15:31:38 2018 +0900
      
          Save environment object in Start Environment Service
      
      commit 55e12a55b86a783f9d470573288f3a94d8bb0a88
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 14:49:55 2018 +0900
      
          Fix spec and add spec for deployed? and stopped?
      
      commit 64d9527e824e5a7af60db05881f095c24f0c60c9
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 14:26:36 2018 +0900
      
          Fix flaky spec
      
      commit 4c623409d8b53ec8904d790f5137adc8a0ce1f2e
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 14:21:46 2018 +0900
      
          Optimize queries
      
      commit 4ab4364e868927873fb39a406a9d74f7c89761c6
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 13:44:08 2018 +0900
      
          Dry up the implementation
      
      commit 53ba2f8a54bd78b0cad03b7f83fdf0837ccb1d74
      Merge: 3aa2fe502ee 65a7a6e5
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 13:39:15 2018 +0900
      
          Merge branch 'stateful_deployments' into fix-environment-status-in-merge-request-widget
      
      commit 3aa2fe502eee00e42894e4bac13f50a76c67e816
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 13:25:56 2018 +0900
      
          Create scope for deployed and stopped
      
      commit 3a9c59a6ee1a2e225b916b9485851d50163f5fae
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 12:55:44 2018 +0900
      
          Add spec for stop environmet service
      
      commit 1a982dda6939debeb994aff799a86c9f480d977d
      Merge: f716f4ff670 56226498
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 11:47:11 2018 +0900
      
          Merge branch 'stateful_deployments' into fix-environment-status-in-merge-request-widget
      
      commit f716f4ff6705aae279b07c6c93d4dafd6ce925e6
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 11:44:26 2018 +0900
      
          Define environmet services explicitly
      
      commit 774d236f3851731f8650534a5ce19a950274497c
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 11:10:23 2018 +0900
      
          Fix conflicts
      
      commit 320544b042c08e9e2f190d95ab5d988c37b3b7e7
      Merge: 826fc250814 5f47ebaa
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 6 11:07:06 2018 +0900
      
          Merge branch 'stateful_deployments' into fix-environment-status-in-merge-request-widget
      
      commit 826fc25081489ea646ddcdc626fc7cd120ed39a2
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 22:44:59 2018 +0900
      
          Fix typo
      
      commit dd21e9a21fffcce6b1ffcb2ff389bb8f018bbd33
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 22:35:12 2018 +0900
      
          Add spec
      
      commit f131e3bc36b995b70befc7556b2aa5ca287e3313
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 20:09:59 2018 +0900
      
          Update changelog
      
      commit a2f93fcc40e6ad4c0aa54a3e597869e594cab730
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 20:01:12 2018 +0900
      
          Fix fork project problem in first_deployment_for
      
      commit aa778934069559eaf10d8fa2c107d0b7550e6ff6
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 19:06:46 2018 +0900
      
          Remove unnecessary changes
      
      commit 93c4b58e4d78558ff02ef09be1214683343c505b
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 15:56:26 2018 +0900
      
          Efficient way to search deployment
      
      commit 99653d025ea431f00c6fa09cbf0b91f39f9f6e34
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 15:23:41 2018 +0900
      
          Fix environment status
      
      commit 5dda167e394a008008d2829763adea0c1488b850
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 10:09:49 2018 +0900
      
          Add tests for action column
      
      commit 52f7b09127d19f956c289c72d15ca8ab817b8d70
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 10:05:05 2018 +0900
      
          Fix conflicts
      
      commit c63626c3b5ec1aecb45f7766cb6438e9c6229a0c
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 10:03:56 2018 +0900
      
          Fix unnecessary changes
      
      commit 8077e1237a56befdfb3211165b7ef888e00f9712
      Merge: 06946cbec9e d1b59cf6fb0
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 10:01:51 2018 +0900
      
          Merge branch 'stateful_deployments' into add-action-to-deployment
      
      commit d1b59cf6fb089d954334ce28a61c122846cea491
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 09:37:40 2018 +0900
      
          Squashed commit of the following:
      
          commit 931d6ab0e025b0268d94e455f736b09a025e0578
          Merge: b34d165320d 93846eb1
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Nov 5 09:36:58 2018 +0900
      
              Merge branch 'master-ce' into stateful_deployments
      
          commit b34d165320d6f3298c8b776ba66270a59c217412
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 18:07:08 2018 +0900
      
              Fix flaky spec
      
          commit b5e0527c5d4fe8f18b2fdda5916bae9b8cd859a4
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 15:32:03 2018 +0900
      
              Fix spec
      
          commit f78a5e96e66fe2d25086df495e339b470a274df8
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 14:59:29 2018 +0900
      
              Remove unnecessary line in schema.rb
      
          commit 6ce7c483e0591b5d6f9588a99853834327b80031
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 14:55:48 2018 +0900
      
              Add partial index for filling deployment at migration
      
          commit aecccfb5118c8982db3ba502fdf37b5e639fbfc6
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 14:42:24 2018 +0900
      
              Fix fill empty finished at migration
      
          commit 0199e1761ad1b391ae87a53a9a113d3256529e0e
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 14:19:44 2018 +0900
      
              Fix flaky spec
      
          commit 56ac84cd8095afab5b909119445537b7da06a2ff
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Nov 2 10:06:49 2018 +0900
      
              Fix guard clause to prevent multiple deployments to a job
      
          commit 521561b6b303b54635c30cb23d78e49d14cec53d
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 20:19:24 2018 +0900
      
              Fix spec
      
          commit 2878da0d29b9bd2dde69a1b216203df118dd59a1
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 19:38:59 2018 +0900
      
              Simplify the factory
      
          commit 22fd7df02133f3a21828554965fd5619905eac2c
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 19:33:50 2018 +0900
      
              Simplify the Deployable and BuildSuccessWorker
      
          commit 41108959677ed614f4548443a2f4303c4c04925a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 18:34:20 2018 +0900
      
              Fix spec
      
          commit ae75fe7461ac72f621498797f478d42331342b84
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 17:19:12 2018 +0900
      
              Fix weird virtual deployment status
      
          commit 380fee7494d06407dccc292c3cbedbcee7b6e235
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 15:59:31 2018 +0900
      
              Fix spec
      
          commit 29889fcbaadb3bbfd2f11c10bfbf5dceb3e3ddba
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 15:07:10 2018 +0900
      
              Fix coding offence
      
          commit 36ac13f345f5ef25725c2236a791a40a3a9e6126
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 14:22:17 2018 +0900
      
              Squashed commit of the following:
      
              commit ba9aede922e1643db3f06c56736d46d6d86d356b
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Nov 1 14:21:33 2018 +0900
      
                  Fix ambiguious factory specification in update deployment service spec
      
              commit 013afb5668cb30dc4ca5b21945c17b341e7ea7f9
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Nov 1 14:10:24 2018 +0900
      
                  Fix spec
      
              commit 78793670d049e2dfb5fc98177eb4d10f20b9310b
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 31 18:26:12 2018 +0900
      
                  Fix spec
      
              commit 73d27e87c66698f2e3a817bb8728f02475b7ba4f
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 31 16:22:14 2018 +0900
      
                  Fix index
      
              commit 8580a226ea68bf5e49b35bfb5f404968bbfaf8e9
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 31 15:34:57 2018 +0900
      
                  Fix deployment relationships in Ci::Build
      
              commit d6d28b55afd1179200b4f5188e0b53079ff3c1a7
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 31 15:27:53 2018 +0900
      
                  Fix spec
      
              commit 94eb754e2e1bb9a1fe627f86823f571a8298d27b
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 31 14:07:11 2018 +0900
      
                  Fix spec
      
              commit 0b30f80bcd08a7a06bdde3378ec1733f865284be
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 20:15:31 2018 +0900
      
                  Fix spec
      
              commit 466bdcdb6af8cdb475c9fa16bd7d1dff23b11e40
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 19:28:51 2018 +0900
      
                  Fix spec
      
              commit a7c3caac99139e70fe3f1f3d14856939fa25c527
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 17:33:47 2018 +0900
      
                  Fix factory
      
              commit cea28ae100532e6711ce1d22676719a94e2da8a0
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 16:28:18 2018 +0900
      
                  Drop leagacy success
      
              commit 3785d685eabc10b6597cf3db67bf08385ccf298a
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 15:37:28 2018 +0900
      
                  Remove unnecessary migration file
      
              commit 0d597fa46eeffdbb9a4afb53005a8183e433c6bf
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 15:35:53 2018 +0900
      
                  Fix schema.rb
      
              commit ec3c2abc6944e09f6410468ae5e356865ec7b02b
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 15:34:21 2018 +0900
      
                  Rename post migration file
      
              commit 0e7281885a84656acf95f0f423732680f8fec076
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 15:31:01 2018 +0900
      
                  Remove include EnumWithNil
      
              commit b3846d59c07e07275126c70361bde7f30810729e
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 15:05:50 2018 +0900
      
                  Decouple action
      
              commit c9f9ba4eae9ca1edc7d8751e1d2e0572cb222d9c
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 14:23:29 2018 +0900
      
                  Remove status mock
      
              commit d95bfea1ca67b3a27a3226a669c2b1266d696682
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 14:17:14 2018 +0900
      
                  Add action
      
              commit 0cec39e0f76c22a18498f46d65ad7226fb30c3f8
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 30 13:44:07 2018 +0900
      
                  Remove unnecessary line in schema.rb
      
              commit 7b4c5f8e1b00dd8e6aa944352f9d8a9f3ae6f1c7
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 29 19:59:41 2018 +0900
      
                  Revert build success worker
      
              commit 0c52ffa4a23eea488c187317e8b400369846f399
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 29 19:11:47 2018 +0900
      
                  Use add_column_with_default properly
      
              commit ba9bae357da5dfd2f6ec05f7f9db9d0b31224f48
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 29 18:40:55 2018 +0900
      
                  Fix with_status
      
              commit 75dffc97b9c5f6fa73d9d09b125c8f849fa2caae
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 29 16:26:56 2018 +0900
      
                  Remove unnecessary line in schema.rb
      
              commit 25188ccc52fb29ca63b9205c4d95ffc2e0afadee
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 29 16:26:17 2018 +0900
      
                  Set default values in regular migration
      
              commit 98ea037fbf39c8d9f0db77fb50e2d08382425158
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 17:27:49 2018 +0900
      
                  Fix static analysis
      
              commit e7d1765f77f9ff9b94a34985a7855bdaab1da675
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 16:37:10 2018 +0900
      
                  Remove empty spec
      
              commit 0033f521ed1eae8117dba231961aa47c068bbcfb
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 16:34:55 2018 +0900
      
                  Simplify spec changes
      
              commit 0be4c6b3ade6d9a8bf28bcd177c66ebd7bb7d20a
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 16:32:45 2018 +0900
      
                  Simplify spec changes
      
              commit a93d25d79df7e25bdf688fc938c712922f9dc4df
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 16:02:31 2018 +0900
      
                  Fix flaky spec
      
              commit 339ad50cf471ca706b29f008ccd2bb881dd5b776
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 15:06:22 2018 +0900
      
                  Rename Deployments Success worker
      
              commit bd69c78085adcb9b0f8ff9b7041ae355953ad7ab
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 26 14:43:03 2018 +0900
      
                  Fix coding offence
      
              commit 004748b2a9c5236ec13eb01289418f3d6571c92c
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 20:09:10 2018 +0900
      
                  Rename to update deployment service
      
              commit b04a85e761de501f030f3844fd485a2b9e46f7f7
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 18:46:52 2018 +0900
      
                  Add spec for Project
      
              commit 548af23a5a07f0c20b72849d03aa0b98a0b49134
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 18:43:25 2018 +0900
      
                  Fix spec
      
              commit c977e4d3f17194c46a1bf857b473017ce21ef7e9
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 17:58:07 2018 +0900
      
                  Add spec for Environment
      
              commit 73feb9010f8d8093bee4b46e56d30cfef3e8e34a
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 17:39:24 2018 +0900
      
                  Add spec for Deployment model
      
              commit 9a3cfbf766f402571588839375cf311bb9807035
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 17:18:02 2018 +0900
      
                  Fix statis analysis
      
              commit a30d28dbc631a29855883ca89c592a10c012f1d2
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 17:17:32 2018 +0900
      
                  Ignore nil instance
      
              commit fa6fdd89f380e588a6bcf14b1f9aef0d14d3854b
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 16:20:40 2018 +0900
      
                  Add spec for deployable concern
      
              commit aa91186821dc671df2c7a641e37586dd5dfc1008
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 15:37:23 2018 +0900
      
                  Clean up deployable
      
              commit 34d3e18731f7906a3db250b105a64d1db83c2fca
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 15:13:05 2018 +0900
      
                  Fix 17 cycle analytics
      
              commit 8dc9e00408f9b390175e7d5ea743eed4fb9e3f79
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 25 13:56:51 2018 +0900
      
                  Fix static analysys
      
              commit 5c4175807a537bafc4b889b0a97e8f96f0e483cd
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 24 15:05:05 2018 +0900
      
                  Skip unnecessary sidekiq worker
      
              commit 9d8b5d423f49cc247c96ce3767d03b4af305809f
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 24 14:53:13 2018 +0900
      
                  Add changelog
      
              commit c8cabba496722240cadf7c161c80bceb09727cba
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 24 14:44:45 2018 +0900
      
                  Squashed commit of the following:
      
                  commit f7643885ac2329e18d690a4e4f2d7614b732c793
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 19:38:45 2018 +0900
      
                      Fix deployment widget specs
      
                  commit 03bd04b5c98b634dff6a0ab4292c150a9031995c
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 17:50:16 2018 +0900
      
                      Fix env status spec
      
                  commit 4a49c6502b161a12f0f62d5ec167dff777047dab
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 17:48:59 2018 +0900
      
                      Fix environment spec
      
                  commit 4044822887987e20a703990ff20352a532eeb965
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 17:47:17 2018 +0900
      
                      Fix environment spec
      
                  commit 9939d44b7eb9da371de74c0f04fed1eb3db37ad3
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 15:45:43 2018 +0900
      
                      Add a new spec for deployment success worker
      
                  commit f61c4d3657b5ef13b5da171460da68a6643ad4b5
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 15:38:11 2018 +0900
      
                      Fix cycle analytics helper
      
                  commit b6242615e8298fb7fc047c8df8006c25ad717c70
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 14:41:54 2018 +0900
      
                      Fix cycle analysis helper
      
                  commit 9a001cb4c4ed6f3b87dc612bdffc60a6b2b0a132
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 14:37:08 2018 +0900
      
                      Ignore coding offence in build success worker's spec
      
                  commit 1fb88583025bac8a56172cbd59be04258ea4c5f3
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 23 14:33:11 2018 +0900
      
                      Added more spec for deployments
      
                  commit 1a6ba97ababbf62e8dd0ae0c56d75ab1268fd0ce
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 19:36:50 2018 +0900
      
                      Move after create hookd into success worker
      
                  commit 09de5fed5d6f108423779cf9d9e7f1d21f3c1c91
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 19:30:06 2018 +0900
      
                      Fix build spec
      
                  commit 73a55cbcabbb1e928eca3e53e8ff75dec178bc90
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 19:08:43 2018 +0900
      
                      Fix update_deployment_metrics_service_spec.rb
      
                  commit ee05136a02ae9fa348b4b89b9a69937ebb9697dd
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 17:32:05 2018 +0900
      
                      Remove unnecessary degelate
      
                  commit e246ddeebc01a807ccc36fdb484c3e72ad91e680
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 16:07:39 2018 +0900
      
                      Remove unnecessary optimistic locking
      
                  commit dcc225c8237b90e3bc8dcc3dc2e3252e0b0be093
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 16:00:22 2018 +0900
      
                      Simplify status replication
      
                  commit 13a5fd7afb67ba2712fcaecaea5fedf05f9ad177
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 15:29:24 2018 +0900
      
                      Fix sidekiq queue names
      
                  commit dcc796f48d523538e1c91b9cd3e1c7065e5329b1
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 15:23:55 2018 +0900
      
                      Revert success check in update_merge_request_metrics
      
                  commit 129ef083d637d4acb8c97a6d9ab96deb2ff6efcd
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 15:18:31 2018 +0900
      
                      Fix queue name of deployment success worker
      
                  commit 10fe5a6484f4f02322ce5bb16844fc7b1d565963
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 15:09:42 2018 +0900
      
                      Introduce deployable module
      
                  commit d91260bbe105bf46f6c06d9e9593c8c4cd5139cf
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 14:05:31 2018 +0900
      
                      Add database index for successful deployments
      
                  commit 74274147263de4b60870065a19935498ce662e30
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Mon Oct 22 13:51:59 2018 +0900
      
                      Fix invalid state transition
      
                  commit ff18463cc847bf3cf5a3e49f3651eedfdf67c7e6
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Fri Oct 19 20:05:15 2018 +0900
      
                      Fix coding style offence
      
                  commit 0202c0f5b631601edab7b359b087b307f5eb7ba3
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Fri Oct 19 18:34:07 2018 +0900
      
                      Target only successful deployments from other relations
      
                  commit 1f2758cb030dec1df5dda30f6bc3e25b6d0841c9
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Fri Oct 19 18:21:28 2018 +0900
      
                      Add namespace explicitly
      
                  commit 3d9227b6e5642cecde88d4edac925125f6474b11
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Fri Oct 19 17:42:30 2018 +0900
      
                      Fix spec in DeleteInconsistentInternalIdRecords
      
                  commit 3e0cc99ff6c5c7188511618228a6ec027752ce69
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Fri Oct 19 16:10:16 2018 +0900
      
                      Fixed spec
      
                  commit 8de09b8bb31f7b9f24ecdf9f2dd8ef358a260263
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Fri Oct 19 14:22:35 2018 +0900
      
                      Fix create deployment service
      
                  commit 31957570b4444492eeb412e765f96a56416c25f3
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Thu Oct 18 20:21:26 2018 +0900
      
                      Move CreateDeploymentService. Fix Cycle analytics spec and fixture.
      
                  commit d2eb433a1bb9710c0d4778c4f34c12b6b64f60e6
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Thu Oct 18 20:11:22 2018 +0900
      
                      Fix build success worker
      
                  commit 25e6cd87138bcdb69de8785ca367e479c8dbcc59
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Thu Oct 18 19:49:13 2018 +0900
      
                      Fix create deployment service spec
      
                  commit d268bf410bf65e86c81eb76d50aa8e145b32d249
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Thu Oct 18 19:01:23 2018 +0900
      
                      Fix cycle analysys spec's deployment
      
                  commit 525ade8aa1e4394ed8a759bb0437e407fbe74a35
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Thu Oct 18 18:24:04 2018 +0900
      
                      Fix factory to set legacy status by default
      
                  commit c6a990821ac0a1ffa49e20e2d78d94b8ce075914
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Thu Oct 18 17:25:40 2018 +0900
      
                      Remove unnecessary lib from deployment
      
                  commit a6107e0e85ac26ee09da3316ebc11de32f067d82
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Wed Oct 17 17:38:58 2018 +0900
      
                      Fix recursive call
      
                  commit 15c5f3b64061a75af3c3039ca7f49b1cc4ff3068
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Wed Oct 17 17:30:44 2018 +0900
      
                      Add finished_at
      
                  commit c8d3d70366f694d78acb7e30d342c7697798b922
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Wed Oct 17 15:55:31 2018 +0900
      
                      Fix last_deployment methods as it used to return successful deployment always
      
                  commit 96bbe8670cece021766fde95fe573cbbe23d1e55
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Wed Oct 17 15:49:57 2018 +0900
      
                      Redefine statuses
      
                  commit c86a9d0bd2ab3e7a00bf61f094a96ee99b76b289
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Wed Oct 17 14:50:27 2018 +0900
      
                      Fix schema.rb
      
                  commit 9ff5f0eaafbc08795018c7bb282b19f6327dee21
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Wed Oct 17 14:18:04 2018 +0900
      
                      Default status nil to success
      
                  commit 5928bd9bb94e1e8908ed1561e01595be84d5f4ec
                  Author: Shinya Maeda <shinya@gitlab.com>
                  Date:   Tue Oct 16 15:13:48 2018 +0900
      
                      Add status to Deployment
      
      commit 06946cbec9e76398cdf2c590fd13e3f71c04595f
      Merge: 1ac4a7fed37 20b59da2ea3
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 10:14:22 2018 +0900
      
          Merge branch 'stateful_deployments' into add-action-to-deployment
      
      commit 20b59da2ea3ae850e8b2e823013536c2c7275156
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 10:06:49 2018 +0900
      
          Fix guard clause to prevent multiple deployments to a job
      
      commit 1ac4a7fed376ba8dd1e692af0e197d55cc1cb900
      Merge: 34bd4866c16 7aade362361
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 20:21:25 2018 +0900
      
          Merge branch 'stateful_deployments' into add-action-to-deployment
      
      commit 7aade362361af7eedf1db50dc46369187fce21cc
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 20:19:24 2018 +0900
      
          Fix spec
      
      commit 90d05b1c0cb09658f02739ad8a53ef74238aa8cf
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 19:38:59 2018 +0900
      
          Simplify the factory
      
      commit 1fbdd07c48821ea8a138932dd3c401eb85ae5ca3
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 19:33:50 2018 +0900
      
          Simplify the Deployable and BuildSuccessWorker
      
      commit 519765699b90dd92ddef6d1f5cde5123c7d4b473
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 18:34:20 2018 +0900
      
          Fix spec
      
      commit e88f464d275e743af590b4dac6f8a636023ed9b7
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 17:19:12 2018 +0900
      
          Fix weird virtual deployment status
      
      commit 2f493a948bdedc54d8d06e802090795a146b7085
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:59:31 2018 +0900
      
          Fix spec
      
      commit 34bd4866c161bc02333b0e9e7a710110885e8bd0
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:34:10 2018 +0900
      
          Revert unnecessary changes
      
      commit bbdc18d4e697d953f4f3320815eae2767049a922
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:32:27 2018 +0900
      
          Simplify the implementation
      
      commit 3bd7996919613adbe517c633e30f4f06555df7dc
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:27:11 2018 +0900
      
          Add changelog
      
      commit 210631ac3ecc01361238a1ff296949da36ea4773
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:22:44 2018 +0900
      
          Add action to deployment
      
      commit 9bd4b2e8b1b86dda98b8cad6886a8075f75f28d4
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:07:10 2018 +0900
      
          Fix coding offence
      
      commit c5c6871699f880689621d776564b8e0bb7729eda
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 14:22:17 2018 +0900
      
          Squashed commit of the following:
      
          commit ba9aede922e1643db3f06c56736d46d6d86d356b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 14:21:33 2018 +0900
      
              Fix ambiguious factory specification in update deployment service spec
      
          commit 013afb5668cb30dc4ca5b21945c17b341e7ea7f9
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 14:10:24 2018 +0900
      
              Fix spec
      
          commit 78793670d049e2dfb5fc98177eb4d10f20b9310b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 18:26:12 2018 +0900
      
              Fix spec
      
          commit 73d27e87c66698f2e3a817bb8728f02475b7ba4f
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 16:22:14 2018 +0900
      
              Fix index
      
          commit 8580a226ea68bf5e49b35bfb5f404968bbfaf8e9
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 15:34:57 2018 +0900
      
              Fix deployment relationships in Ci::Build
      
          commit d6d28b55afd1179200b4f5188e0b53079ff3c1a7
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 15:27:53 2018 +0900
      
              Fix spec
      
          commit 94eb754e2e1bb9a1fe627f86823f571a8298d27b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 14:07:11 2018 +0900
      
              Fix spec
      
          commit 0b30f80bcd08a7a06bdde3378ec1733f865284be
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 20:15:31 2018 +0900
      
              Fix spec
      
          commit 466bdcdb6af8cdb475c9fa16bd7d1dff23b11e40
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 19:28:51 2018 +0900
      
              Fix spec
      
          commit a7c3caac99139e70fe3f1f3d14856939fa25c527
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 17:33:47 2018 +0900
      
              Fix factory
      
          commit cea28ae100532e6711ce1d22676719a94e2da8a0
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 16:28:18 2018 +0900
      
              Drop leagacy success
      
          commit 3785d685eabc10b6597cf3db67bf08385ccf298a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:37:28 2018 +0900
      
              Remove unnecessary migration file
      
          commit 0d597fa46eeffdbb9a4afb53005a8183e433c6bf
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:35:53 2018 +0900
      
              Fix schema.rb
      
          commit ec3c2abc6944e09f6410468ae5e356865ec7b02b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:34:21 2018 +0900
      
              Rename post migration file
      
          commit 0e7281885a84656acf95f0f423732680f8fec076
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:31:01 2018 +0900
      
              Remove include EnumWithNil
      
          commit b3846d59c07e07275126c70361bde7f30810729e
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:05:50 2018 +0900
      
              Decouple action
      
          commit c9f9ba4eae9ca1edc7d8751e1d2e0572cb222d9c
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 14:23:29 2018 +0900
      
              Remove status mock
      
          commit d95bfea1ca67b3a27a3226a669c2b1266d696682
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 14:17:14 2018 +0900
      
              Add action
      
          commit 0cec39e0f76c22a18498f46d65ad7226fb30c3f8
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 13:44:07 2018 +0900
      
              Remove unnecessary line in schema.rb
      
          commit 7b4c5f8e1b00dd8e6aa944352f9d8a9f3ae6f1c7
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 19:59:41 2018 +0900
      
              Revert build success worker
      
          commit 0c52ffa4a23eea488c187317e8b400369846f399
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 19:11:47 2018 +0900
      
              Use add_column_with_default properly
      
          commit ba9bae357da5dfd2f6ec05f7f9db9d0b31224f48
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 18:40:55 2018 +0900
      
              Fix with_status
      
          commit 75dffc97b9c5f6fa73d9d09b125c8f849fa2caae
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 16:26:56 2018 +0900
      
              Remove unnecessary line in schema.rb
      
          commit 25188ccc52fb29ca63b9205c4d95ffc2e0afadee
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 16:26:17 2018 +0900
      
              Set default values in regular migration
      
          commit 98ea037fbf39c8d9f0db77fb50e2d08382425158
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 17:27:49 2018 +0900
      
              Fix static analysis
      
          commit e7d1765f77f9ff9b94a34985a7855bdaab1da675
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:37:10 2018 +0900
      
              Remove empty spec
      
          commit 0033f521ed1eae8117dba231961aa47c068bbcfb
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:34:55 2018 +0900
      
              Simplify spec changes
      
          commit 0be4c6b3ade6d9a8bf28bcd177c66ebd7bb7d20a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:32:45 2018 +0900
      
              Simplify spec changes
      
          commit a93d25d79df7e25bdf688fc938c712922f9dc4df
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:02:31 2018 +0900
      
              Fix flaky spec
      
          commit 339ad50cf471ca706b29f008ccd2bb881dd5b776
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 15:06:22 2018 +0900
      
              Rename Deployments Success worker
      
          commit bd69c78085adcb9b0f8ff9b7041ae355953ad7ab
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 14:43:03 2018 +0900
      
              Fix coding offence
      
          commit 004748b2a9c5236ec13eb01289418f3d6571c92c
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 20:09:10 2018 +0900
      
              Rename to update deployment service
      
          commit b04a85e761de501f030f3844fd485a2b9e46f7f7
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 18:46:52 2018 +0900
      
              Add spec for Project
      
          commit 548af23a5a07f0c20b72849d03aa0b98a0b49134
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 18:43:25 2018 +0900
      
              Fix spec
      
          commit c977e4d3f17194c46a1bf857b473017ce21ef7e9
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:58:07 2018 +0900
      
              Add spec for Environment
      
          commit 73feb9010f8d8093bee4b46e56d30cfef3e8e34a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:39:24 2018 +0900
      
              Add spec for Deployment model
      
          commit 9a3cfbf766f402571588839375cf311bb9807035
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:18:02 2018 +0900
      
              Fix statis analysis
      
          commit a30d28dbc631a29855883ca89c592a10c012f1d2
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:17:32 2018 +0900
      
              Ignore nil instance
      
          commit fa6fdd89f380e588a6bcf14b1f9aef0d14d3854b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 16:20:40 2018 +0900
      
              Add spec for deployable concern
      
          commit aa91186821dc671df2c7a641e37586dd5dfc1008
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 15:37:23 2018 +0900
      
              Clean up deployable
      
          commit 34d3e18731f7906a3db250b105a64d1db83c2fca
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 15:13:05 2018 +0900
      
              Fix 17 cycle analytics
      
          commit 8dc9e00408f9b390175e7d5ea743eed4fb9e3f79
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 13:56:51 2018 +0900
      
              Fix static analysys
      
          commit 5c4175807a537bafc4b889b0a97e8f96f0e483cd
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 24 15:05:05 2018 +0900
      
              Skip unnecessary sidekiq worker
      
          commit 9d8b5d423f49cc247c96ce3767d03b4af305809f
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 24 14:53:13 2018 +0900
      
              Add changelog
      
          commit c8cabba496722240cadf7c161c80bceb09727cba
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 24 14:44:45 2018 +0900
      
              Squashed commit of the following:
      
              commit f7643885ac2329e18d690a4e4f2d7614b732c793
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 19:38:45 2018 +0900
      
                  Fix deployment widget specs
      
              commit 03bd04b5c98b634dff6a0ab4292c150a9031995c
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 17:50:16 2018 +0900
      
                  Fix env status spec
      
              commit 4a49c6502b161a12f0f62d5ec167dff777047dab
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 17:48:59 2018 +0900
      
                  Fix environment spec
      
              commit 4044822887987e20a703990ff20352a532eeb965
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 17:47:17 2018 +0900
      
                  Fix environment spec
      
              commit 9939d44b7eb9da371de74c0f04fed1eb3db37ad3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 15:45:43 2018 +0900
      
                  Add a new spec for deployment success worker
      
              commit f61c4d3657b5ef13b5da171460da68a6643ad4b5
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 15:38:11 2018 +0900
      
                  Fix cycle analytics helper
      
              commit b6242615e8298fb7fc047c8df8006c25ad717c70
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 14:41:54 2018 +0900
      
                  Fix cycle analysis helper
      
              commit 9a001cb4c4ed6f3b87dc612bdffc60a6b2b0a132
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 14:37:08 2018 +0900
      
                  Ignore coding offence in build success worker's spec
      
              commit 1fb88583025bac8a56172cbd59be04258ea4c5f3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 14:33:11 2018 +0900
      
                  Added more spec for deployments
      
              commit 1a6ba97ababbf62e8dd0ae0c56d75ab1268fd0ce
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 19:36:50 2018 +0900
      
                  Move after create hookd into success worker
      
              commit 09de5fed5d6f108423779cf9d9e7f1d21f3c1c91
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 19:30:06 2018 +0900
      
                  Fix build spec
      
              commit 73a55cbcabbb1e928eca3e53e8ff75dec178bc90
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 19:08:43 2018 +0900
      
                  Fix update_deployment_metrics_service_spec.rb
      
              commit ee05136a02ae9fa348b4b89b9a69937ebb9697dd
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 17:32:05 2018 +0900
      
                  Remove unnecessary degelate
      
              commit e246ddeebc01a807ccc36fdb484c3e72ad91e680
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 16:07:39 2018 +0900
      
                  Remove unnecessary optimistic locking
      
              commit dcc225c8237b90e3bc8dcc3dc2e3252e0b0be093
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 16:00:22 2018 +0900
      
                  Simplify status replication
      
              commit 13a5fd7afb67ba2712fcaecaea5fedf05f9ad177
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:29:24 2018 +0900
      
                  Fix sidekiq queue names
      
              commit dcc796f48d523538e1c91b9cd3e1c7065e5329b1
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:23:55 2018 +0900
      
                  Revert success check in update_merge_request_metrics
      
              commit 129ef083d637d4acb8c97a6d9ab96deb2ff6efcd
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:18:31 2018 +0900
      
                  Fix queue name of deployment success worker
      
              commit 10fe5a6484f4f02322ce5bb16844fc7b1d565963
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:09:42 2018 +0900
      
                  Introduce deployable module
      
              commit d91260bbe105bf46f6c06d9e9593c8c4cd5139cf
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 14:05:31 2018 +0900
      
                  Add database index for successful deployments
      
              commit 74274147263de4b60870065a19935498ce662e30
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 13:51:59 2018 +0900
      
                  Fix invalid state transition
      
              commit ff18463cc847bf3cf5a3e49f3651eedfdf67c7e6
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 20:05:15 2018 +0900
      
                  Fix coding style offence
      
              commit 0202c0f5b631601edab7b359b087b307f5eb7ba3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 18:34:07 2018 +0900
      
                  Target only successful deployments from other relations
      
              commit 1f2758cb030dec1df5dda30f6bc3e25b6d0841c9
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 18:21:28 2018 +0900
      
                  Add namespace explicitly
      
              commit 3d9227b6e5642cecde88d4edac925125f6474b11
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 17:42:30 2018 +0900
      
                  Fix spec in DeleteInconsistentInternalIdRecords
      
              commit 3e0cc99ff6c5c7188511618228a6ec027752ce69
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 16:10:16 2018 +0900
      
                  Fixed spec
      
              commit 8de09b8bb31f7b9f24ecdf9f2dd8ef358a260263
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 14:22:35 2018 +0900
      
                  Fix create deployment service
      
              commit 31957570b4444492eeb412e765f96a56416c25f3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 20:21:26 2018 +0900
      
                  Move CreateDeploymentService. Fix Cycle analytics spec and fixture.
      
              commit d2eb433a1bb9710c0d4778c4f34c12b6b64f60e6
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 20:11:22 2018 +0900
      
                  Fix build success worker
      
              commit 25e6cd87138bcdb69de8785ca367e479c8dbcc59
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 19:49:13 2018 +0900
      
                  Fix create deployment service spec
      
              commit d268bf410bf65e86c81eb76d50aa8e145b32d249
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 19:01:23 2018 +0900
      
                  Fix cycle analysys spec's deployment
      
              commit 525ade8aa1e4394ed8a759bb0437e407fbe74a35
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 18:24:04 2018 +0900
      
                  Fix factory to set legacy status by default
      
              commit c6a990821ac0a1ffa49e20e2d78d94b8ce075914
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 17:25:40 2018 +0900
      
                  Remove unnecessary lib from deployment
      
              commit a6107e0e85ac26ee09da3316ebc11de32f067d82
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 17:38:58 2018 +0900
      
                  Fix recursive call
      
              commit 15c5f3b64061a75af3c3039ca7f49b1cc4ff3068
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 17:30:44 2018 +0900
      
                  Add finished_at
      
              commit c8d3d70366f694d78acb7e30d342c7697798b922
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 15:55:31 2018 +0900
      
                  Fix last_deployment methods as it used to return successful deployment always
      
              commit 96bbe8670cece021766fde95fe573cbbe23d1e55
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 15:49:57 2018 +0900
      
                  Redefine statuses
      
              commit c86a9d0bd2ab3e7a00bf61f094a96ee99b76b289
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 14:50:27 2018 +0900
      
                  Fix schema.rb
      
              commit 9ff5f0eaafbc08795018c7bb282b19f6327dee21
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 14:18:04 2018 +0900
      
                  Default status nil to success
      
              commit 5928bd9bb94e1e8908ed1561e01595be84d5f4ec
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 16 15:13:48 2018 +0900
      
                  Add status to Deployment
      060c5687
  16. 06 Nov, 2018 1 commit
    • Shinya Maeda's avatar
      Squashed commit of the following: · b3020aaf
      Shinya Maeda authored
      commit 931d6ab0e025b0268d94e455f736b09a025e0578
      Merge: b34d165320d 93846eb1
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 5 09:36:58 2018 +0900
      
          Merge branch 'master-ce' into stateful_deployments
      
      commit b34d165320d6f3298c8b776ba66270a59c217412
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 18:07:08 2018 +0900
      
          Fix flaky spec
      
      commit b5e0527c5d4fe8f18b2fdda5916bae9b8cd859a4
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 15:32:03 2018 +0900
      
          Fix spec
      
      commit f78a5e96e66fe2d25086df495e339b470a274df8
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 14:59:29 2018 +0900
      
          Remove unnecessary line in schema.rb
      
      commit 6ce7c483e0591b5d6f9588a99853834327b80031
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 14:55:48 2018 +0900
      
          Add partial index for filling deployment at migration
      
      commit aecccfb5118c8982db3ba502fdf37b5e639fbfc6
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 14:42:24 2018 +0900
      
          Fix fill empty finished at migration
      
      commit 0199e1761ad1b391ae87a53a9a113d3256529e0e
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 14:19:44 2018 +0900
      
          Fix flaky spec
      
      commit 56ac84cd8095afab5b909119445537b7da06a2ff
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 2 10:06:49 2018 +0900
      
          Fix guard clause to prevent multiple deployments to a job
      
      commit 521561b6b303b54635c30cb23d78e49d14cec53d
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 20:19:24 2018 +0900
      
          Fix spec
      
      commit 2878da0d29b9bd2dde69a1b216203df118dd59a1
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 19:38:59 2018 +0900
      
          Simplify the factory
      
      commit 22fd7df02133f3a21828554965fd5619905eac2c
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 19:33:50 2018 +0900
      
          Simplify the Deployable and BuildSuccessWorker
      
      commit 41108959677ed614f4548443a2f4303c4c04925a
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 18:34:20 2018 +0900
      
          Fix spec
      
      commit ae75fe7461ac72f621498797f478d42331342b84
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 17:19:12 2018 +0900
      
          Fix weird virtual deployment status
      
      commit 380fee7494d06407dccc292c3cbedbcee7b6e235
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:59:31 2018 +0900
      
          Fix spec
      
      commit 29889fcbaadb3bbfd2f11c10bfbf5dceb3e3ddba
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 15:07:10 2018 +0900
      
          Fix coding offence
      
      commit 36ac13f345f5ef25725c2236a791a40a3a9e6126
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 14:22:17 2018 +0900
      
          Squashed commit of the following:
      
          commit ba9aede922e1643db3f06c56736d46d6d86d356b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 14:21:33 2018 +0900
      
              Fix ambiguious factory specification in update deployment service spec
      
          commit 013afb5668cb30dc4ca5b21945c17b341e7ea7f9
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Nov 1 14:10:24 2018 +0900
      
              Fix spec
      
          commit 78793670d049e2dfb5fc98177eb4d10f20b9310b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 18:26:12 2018 +0900
      
              Fix spec
      
          commit 73d27e87c66698f2e3a817bb8728f02475b7ba4f
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 16:22:14 2018 +0900
      
              Fix index
      
          commit 8580a226ea68bf5e49b35bfb5f404968bbfaf8e9
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 15:34:57 2018 +0900
      
              Fix deployment relationships in Ci::Build
      
          commit d6d28b55afd1179200b4f5188e0b53079ff3c1a7
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 15:27:53 2018 +0900
      
              Fix spec
      
          commit 94eb754e2e1bb9a1fe627f86823f571a8298d27b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 31 14:07:11 2018 +0900
      
              Fix spec
      
          commit 0b30f80bcd08a7a06bdde3378ec1733f865284be
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 20:15:31 2018 +0900
      
              Fix spec
      
          commit 466bdcdb6af8cdb475c9fa16bd7d1dff23b11e40
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 19:28:51 2018 +0900
      
              Fix spec
      
          commit a7c3caac99139e70fe3f1f3d14856939fa25c527
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 17:33:47 2018 +0900
      
              Fix factory
      
          commit cea28ae100532e6711ce1d22676719a94e2da8a0
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 16:28:18 2018 +0900
      
              Drop leagacy success
      
          commit 3785d685eabc10b6597cf3db67bf08385ccf298a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:37:28 2018 +0900
      
              Remove unnecessary migration file
      
          commit 0d597fa46eeffdbb9a4afb53005a8183e433c6bf
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:35:53 2018 +0900
      
              Fix schema.rb
      
          commit ec3c2abc6944e09f6410468ae5e356865ec7b02b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:34:21 2018 +0900
      
              Rename post migration file
      
          commit 0e7281885a84656acf95f0f423732680f8fec076
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:31:01 2018 +0900
      
              Remove include EnumWithNil
      
          commit b3846d59c07e07275126c70361bde7f30810729e
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 15:05:50 2018 +0900
      
              Decouple action
      
          commit c9f9ba4eae9ca1edc7d8751e1d2e0572cb222d9c
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 14:23:29 2018 +0900
      
              Remove status mock
      
          commit d95bfea1ca67b3a27a3226a669c2b1266d696682
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 14:17:14 2018 +0900
      
              Add action
      
          commit 0cec39e0f76c22a18498f46d65ad7226fb30c3f8
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Tue Oct 30 13:44:07 2018 +0900
      
              Remove unnecessary line in schema.rb
      
          commit 7b4c5f8e1b00dd8e6aa944352f9d8a9f3ae6f1c7
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 19:59:41 2018 +0900
      
              Revert build success worker
      
          commit 0c52ffa4a23eea488c187317e8b400369846f399
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 19:11:47 2018 +0900
      
              Use add_column_with_default properly
      
          commit ba9bae357da5dfd2f6ec05f7f9db9d0b31224f48
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 18:40:55 2018 +0900
      
              Fix with_status
      
          commit 75dffc97b9c5f6fa73d9d09b125c8f849fa2caae
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 16:26:56 2018 +0900
      
              Remove unnecessary line in schema.rb
      
          commit 25188ccc52fb29ca63b9205c4d95ffc2e0afadee
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Mon Oct 29 16:26:17 2018 +0900
      
              Set default values in regular migration
      
          commit 98ea037fbf39c8d9f0db77fb50e2d08382425158
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 17:27:49 2018 +0900
      
              Fix static analysis
      
          commit e7d1765f77f9ff9b94a34985a7855bdaab1da675
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:37:10 2018 +0900
      
              Remove empty spec
      
          commit 0033f521ed1eae8117dba231961aa47c068bbcfb
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:34:55 2018 +0900
      
              Simplify spec changes
      
          commit 0be4c6b3ade6d9a8bf28bcd177c66ebd7bb7d20a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:32:45 2018 +0900
      
              Simplify spec changes
      
          commit a93d25d79df7e25bdf688fc938c712922f9dc4df
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 16:02:31 2018 +0900
      
              Fix flaky spec
      
          commit 339ad50cf471ca706b29f008ccd2bb881dd5b776
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 15:06:22 2018 +0900
      
              Rename Deployments Success worker
      
          commit bd69c78085adcb9b0f8ff9b7041ae355953ad7ab
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Fri Oct 26 14:43:03 2018 +0900
      
              Fix coding offence
      
          commit 004748b2a9c5236ec13eb01289418f3d6571c92c
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 20:09:10 2018 +0900
      
              Rename to update deployment service
      
          commit b04a85e761de501f030f3844fd485a2b9e46f7f7
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 18:46:52 2018 +0900
      
              Add spec for Project
      
          commit 548af23a5a07f0c20b72849d03aa0b98a0b49134
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 18:43:25 2018 +0900
      
              Fix spec
      
          commit c977e4d3f17194c46a1bf857b473017ce21ef7e9
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:58:07 2018 +0900
      
              Add spec for Environment
      
          commit 73feb9010f8d8093bee4b46e56d30cfef3e8e34a
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:39:24 2018 +0900
      
              Add spec for Deployment model
      
          commit 9a3cfbf766f402571588839375cf311bb9807035
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:18:02 2018 +0900
      
              Fix statis analysis
      
          commit a30d28dbc631a29855883ca89c592a10c012f1d2
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 17:17:32 2018 +0900
      
              Ignore nil instance
      
          commit fa6fdd89f380e588a6bcf14b1f9aef0d14d3854b
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 16:20:40 2018 +0900
      
              Add spec for deployable concern
      
          commit aa91186821dc671df2c7a641e37586dd5dfc1008
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 15:37:23 2018 +0900
      
              Clean up deployable
      
          commit 34d3e18731f7906a3db250b105a64d1db83c2fca
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 15:13:05 2018 +0900
      
              Fix 17 cycle analytics
      
          commit 8dc9e00408f9b390175e7d5ea743eed4fb9e3f79
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Thu Oct 25 13:56:51 2018 +0900
      
              Fix static analysys
      
          commit 5c4175807a537bafc4b889b0a97e8f96f0e483cd
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 24 15:05:05 2018 +0900
      
              Skip unnecessary sidekiq worker
      
          commit 9d8b5d423f49cc247c96ce3767d03b4af305809f
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 24 14:53:13 2018 +0900
      
              Add changelog
      
          commit c8cabba496722240cadf7c161c80bceb09727cba
          Author: Shinya Maeda <shinya@gitlab.com>
          Date:   Wed Oct 24 14:44:45 2018 +0900
      
              Squashed commit of the following:
      
              commit f7643885ac2329e18d690a4e4f2d7614b732c793
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 19:38:45 2018 +0900
      
                  Fix deployment widget specs
      
              commit 03bd04b5c98b634dff6a0ab4292c150a9031995c
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 17:50:16 2018 +0900
      
                  Fix env status spec
      
              commit 4a49c6502b161a12f0f62d5ec167dff777047dab
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 17:48:59 2018 +0900
      
                  Fix environment spec
      
              commit 4044822887987e20a703990ff20352a532eeb965
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 17:47:17 2018 +0900
      
                  Fix environment spec
      
              commit 9939d44b7eb9da371de74c0f04fed1eb3db37ad3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 15:45:43 2018 +0900
      
                  Add a new spec for deployment success worker
      
              commit f61c4d3657b5ef13b5da171460da68a6643ad4b5
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 15:38:11 2018 +0900
      
                  Fix cycle analytics helper
      
              commit b6242615e8298fb7fc047c8df8006c25ad717c70
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 14:41:54 2018 +0900
      
                  Fix cycle analysis helper
      
              commit 9a001cb4c4ed6f3b87dc612bdffc60a6b2b0a132
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 14:37:08 2018 +0900
      
                  Ignore coding offence in build success worker's spec
      
              commit 1fb88583025bac8a56172cbd59be04258ea4c5f3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 23 14:33:11 2018 +0900
      
                  Added more spec for deployments
      
              commit 1a6ba97ababbf62e8dd0ae0c56d75ab1268fd0ce
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 19:36:50 2018 +0900
      
                  Move after create hookd into success worker
      
              commit 09de5fed5d6f108423779cf9d9e7f1d21f3c1c91
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 19:30:06 2018 +0900
      
                  Fix build spec
      
              commit 73a55cbcabbb1e928eca3e53e8ff75dec178bc90
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 19:08:43 2018 +0900
      
                  Fix update_deployment_metrics_service_spec.rb
      
              commit ee05136a02ae9fa348b4b89b9a69937ebb9697dd
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 17:32:05 2018 +0900
      
                  Remove unnecessary degelate
      
              commit e246ddeebc01a807ccc36fdb484c3e72ad91e680
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 16:07:39 2018 +0900
      
                  Remove unnecessary optimistic locking
      
              commit dcc225c8237b90e3bc8dcc3dc2e3252e0b0be093
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 16:00:22 2018 +0900
      
                  Simplify status replication
      
              commit 13a5fd7afb67ba2712fcaecaea5fedf05f9ad177
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:29:24 2018 +0900
      
                  Fix sidekiq queue names
      
              commit dcc796f48d523538e1c91b9cd3e1c7065e5329b1
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:23:55 2018 +0900
      
                  Revert success check in update_merge_request_metrics
      
              commit 129ef083d637d4acb8c97a6d9ab96deb2ff6efcd
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:18:31 2018 +0900
      
                  Fix queue name of deployment success worker
      
              commit 10fe5a6484f4f02322ce5bb16844fc7b1d565963
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 15:09:42 2018 +0900
      
                  Introduce deployable module
      
              commit d91260bbe105bf46f6c06d9e9593c8c4cd5139cf
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 14:05:31 2018 +0900
      
                  Add database index for successful deployments
      
              commit 74274147263de4b60870065a19935498ce662e30
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Mon Oct 22 13:51:59 2018 +0900
      
                  Fix invalid state transition
      
              commit ff18463cc847bf3cf5a3e49f3651eedfdf67c7e6
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 20:05:15 2018 +0900
      
                  Fix coding style offence
      
              commit 0202c0f5b631601edab7b359b087b307f5eb7ba3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 18:34:07 2018 +0900
      
                  Target only successful deployments from other relations
      
              commit 1f2758cb030dec1df5dda30f6bc3e25b6d0841c9
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 18:21:28 2018 +0900
      
                  Add namespace explicitly
      
              commit 3d9227b6e5642cecde88d4edac925125f6474b11
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 17:42:30 2018 +0900
      
                  Fix spec in DeleteInconsistentInternalIdRecords
      
              commit 3e0cc99ff6c5c7188511618228a6ec027752ce69
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 16:10:16 2018 +0900
      
                  Fixed spec
      
              commit 8de09b8bb31f7b9f24ecdf9f2dd8ef358a260263
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Fri Oct 19 14:22:35 2018 +0900
      
                  Fix create deployment service
      
              commit 31957570b4444492eeb412e765f96a56416c25f3
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 20:21:26 2018 +0900
      
                  Move CreateDeploymentService. Fix Cycle analytics spec and fixture.
      
              commit d2eb433a1bb9710c0d4778c4f34c12b6b64f60e6
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 20:11:22 2018 +0900
      
                  Fix build success worker
      
              commit 25e6cd87138bcdb69de8785ca367e479c8dbcc59
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 19:49:13 2018 +0900
      
                  Fix create deployment service spec
      
              commit d268bf410bf65e86c81eb76d50aa8e145b32d249
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 19:01:23 2018 +0900
      
                  Fix cycle analysys spec's deployment
      
              commit 525ade8aa1e4394ed8a759bb0437e407fbe74a35
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 18:24:04 2018 +0900
      
                  Fix factory to set legacy status by default
      
              commit c6a990821ac0a1ffa49e20e2d78d94b8ce075914
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Thu Oct 18 17:25:40 2018 +0900
      
                  Remove unnecessary lib from deployment
      
              commit a6107e0e85ac26ee09da3316ebc11de32f067d82
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 17:38:58 2018 +0900
      
                  Fix recursive call
      
              commit 15c5f3b64061a75af3c3039ca7f49b1cc4ff3068
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 17:30:44 2018 +0900
      
                  Add finished_at
      
              commit c8d3d70366f694d78acb7e30d342c7697798b922
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 15:55:31 2018 +0900
      
                  Fix last_deployment methods as it used to return successful deployment always
      
              commit 96bbe8670cece021766fde95fe573cbbe23d1e55
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 15:49:57 2018 +0900
      
                  Redefine statuses
      
              commit c86a9d0bd2ab3e7a00bf61f094a96ee99b76b289
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 14:50:27 2018 +0900
      
                  Fix schema.rb
      
              commit 9ff5f0eaafbc08795018c7bb282b19f6327dee21
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Wed Oct 17 14:18:04 2018 +0900
      
                  Default status nil to success
      
              commit 5928bd9bb94e1e8908ed1561e01595be84d5f4ec
              Author: Shinya Maeda <shinya@gitlab.com>
              Date:   Tue Oct 16 15:13:48 2018 +0900
      
                  Add status to Deployment
      b3020aaf
  17. 05 Nov, 2018 3 commits
    • Yorick Peterse's avatar
      Rewrite SnippetsFinder to improve performance · d171ff60
      Yorick Peterse authored
      This completely rewrites the SnippetsFinder class from the ground up in
      order to improve its performance. The old code was beyond salvaging. It
      was complex, included various Rails 5 workarounds, comments that
      shouldn't be necessary, and most important of all: it produced a really
      poorly performing database query.
      
      As a result, I opted for rewriting the finder from scratch, instead of
      trying to patch the existing code. Instead of trying to reuse as many
      existing methods as possible, I opted for defining new methods
      specifically meant for the SnippetsFinder. This requires some extra code
      here and there, but allows us to have much more control over the
      resulting SQL queries. It is these changes that then allow us to produce
      a _much_ more efficient query.
      
      To illustrate how bad the old query was, we will use my own snippets as
      an example. Currently I have 52 snippets, most of which are global ones.
      To retrieve these, you would run the following Ruby code:
      
          user = User.find_by(username: 'yorickpeterse')
      
          SnippetsFinder.new(user, author: user).execute
      
      On GitLab.com the resulting query will take between 10 and 15 seconds to
      run, producing the query plan found at
      https://explain.depesz.com/s/Y5IX. Apart from the long execution time,
      the total number of buffers (the sum of all shared hits) is around 185
      GB, though the real number is probably (hopefully) much lower as I doubt
      simply summing these numbers produces the true total number of buffers
      used.
      
      The new query's plan can be found at https://explain.depesz.com/s/wHdN,
      and this query takes between 10 and 100-ish milliseconds to run. The
      total number of buffers used is only about 30 MB.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/52639
      d171ff60
    • Mark Chao's avatar
      Combine two updates in one query · 666ddec9
      Mark Chao authored
      666ddec9
    • Nick Thomas's avatar
      Start tracking pool repositories · 270155d6
      Nick Thomas authored
      270155d6
  18. 02 Nov, 2018 1 commit
  19. 01 Nov, 2018 1 commit
  20. 31 Oct, 2018 1 commit
  21. 30 Oct, 2018 2 commits
  22. 22 Oct, 2018 3 commits
    • Cindy Pallares's avatar
      Alias the lfs_enabled method · be493207
      Cindy Pallares authored
      We currently check for `project.lfs_enabled` to display
      the state of lfs being enabled/disabled, but this is set to nil by
      default, even when lfs is enabled.
      
      Aliasing the method to #lfs_enabled? will return the correct state.
      be493207
    • Yorick Peterse's avatar
      Backport rescue in Project#import_url from EE · 82f17421
      Yorick Peterse authored
      EE added a `rescue` to the method Project#import_url, which could cause
      merge conflicts when changing this method. This commit backports those
      changes to CE, reducing the chances of running into a merge conflict.
      82f17421
    • Yorick Peterse's avatar
      Move Project#rename_repo to a service class · 4b9c17f1
      Yorick Peterse authored
      This moves the logic of Project#rename_repo and all methods _only_ used
      by this method into a new service class: Projects::AfterRenameService.
      By moving this code into a separate service class we can more easily
      refactor it, and we also get rid of some RuboCop "disable" statements
      automatically.
      
      During the refactoring of this code, I removed most of the explicit
      logging using Gitlab::AppLogger. The data that was logged would not be
      useful when debugging renaming issues, as it does not add any value on
      top of data provided by users.
      
      I also removed a variety of comments that either mentioned something the
      code does in literal form, or contained various grammatical errors.
      Instead we now resort to more clearly named methods, removing the need
      for code comments.
      
      This method was chosen based on analysis in
      https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue
      we determined this method has seen a total of 293 lines being changed in
      it. We also noticed that RuboCop determined the ABC size
      (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.
      4b9c17f1
  23. 19 Oct, 2018 1 commit
    • Bob Van Landuyt's avatar
      Remove the `ForkedProjectLink` model · f3fba178
      Bob Van Landuyt authored
      This removes the `ForkedProjectLink` model that has been replaced by
      the `ForkNetworkMember` and `ForkNetwork` combination. All existing
      relations have been adjusted to use these new models.
      
      The `forked_project_link` table has been dropped.
      
      The "Forks" count on the admin dashboard has been updated to count all
      `ForkNetworkMember` rows and deduct the number of `ForkNetwork`
      rows. This is because now the "root-project" of a fork network also
      has a `ForkNetworkMember` row. This count could become inaccurate when
      the root of a fork network is deleted.
      f3fba178
  24. 15 Oct, 2018 1 commit