br_if.c 14.5 KB
Newer Older
Linus Torvalds's avatar
Linus Torvalds committed
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 *	Userspace interface
 *	Linux ethernet bridge
 *
 *	Authors:
 *	Lennert Buytenhek		<buytenh@gnu.org>
 *
 *	This program is free software; you can redistribute it and/or
 *	modify it under the terms of the GNU General Public License
 *	as published by the Free Software Foundation; either version
 *	2 of the License, or (at your option) any later version.
 */

#include <linux/kernel.h>
#include <linux/netdevice.h>
16
#include <linux/etherdevice.h>
17
#include <linux/netpoll.h>
Linus Torvalds's avatar
Linus Torvalds committed
18 19 20 21 22
#include <linux/ethtool.h>
#include <linux/if_arp.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/rtnetlink.h>
23
#include <linux/if_ether.h>
24
#include <linux/slab.h>
Linus Torvalds's avatar
Linus Torvalds committed
25
#include <net/sock.h>
26
#include <linux/if_vlan.h>
27
#include <net/switchdev.h>
Linus Torvalds's avatar
Linus Torvalds committed
28 29 30 31 32 33 34

#include "br_private.h"

/*
 * Determine initial path cost based on speed.
 * using recommendations from 802.1d standard
 *
35
 * Since driver might sleep need to not be holding any locks.
Linus Torvalds's avatar
Linus Torvalds committed
36
 */
37
static int port_cost(struct net_device *dev)
Linus Torvalds's avatar
Linus Torvalds committed
38
{
39
	struct ethtool_link_ksettings ecmd;
40

41 42
	if (!__ethtool_get_link_ksettings(dev, &ecmd)) {
		switch (ecmd.base.speed) {
43 44 45 46 47 48 49 50
		case SPEED_10000:
			return 2;
		case SPEED_1000:
			return 4;
		case SPEED_100:
			return 19;
		case SPEED_10:
			return 100;
Linus Torvalds's avatar
Linus Torvalds committed
51 52 53 54 55 56 57 58 59 60 61 62 63
		}
	}

	/* Old silly heuristics based on name */
	if (!strncmp(dev->name, "lec", 3))
		return 7;

	if (!strncmp(dev->name, "plip", 4))
		return 2500;

	return 100;	/* assume old 10Mbps */
}

64

tanxiaojun's avatar
tanxiaojun committed
65
/* Check for port carrier transitions. */
66
void br_port_carrier_check(struct net_bridge_port *p)
67
{
68 69
	struct net_device *dev = p->dev;
	struct net_bridge *br = p->br;
Stephen Hemminger's avatar
Stephen Hemminger committed
70

71 72
	if (!(p->flags & BR_ADMIN_COST) &&
	    netif_running(dev) && netif_oper_up(dev))
Stephen Hemminger's avatar
Stephen Hemminger committed
73 74
		p->path_cost = port_cost(dev);

75 76 77 78
	if (!netif_running(br->dev))
		return;

	spin_lock_bh(&br->lock);
79
	if (netif_running(dev) && netif_oper_up(dev)) {
80 81 82 83 84
		if (p->state == BR_STATE_DISABLED)
			br_stp_enable_port(p);
	} else {
		if (p->state != BR_STATE_DISABLED)
			br_stp_disable_port(p);
85
	}
86
	spin_unlock_bh(&br->lock);
87 88
}

89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156
static void br_port_set_promisc(struct net_bridge_port *p)
{
	int err = 0;

	if (br_promisc_port(p))
		return;

	err = dev_set_promiscuity(p->dev, 1);
	if (err)
		return;

	br_fdb_unsync_static(p->br, p);
	p->flags |= BR_PROMISC;
}

static void br_port_clear_promisc(struct net_bridge_port *p)
{
	int err;

	/* Check if the port is already non-promisc or if it doesn't
	 * support UNICAST filtering.  Without unicast filtering support
	 * we'll end up re-enabling promisc mode anyway, so just check for
	 * it here.
	 */
	if (!br_promisc_port(p) || !(p->dev->priv_flags & IFF_UNICAST_FLT))
		return;

	/* Since we'll be clearing the promisc mode, program the port
	 * first so that we don't have interruption in traffic.
	 */
	err = br_fdb_sync_static(p->br, p);
	if (err)
		return;

	dev_set_promiscuity(p->dev, -1);
	p->flags &= ~BR_PROMISC;
}

/* When a port is added or removed or when certain port flags
 * change, this function is called to automatically manage
 * promiscuity setting of all the bridge ports.  We are always called
 * under RTNL so can skip using rcu primitives.
 */
void br_manage_promisc(struct net_bridge *br)
{
	struct net_bridge_port *p;
	bool set_all = false;

	/* If vlan filtering is disabled or bridge interface is placed
	 * into promiscuous mode, place all ports in promiscuous mode.
	 */
	if ((br->dev->flags & IFF_PROMISC) || !br_vlan_enabled(br))
		set_all = true;

	list_for_each_entry(p, &br->port_list, list) {
		if (set_all) {
			br_port_set_promisc(p);
		} else {
			/* If the number of auto-ports is <= 1, then all other
			 * ports will have their output configuration
			 * statically specified through fdbs.  Since ingress
			 * on the auto-port becomes forwarding/egress to other
			 * ports and egress configuration is statically known,
			 * we can say that ingress configuration of the
			 * auto-port is also statically known.
			 * This lets us disable promiscuous mode and write
			 * this config to hw.
			 */
157 158
			if (br->auto_cnt == 0 ||
			    (br->auto_cnt == 1 && br_auto_port(p)))
159 160 161 162 163 164 165
				br_port_clear_promisc(p);
			else
				br_port_set_promisc(p);
		}
	}
}

166 167 168 169 170 171 172 173 174
static void nbp_update_port_count(struct net_bridge *br)
{
	struct net_bridge_port *p;
	u32 cnt = 0;

	list_for_each_entry(p, &br->port_list, list) {
		if (br_auto_port(p))
			cnt++;
	}
175 176 177 178 179 180 181 182
	if (br->auto_cnt != cnt) {
		br->auto_cnt = cnt;
		br_manage_promisc(br);
	}
}

static void nbp_delete_promisc(struct net_bridge_port *p)
{
183
	/* If port is currently promiscuous, unset promiscuity.
184 185 186 187 188 189 190 191
	 * Otherwise, it is a static port so remove all addresses
	 * from it.
	 */
	dev_set_allmulti(p->dev, -1);
	if (br_promisc_port(p))
		dev_set_promiscuity(p->dev, -1);
	else
		br_fdb_unsync_static(p->br, p);
192 193
}

194 195 196 197 198 199 200 201 202 203 204 205 206 207
static void release_nbp(struct kobject *kobj)
{
	struct net_bridge_port *p
		= container_of(kobj, struct net_bridge_port, kobj);
	kfree(p);
}

static struct kobj_type brport_ktype = {
#ifdef CONFIG_SYSFS
	.sysfs_ops = &brport_sysfs_ops,
#endif
	.release = release_nbp,
};

Linus Torvalds's avatar
Linus Torvalds committed
208 209 210 211 212 213 214 215
static void destroy_nbp(struct net_bridge_port *p)
{
	struct net_device *dev = p->dev;

	p->br = NULL;
	p->dev = NULL;
	dev_put(dev);

216
	kobject_put(&p->kobj);
Linus Torvalds's avatar
Linus Torvalds committed
217 218 219 220 221 222 223 224 225
}

static void destroy_nbp_rcu(struct rcu_head *head)
{
	struct net_bridge_port *p =
			container_of(head, struct net_bridge_port, rcu);
	destroy_nbp(p);
}

226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250
static unsigned get_max_headroom(struct net_bridge *br)
{
	unsigned max_headroom = 0;
	struct net_bridge_port *p;

	list_for_each_entry(p, &br->port_list, list) {
		unsigned dev_headroom = netdev_get_fwd_headroom(p->dev);

		if (dev_headroom > max_headroom)
			max_headroom = dev_headroom;
	}

	return max_headroom;
}

static void update_headroom(struct net_bridge *br, int new_hr)
{
	struct net_bridge_port *p;

	list_for_each_entry(p, &br->port_list, list)
		netdev_set_rx_headroom(p->dev, new_hr);

	br->dev->needed_headroom = new_hr;
}

251 252 253 254 255 256 257 258 259
/* Delete port(interface) from bridge is done in two steps.
 * via RCU. First step, marks device as down. That deletes
 * all the timers and stops new packets from flowing through.
 *
 * Final cleanup doesn't occur until after all CPU's finished
 * processing packets.
 *
 * Protected from multiple admin operations by RTNL mutex
 */
Linus Torvalds's avatar
Linus Torvalds committed
260 261 262 263 264
static void del_nbp(struct net_bridge_port *p)
{
	struct net_bridge *br = p->br;
	struct net_device *dev = p->dev;

265
	sysfs_remove_link(br->ifobj, p->dev->name);
266

267
	nbp_delete_promisc(p);
Linus Torvalds's avatar
Linus Torvalds committed
268 269 270 271 272

	spin_lock_bh(&br->lock);
	br_stp_disable_port(p);
	spin_unlock_bh(&br->lock);

273 274
	br_ifinfo_notify(RTM_DELLINK, p);

Linus Torvalds's avatar
Linus Torvalds committed
275
	list_del_rcu(&p->list);
276 277 278
	if (netdev_get_fwd_headroom(dev) == br->dev->needed_headroom)
		update_headroom(br, get_max_headroom(br));
	netdev_reset_rx_headroom(dev);
Linus Torvalds's avatar
Linus Torvalds committed
279

280
	nbp_vlan_flush(p);
281
	br_fdb_delete_by_port(br, p, 0, 1);
282 283
	switchdev_deferred_process();

284 285
	nbp_update_port_count(br);

286 287
	netdev_upper_dev_unlink(dev, br->dev);

288 289
	dev->priv_flags &= ~IFF_BRIDGE_PORT;

290
	netdev_rx_handler_unregister(dev);
291

292 293
	br_multicast_del_port(p);

294
	kobject_uevent(&p->kobj, KOBJ_REMOVE);
295 296
	kobject_del(&p->kobj);

Herbert Xu's avatar
Herbert Xu committed
297 298
	br_netpoll_disable(p);

Linus Torvalds's avatar
Linus Torvalds committed
299 300 301
	call_rcu(&p->rcu, destroy_nbp_rcu);
}

302 303
/* Delete bridge device */
void br_dev_delete(struct net_device *dev, struct list_head *head)
Linus Torvalds's avatar
Linus Torvalds committed
304
{
305
	struct net_bridge *br = netdev_priv(dev);
Linus Torvalds's avatar
Linus Torvalds committed
306 307 308 309 310 311
	struct net_bridge_port *p, *n;

	list_for_each_entry_safe(p, n, &br->port_list, list) {
		del_nbp(p);
	}

312
	br_fdb_delete_by_port(br, NULL, 0, 1);
313

314
	br_vlan_flush(br);
315
	br_multicast_dev_del(br);
Linus Torvalds's avatar
Linus Torvalds committed
316 317 318
	del_timer_sync(&br->gc_timer);

	br_sysfs_delbr(br->dev);
319
	unregister_netdevice_queue(br->dev, head);
Linus Torvalds's avatar
Linus Torvalds committed
320 321 322 323 324 325 326 327 328
}

/* find an available port number */
static int find_portno(struct net_bridge *br)
{
	int index;
	struct net_bridge_port *p;
	unsigned long *inuse;

Stephen Hemminger's avatar
Stephen Hemminger committed
329
	inuse = kcalloc(BITS_TO_LONGS(BR_MAX_PORTS), sizeof(unsigned long),
Linus Torvalds's avatar
Linus Torvalds committed
330 331 332 333 334 335 336 337 338 339 340 341 342 343
			GFP_KERNEL);
	if (!inuse)
		return -ENOMEM;

	set_bit(0, inuse);	/* zero is reserved */
	list_for_each_entry(p, &br->port_list, list) {
		set_bit(p->port_no, inuse);
	}
	index = find_first_zero_bit(inuse, BR_MAX_PORTS);
	kfree(inuse);

	return (index >= BR_MAX_PORTS) ? -EXFULL : index;
}

344
/* called with RTNL but without bridge lock */
345
static struct net_bridge_port *new_nbp(struct net_bridge *br,
346
				       struct net_device *dev)
Linus Torvalds's avatar
Linus Torvalds committed
347 348
{
	struct net_bridge_port *p;
349
	int index, err;
350

Linus Torvalds's avatar
Linus Torvalds committed
351 352 353 354
	index = find_portno(br);
	if (index < 0)
		return ERR_PTR(index);

Stephen Hemminger's avatar
Stephen Hemminger committed
355
	p = kzalloc(sizeof(*p), GFP_KERNEL);
Linus Torvalds's avatar
Linus Torvalds committed
356 357 358 359 360 361
	if (p == NULL)
		return ERR_PTR(-ENOMEM);

	p->br = br;
	dev_hold(dev);
	p->dev = dev;
362
	p->path_cost = port_cost(dev);
363
	p->priority = 0x8000 >> BR_PORT_BITS;
Linus Torvalds's avatar
Linus Torvalds committed
364
	p->port_no = index;
365
	p->flags = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD;
Linus Torvalds's avatar
Linus Torvalds committed
366
	br_init_port(p);
367
	br_set_state(p, BR_STATE_DISABLED);
368
	br_stp_port_timer_init(p);
369 370 371 372 373 374
	err = br_multicast_add_port(p);
	if (err) {
		dev_put(dev);
		kfree(p);
		p = ERR_PTR(err);
	}
Linus Torvalds's avatar
Linus Torvalds committed
375 376 377 378

	return p;
}

379
int br_add_bridge(struct net *net, const char *name)
Linus Torvalds's avatar
Linus Torvalds committed
380 381
{
	struct net_device *dev;
382
	int res;
Linus Torvalds's avatar
Linus Torvalds committed
383

384
	dev = alloc_netdev(sizeof(struct net_bridge), name, NET_NAME_UNKNOWN,
385 386
			   br_dev_setup);

387
	if (!dev)
Linus Torvalds's avatar
Linus Torvalds committed
388 389
		return -ENOMEM;

390
	dev_net_set(dev, net);
391
	dev->rtnl_link_ops = &br_link_ops;
392

393 394 395 396
	res = register_netdev(dev);
	if (res)
		free_netdev(dev);
	return res;
Linus Torvalds's avatar
Linus Torvalds committed
397 398
}

399
int br_del_bridge(struct net *net, const char *name)
Linus Torvalds's avatar
Linus Torvalds committed
400 401 402 403 404
{
	struct net_device *dev;
	int ret = 0;

	rtnl_lock();
405
	dev = __dev_get_by_name(net, name);
406
	if (dev == NULL)
Linus Torvalds's avatar
Linus Torvalds committed
407 408 409 410 411 412 413 414 415 416
		ret =  -ENXIO; 	/* Could not find device */

	else if (!(dev->priv_flags & IFF_EBRIDGE)) {
		/* Attempt to delete non bridge device! */
		ret = -EPERM;
	}

	else if (dev->flags & IFF_UP) {
		/* Not shutdown yet. */
		ret = -EBUSY;
417
	}
Linus Torvalds's avatar
Linus Torvalds committed
418

419
	else
420
		br_dev_delete(dev, NULL);
Linus Torvalds's avatar
Linus Torvalds committed
421 422 423 424 425

	rtnl_unlock();
	return ret;
}

426
/* MTU of the bridge pseudo-device: ETH_DATA_LEN or the minimum of the ports */
Linus Torvalds's avatar
Linus Torvalds committed
427 428 429 430 431 432 433 434
int br_min_mtu(const struct net_bridge *br)
{
	const struct net_bridge_port *p;
	int mtu = 0;

	ASSERT_RTNL();

	if (list_empty(&br->port_list))
435
		mtu = ETH_DATA_LEN;
Linus Torvalds's avatar
Linus Torvalds committed
436 437 438 439 440 441 442 443 444
	else {
		list_for_each_entry(p, &br->port_list, list) {
			if (!mtu  || p->dev->mtu < mtu)
				mtu = p->dev->mtu;
		}
	}
	return mtu;
}

445 446 447 448 449 450 451 452 453 454 455 456 457 458
static void br_set_gso_limits(struct net_bridge *br)
{
	unsigned int gso_max_size = GSO_MAX_SIZE;
	u16 gso_max_segs = GSO_MAX_SEGS;
	const struct net_bridge_port *p;

	list_for_each_entry(p, &br->port_list, list) {
		gso_max_size = min(gso_max_size, p->dev->gso_max_size);
		gso_max_segs = min(gso_max_segs, p->dev->gso_max_segs);
	}
	br->dev->gso_max_size = gso_max_size;
	br->dev->gso_max_segs = gso_max_segs;
}

459 460 461
/*
 * Recomputes features using slave's features
 */
462 463
netdev_features_t br_features_recompute(struct net_bridge *br,
	netdev_features_t features)
464 465
{
	struct net_bridge_port *p;
466
	netdev_features_t mask;
467

468
	if (list_empty(&br->port_list))
469
		return features;
470

471
	mask = features;
472
	features &= ~NETIF_F_ONE_FOR_ALL;
473 474

	list_for_each_entry(p, &br->port_list, list) {
475 476
		features = netdev_increment_features(features,
						     p->dev->features, mask);
477
	}
478
	features = netdev_add_tso_features(features, mask);
479

480
	return features;
481 482
}

Linus Torvalds's avatar
Linus Torvalds committed
483 484 485 486 487
/* called with RTNL */
int br_add_if(struct net_bridge *br, struct net_device *dev)
{
	struct net_bridge_port *p;
	int err = 0;
488
	unsigned br_hr, dev_hr;
489
	bool changed_addr;
Linus Torvalds's avatar
Linus Torvalds committed
490

491 492 493 494 495 496
	/* Don't allow bridging non-ethernet like devices, or DSA-enabled
	 * master network devices since the bridge layer rx_handler prevents
	 * the DSA fake ethertype handler to be invoked, so we do not strip off
	 * the DSA switch tag protocol header and the bridge layer just return
	 * RX_HANDLER_CONSUMED, stopping RX processing for these frames.
	 */
497
	if ((dev->flags & IFF_LOOPBACK) ||
498
	    dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN ||
499 500
	    !is_valid_ether_addr(dev->dev_addr) ||
	    netdev_uses_dsa(dev))
Linus Torvalds's avatar
Linus Torvalds committed
501 502
		return -EINVAL;

503
	/* No bridging of bridges */
504
	if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit)
Linus Torvalds's avatar
Linus Torvalds committed
505 506
		return -ELOOP;

507 508
	/* Device has master upper dev */
	if (netdev_master_upper_dev_get(dev))
Linus Torvalds's avatar
Linus Torvalds committed
509 510
		return -EBUSY;

511 512 513 514
	/* No bridging devices that dislike that (e.g. wireless) */
	if (dev->priv_flags & IFF_DONT_BRIDGE)
		return -EOPNOTSUPP;

515 516
	p = new_nbp(br, dev);
	if (IS_ERR(p))
Linus Torvalds's avatar
Linus Torvalds committed
517 518
		return PTR_ERR(p);

519 520
	call_netdevice_notifiers(NETDEV_JOIN, dev);

521
	err = dev_set_allmulti(dev, 1);
522 523 524
	if (err)
		goto put_back;

525 526
	err = kobject_init_and_add(&p->kobj, &brport_ktype, &(dev->dev.kobj),
				   SYSFS_BRIDGE_PORT_ATTR);
527 528
	if (err)
		goto err1;
Linus Torvalds's avatar
Linus Torvalds committed
529

530 531 532
	err = br_sysfs_addif(p);
	if (err)
		goto err2;
Linus Torvalds's avatar
Linus Torvalds committed
533

534
	err = br_netpoll_enable(p);
535
	if (err)
Herbert Xu's avatar
Herbert Xu committed
536 537
		goto err3;

538
	err = netdev_rx_handler_register(dev, br_handle_frame, p);
539
	if (err)
540
		goto err4;
541

542 543
	dev->priv_flags |= IFF_BRIDGE_PORT;

544
	err = netdev_master_upper_dev_link(dev, br->dev, NULL, NULL);
545
	if (err)
546
		goto err5;
547

548 549 550 551
	err = nbp_switchdev_mark_set(p);
	if (err)
		goto err6;

552
	dev_disable_lro(dev);
553 554 555

	list_add_rcu(&p->list, &br->port_list);

556 557
	nbp_update_port_count(br);

558 559
	netdev_update_features(br->dev);

560 561 562 563 564 565
	br_hr = br->dev->needed_headroom;
	dev_hr = netdev_get_fwd_headroom(dev);
	if (br_hr < dev_hr)
		update_headroom(br, dev_hr);
	else
		netdev_set_rx_headroom(dev, br_hr);
566

567 568 569
	if (br_fdb_insert(br, p, dev->dev_addr, 0))
		netdev_err(dev, "failed insert local address bridge forwarding table\n");

570 571
	err = nbp_vlan_init(p);
	if (err) {
572
		netdev_err(dev, "failed to initialize vlan filtering on this port\n");
573
		goto err7;
574
	}
575

576
	spin_lock_bh(&br->lock);
577
	changed_addr = br_stp_recalculate_bridge_id(br);
578

579
	if (netif_running(dev) && netif_oper_up(dev) &&
580 581
	    (br->dev->flags & IFF_UP))
		br_stp_enable_port(p);
582 583
	spin_unlock_bh(&br->lock);

584 585
	br_ifinfo_notify(RTM_NEWLINK, p);

586
	if (changed_addr)
587
		call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
588

589
	dev_set_mtu(br->dev, br_min_mtu(br));
590
	br_set_gso_limits(br);
591

592
	kobject_uevent(&p->kobj, KOBJ_ADD);
Linus Torvalds's avatar
Linus Torvalds committed
593

594
	return 0;
595

596
err7:
597 598 599
	list_del_rcu(&p->list);
	br_fdb_delete_by_port(br, p, 0, 1);
	nbp_update_port_count(br);
600
err6:
601
	netdev_upper_dev_unlink(dev, br->dev);
602
err5:
603 604
	dev->priv_flags &= ~IFF_BRIDGE_PORT;
	netdev_rx_handler_unregister(dev);
605 606
err4:
	br_netpoll_disable(p);
Herbert Xu's avatar
Herbert Xu committed
607 608
err3:
	sysfs_remove_link(br->ifobj, p->dev->name);
609
err2:
610
	kobject_put(&p->kobj);
611
	p = NULL; /* kobject_put frees */
612
err1:
613
	dev_set_allmulti(dev, -1);
614 615
put_back:
	dev_put(dev);
616
	kfree(p);
Linus Torvalds's avatar
Linus Torvalds committed
617 618 619 620 621 622
	return err;
}

/* called with RTNL */
int br_del_if(struct net_bridge *br, struct net_device *dev)
{
623
	struct net_bridge_port *p;
624
	bool changed_addr;
625

626
	p = br_port_get_rtnl(dev);
627
	if (!p || p->br != br)
Linus Torvalds's avatar
Linus Torvalds committed
628 629
		return -EINVAL;

630 631 632 633
	/* Since more than one interface can be attached to a bridge,
	 * there still maybe an alternate path for netconsole to use;
	 * therefore there is no reason for a NETDEV_RELEASE event.
	 */
Linus Torvalds's avatar
Linus Torvalds committed
634 635
	del_nbp(p);

636
	dev_set_mtu(br->dev, br_min_mtu(br));
637
	br_set_gso_limits(br);
638

Linus Torvalds's avatar
Linus Torvalds committed
639
	spin_lock_bh(&br->lock);
640
	changed_addr = br_stp_recalculate_bridge_id(br);
Linus Torvalds's avatar
Linus Torvalds committed
641 642
	spin_unlock_bh(&br->lock);

643 644 645
	if (changed_addr)
		call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);

646 647
	netdev_update_features(br->dev);

Linus Torvalds's avatar
Linus Torvalds committed
648 649
	return 0;
}
650 651 652 653 654 655 656 657

void br_port_flags_change(struct net_bridge_port *p, unsigned long mask)
{
	struct net_bridge *br = p->br;

	if (mask & BR_AUTO_MASK)
		nbp_update_port_count(br);
}