hdpvr-video.c 31.1 KB
Newer Older
1
/*
2
 * Hauppauge HD PVR USB driver - video 4 linux 2 interface
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
 *
 * Copyright (C) 2008      Janne Grunau (j@jannau.net)
 *
 *	This program is free software; you can redistribute it and/or
 *	modify it under the terms of the GNU General Public License as
 *	published by the Free Software Foundation, version 2.
 *
 */

#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/uaccess.h>
#include <linux/usb.h>
#include <linux/mutex.h>
#include <linux/workqueue.h>

#include <linux/videodev2.h>
23
#include <linux/v4l2-dv-timings.h>
24 25
#include <media/v4l2-dev.h>
#include <media/v4l2-common.h>
26
#include <media/v4l2-dv-timings.h>
27
#include <media/v4l2-ioctl.h>
28
#include <media/v4l2-event.h>
29 30
#include "hdpvr.h"

31
#define BULK_URB_TIMEOUT   90 /* 0.09 seconds */
32

33 34 35 36 37 38
#define print_buffer_status() { \
		v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,	\
			 "%s:%d buffer stat: %d free, %d proc\n",	\
			 __func__, __LINE__,				\
			 list_size(&dev->free_buff_list),		\
			 list_size(&dev->rec_buff_list)); }
39

40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58
static const struct v4l2_dv_timings hdpvr_dv_timings[] = {
	V4L2_DV_BT_CEA_720X480I59_94,
	V4L2_DV_BT_CEA_720X576I50,
	V4L2_DV_BT_CEA_720X480P59_94,
	V4L2_DV_BT_CEA_720X576P50,
	V4L2_DV_BT_CEA_1280X720P50,
	V4L2_DV_BT_CEA_1280X720P60,
	V4L2_DV_BT_CEA_1920X1080I50,
	V4L2_DV_BT_CEA_1920X1080I60,
};

/* Use 480i59 as the default timings */
#define HDPVR_DEF_DV_TIMINGS_IDX (0)

struct hdpvr_fh {
	struct v4l2_fh fh;
	bool legacy_mode;
};

59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83
static uint list_size(struct list_head *list)
{
	struct list_head *tmp;
	uint count = 0;

	list_for_each(tmp, list) {
		count++;
	}

	return count;
}

/*=========================================================================*/
/* urb callback */
static void hdpvr_read_bulk_callback(struct urb *urb)
{
	struct hdpvr_buffer *buf = (struct hdpvr_buffer *)urb->context;
	struct hdpvr_device *dev = buf->dev;

	/* marking buffer as received and wake waiting */
	buf->status = BUFSTAT_READY;
	wake_up_interruptible(&dev->wait_data);
}

/*=========================================================================*/
84
/* buffer bits */
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111

/* function expects dev->io_mutex to be hold by caller */
int hdpvr_cancel_queue(struct hdpvr_device *dev)
{
	struct hdpvr_buffer *buf;

	list_for_each_entry(buf, &dev->rec_buff_list, buff_list) {
		usb_kill_urb(buf->urb);
		buf->status = BUFSTAT_AVAILABLE;
	}

	list_splice_init(&dev->rec_buff_list, dev->free_buff_list.prev);

	return 0;
}

static int hdpvr_free_queue(struct list_head *q)
{
	struct list_head *tmp;
	struct list_head *p;
	struct hdpvr_buffer *buf;
	struct urb *urb;

	for (p = q->next; p != q;) {
		buf = list_entry(p, struct hdpvr_buffer, buff_list);

		urb = buf->urb;
112 113
		usb_free_coherent(urb->dev, urb->transfer_buffer_length,
				  urb->transfer_buffer, urb->transfer_dma);
114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143
		usb_free_urb(urb);
		tmp = p->next;
		list_del(p);
		kfree(buf);
		p = tmp;
	}

	return 0;
}

/* function expects dev->io_mutex to be hold by caller */
int hdpvr_free_buffers(struct hdpvr_device *dev)
{
	hdpvr_cancel_queue(dev);

	hdpvr_free_queue(&dev->free_buff_list);
	hdpvr_free_queue(&dev->rec_buff_list);

	return 0;
}

/* function expects dev->io_mutex to be hold by caller */
int hdpvr_alloc_buffers(struct hdpvr_device *dev, uint count)
{
	uint i;
	int retval = -ENOMEM;
	u8 *mem;
	struct hdpvr_buffer *buf;
	struct urb *urb;

144
	v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
145 146 147 148 149 150
		 "allocating %u buffers\n", count);

	for (i = 0; i < count; i++) {

		buf = kzalloc(sizeof(struct hdpvr_buffer), GFP_KERNEL);
		if (!buf) {
151
			v4l2_err(&dev->v4l2_dev, "cannot allocate buffer\n");
152 153 154 155 156
			goto exit;
		}
		buf->dev = dev;

		urb = usb_alloc_urb(0, GFP_KERNEL);
157
		if (!urb)
158
			goto exit_urb;
159 160
		buf->urb = urb;

161 162
		mem = usb_alloc_coherent(dev->udev, dev->bulk_in_size, GFP_KERNEL,
					 &urb->transfer_dma);
163
		if (!mem) {
164 165
			v4l2_err(&dev->v4l2_dev,
				 "cannot allocate usb transfer buffer\n");
166
			goto exit_urb_buffer;
167 168 169 170 171 172 173 174
		}

		usb_fill_bulk_urb(buf->urb, dev->udev,
				  usb_rcvbulkpipe(dev->udev,
						  dev->bulk_in_endpointAddr),
				  mem, dev->bulk_in_size,
				  hdpvr_read_bulk_callback, buf);

175
		buf->urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
176 177 178 179
		buf->status = BUFSTAT_AVAILABLE;
		list_add_tail(&buf->buff_list, &dev->free_buff_list);
	}
	return 0;
180 181 182 183
exit_urb_buffer:
	usb_free_urb(urb);
exit_urb:
	kfree(buf);
184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202
exit:
	hdpvr_free_buffers(dev);
	return retval;
}

static int hdpvr_submit_buffers(struct hdpvr_device *dev)
{
	struct hdpvr_buffer *buf;
	struct urb *urb;
	int ret = 0, err_count = 0;

	mutex_lock(&dev->io_mutex);

	while (dev->status == STATUS_STREAMING &&
	       !list_empty(&dev->free_buff_list)) {

		buf = list_entry(dev->free_buff_list.next, struct hdpvr_buffer,
				 buff_list);
		if (buf->status != BUFSTAT_AVAILABLE) {
203
			v4l2_err(&dev->v4l2_dev,
204
				 "buffer not marked as available\n");
205 206 207 208 209 210 211 212 213
			ret = -EFAULT;
			goto err;
		}

		urb = buf->urb;
		urb->status = 0;
		urb->actual_length = 0;
		ret = usb_submit_urb(urb, GFP_KERNEL);
		if (ret) {
214 215 216
			v4l2_err(&dev->v4l2_dev,
				 "usb_submit_urb in %s returned %d\n",
				 __func__, ret);
217 218 219 220 221 222 223 224
			if (++err_count > 2)
				break;
			continue;
		}
		buf->status = BUFSTAT_INPROGRESS;
		list_move_tail(&buf->buff_list, &dev->rec_buff_list);
	}
err:
225
	print_buffer_status();
226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
	mutex_unlock(&dev->io_mutex);
	return ret;
}

static struct hdpvr_buffer *hdpvr_get_next_buffer(struct hdpvr_device *dev)
{
	struct hdpvr_buffer *buf;

	mutex_lock(&dev->io_mutex);

	if (list_empty(&dev->rec_buff_list)) {
		mutex_unlock(&dev->io_mutex);
		return NULL;
	}

	buf = list_entry(dev->rec_buff_list.next, struct hdpvr_buffer,
			 buff_list);
	mutex_unlock(&dev->io_mutex);

	return buf;
}

static void hdpvr_transmit_buffers(struct work_struct *work)
{
	struct hdpvr_device *dev = container_of(work, struct hdpvr_device,
						worker);

	while (dev->status == STATUS_STREAMING) {

		if (hdpvr_submit_buffers(dev)) {
256
			v4l2_err(&dev->v4l2_dev, "couldn't submit buffers\n");
257 258 259 260 261 262 263 264
			goto error;
		}
		if (wait_event_interruptible(dev->wait_buffer,
				!list_empty(&dev->free_buff_list) ||
					     dev->status != STATUS_STREAMING))
			goto error;
	}

265
	v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
266 267 268
		 "transmit worker exited\n");
	return;
error:
269
	v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
270 271 272 273 274 275 276 277
		 "transmit buffers errored\n");
	dev->status = STATUS_ERROR;
}

/* function expects dev->io_mutex to be hold by caller */
static int hdpvr_start_streaming(struct hdpvr_device *dev)
{
	int ret;
278
	struct hdpvr_video_info vidinf;
279 280 281

	if (dev->status == STATUS_STREAMING)
		return 0;
Hans Verkuil's avatar
Hans Verkuil committed
282
	if (dev->status != STATUS_IDLE)
283 284
		return -EAGAIN;

285
	ret = get_video_info(dev, &vidinf);
286 287 288 289
	if (ret < 0)
		return ret;

	if (!vidinf.valid) {
Hans Verkuil's avatar
Hans Verkuil committed
290 291 292 293 294
		msleep(250);
		v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
				"no video signal at input %d\n", dev->options.video_input);
		return -EAGAIN;
	}
295

Hans Verkuil's avatar
Hans Verkuil committed
296 297 298
	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
			"video signal: %dx%d@%dhz\n", vidinf.width,
			vidinf.height, vidinf.fps);
299

Hans Verkuil's avatar
Hans Verkuil committed
300 301 302 303 304 305 306 307
	/* start streaming 2 request */
	ret = usb_control_msg(dev->udev,
			usb_sndctrlpipe(dev->udev, 0),
			0xb8, 0x38, 0x1, 0, NULL, 0, 8000);
	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
			"encoder start control request returned %d\n", ret);
	if (ret < 0)
		return ret;
308

Hans Verkuil's avatar
Hans Verkuil committed
309 310 311
	ret = hdpvr_config_call(dev, CTRL_START_STREAMING_VALUE, 0x00);
	if (ret)
		return ret;
312

Hans Verkuil's avatar
Hans Verkuil committed
313
	dev->status = STATUS_STREAMING;
314

Hans Verkuil's avatar
Hans Verkuil committed
315
	INIT_WORK(&dev->worker, hdpvr_transmit_buffers);
316
	schedule_work(&dev->worker);
317

Hans Verkuil's avatar
Hans Verkuil committed
318 319
	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
			"streaming started\n");
320

Hans Verkuil's avatar
Hans Verkuil committed
321
	return 0;
322 323 324 325 326 327
}


/* function expects dev->io_mutex to be hold by caller */
static int hdpvr_stop_streaming(struct hdpvr_device *dev)
{
328 329
	int actual_length;
	uint c = 0;
330 331
	u8 *buf;

332 333 334 335 336
	if (dev->status == STATUS_IDLE)
		return 0;
	else if (dev->status != STATUS_STREAMING)
		return -EAGAIN;

337 338
	buf = kmalloc(dev->bulk_in_size, GFP_KERNEL);
	if (!buf)
339
		v4l2_err(&dev->v4l2_dev, "failed to allocate temporary buffer for emptying the internal device buffer. Next capture start will be slow\n");
340

341 342
	dev->status = STATUS_SHUTTING_DOWN;
	hdpvr_config_call(dev, CTRL_STOP_STREAMING_VALUE, 0x00);
343
	mutex_unlock(&dev->io_mutex);
344 345 346 347

	wake_up_interruptible(&dev->wait_buffer);
	msleep(50);

348
	flush_work(&dev->worker);
349

350
	mutex_lock(&dev->io_mutex);
351 352 353
	/* kill the still outstanding urbs */
	hdpvr_cancel_queue(dev);

354 355 356 357 358 359 360 361 362 363 364 365 366 367 368
	/* emptying the device buffer beforeshutting it down */
	while (buf && ++c < 500 &&
	       !usb_bulk_msg(dev->udev,
			     usb_rcvbulkpipe(dev->udev,
					     dev->bulk_in_endpointAddr),
			     buf, dev->bulk_in_size, &actual_length,
			     BULK_URB_TIMEOUT)) {
		v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
			 "%2d: got %d bytes\n", c, actual_length);
	}
	kfree(buf);
	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
		 "used %d urbs to empty device buffers\n", c-1);
	msleep(10);

369 370 371 372 373 374 375 376 377 378 379
	dev->status = STATUS_IDLE;

	return 0;
}


/*=======================================================================*/
/*
 * video 4 linux 2 file operations
 */

380 381 382 383 384 385 386 387 388 389 390 391 392
static int hdpvr_open(struct file *file)
{
	struct hdpvr_fh *fh = kzalloc(sizeof(*fh), GFP_KERNEL);

	if (fh == NULL)
		return -ENOMEM;
	fh->legacy_mode = true;
	v4l2_fh_init(&fh->fh, video_devdata(file));
	v4l2_fh_add(&fh->fh);
	file->private_data = fh;
	return 0;
}

393 394
static int hdpvr_release(struct file *file)
{
395
	struct hdpvr_device *dev = video_drvdata(file);
396 397

	mutex_lock(&dev->io_mutex);
398
	if (file->private_data == dev->owner) {
399
		hdpvr_stop_streaming(dev);
400 401
		dev->owner = NULL;
	}
402 403
	mutex_unlock(&dev->io_mutex);

404
	return v4l2_fh_release(file);
405 406 407 408 409 410 411 412 413
}

/*
 * hdpvr_v4l2_read()
 * will allocate buffers when called for the first time
 */
static ssize_t hdpvr_read(struct file *file, char __user *buffer, size_t count,
			  loff_t *pos)
{
414
	struct hdpvr_device *dev = video_drvdata(file);
415 416 417 418 419 420 421 422 423 424 425
	struct hdpvr_buffer *buf = NULL;
	struct urb *urb;
	unsigned int ret = 0;
	int rem, cnt;

	if (*pos)
		return -ESPIPE;

	mutex_lock(&dev->io_mutex);
	if (dev->status == STATUS_IDLE) {
		if (hdpvr_start_streaming(dev)) {
426 427
			v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
				 "start_streaming failed\n");
428 429 430 431 432 433
			ret = -EIO;
			msleep(200);
			dev->status = STATUS_IDLE;
			mutex_unlock(&dev->io_mutex);
			goto err;
		}
434
		dev->owner = file->private_data;
435
		print_buffer_status();
436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
	}
	mutex_unlock(&dev->io_mutex);

	/* wait for the first buffer */
	if (!(file->f_flags & O_NONBLOCK)) {
		if (wait_event_interruptible(dev->wait_data,
					     hdpvr_get_next_buffer(dev)))
			return -ERESTARTSYS;
	}

	buf = hdpvr_get_next_buffer(dev);

	while (count > 0 && buf) {

		if (buf->status != BUFSTAT_READY &&
		    dev->status != STATUS_DISCONNECTED) {
452
			int err;
453 454 455 456 457 458 459
			/* return nonblocking */
			if (file->f_flags & O_NONBLOCK) {
				if (!ret)
					ret = -EAGAIN;
				goto err;
			}

460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
			err = wait_event_interruptible_timeout(dev->wait_data,
				buf->status == BUFSTAT_READY,
				msecs_to_jiffies(1000));
			if (err < 0) {
				ret = err;
				goto err;
			}
			if (!err) {
				v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
					"timeout: restart streaming\n");
				hdpvr_stop_streaming(dev);
				msecs_to_jiffies(4000);
				err = hdpvr_start_streaming(dev);
				if (err) {
					ret = err;
					goto err;
				}
			}
478 479 480 481 482 483 484 485 486 487 488 489
		}

		if (buf->status != BUFSTAT_READY)
			break;

		/* set remaining bytes to copy */
		urb = buf->urb;
		rem = urb->actual_length - buf->pos;
		cnt = rem > count ? count : rem;

		if (copy_to_user(buffer, urb->transfer_buffer + buf->pos,
				 cnt)) {
490
			v4l2_err(&dev->v4l2_dev, "read: copy_to_user failed\n");
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
			if (!ret)
				ret = -EFAULT;
			goto err;
		}

		buf->pos += cnt;
		count -= cnt;
		buffer += cnt;
		ret += cnt;

		/* finished, take next buffer */
		if (buf->pos == urb->actual_length) {
			mutex_lock(&dev->io_mutex);
			buf->pos = 0;
			buf->status = BUFSTAT_AVAILABLE;

			list_move_tail(&buf->buff_list, &dev->free_buff_list);

509
			print_buffer_status();
510 511 512 513 514 515 516 517 518 519 520 521 522 523

			mutex_unlock(&dev->io_mutex);

			wake_up_interruptible(&dev->wait_buffer);

			buf = hdpvr_get_next_buffer(dev);
		}
	}
err:
	if (!ret && !buf)
		ret = -EAGAIN;
	return ret;
}

524
static __poll_t hdpvr_poll(struct file *filp, poll_table *wait)
525
{
526
	__poll_t req_events = poll_requested_events(wait);
527
	struct hdpvr_buffer *buf = NULL;
528
	struct hdpvr_device *dev = video_drvdata(filp);
529
	__poll_t mask = v4l2_ctrl_poll(filp, wait);
530

531
	if (!(req_events & (EPOLLIN | EPOLLRDNORM)))
532
		return mask;
533

534
	mutex_lock(&dev->io_mutex);
535 536 537

	if (dev->status == STATUS_IDLE) {
		if (hdpvr_start_streaming(dev)) {
538 539
			v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
				 "start_streaming failed\n");
540
			dev->status = STATUS_IDLE;
541 542
		} else {
			dev->owner = filp->private_data;
543 544
		}

545
		print_buffer_status();
546 547 548
	}
	mutex_unlock(&dev->io_mutex);

549 550 551 552 553
	buf = hdpvr_get_next_buffer(dev);
	/* only wait if no data is available */
	if (!buf || buf->status != BUFSTAT_READY) {
		poll_wait(filp, &dev->wait_data, wait);
		buf = hdpvr_get_next_buffer(dev);
554
	}
555
	if (buf && buf->status == BUFSTAT_READY)
556
		mask |= EPOLLIN | EPOLLRDNORM;
557 558 559 560 561 562 563

	return mask;
}


static const struct v4l2_file_operations hdpvr_fops = {
	.owner		= THIS_MODULE,
564
	.open		= hdpvr_open,
565 566 567
	.release	= hdpvr_release,
	.read		= hdpvr_read,
	.poll		= hdpvr_poll,
568
	.unlocked_ioctl	= video_ioctl2,
569 570 571 572 573 574 575 576 577 578 579 580 581
};

/*=======================================================================*/
/*
 * V4L2 ioctl handling
 */

static int vidioc_querycap(struct file *file, void  *priv,
			   struct v4l2_capability *cap)
{
	struct hdpvr_device *dev = video_drvdata(file);

	strcpy(cap->driver, "hdpvr");
582
	strcpy(cap->card, "Hauppauge HD PVR");
583
	usb_make_path(dev->udev, cap->bus_info, sizeof(cap->bus_info));
584 585 586
	cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_AUDIO |
			    V4L2_CAP_READWRITE;
	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
587 588 589
	return 0;
}

590
static int vidioc_s_std(struct file *file, void *_fh,
591
			v4l2_std_id std)
592
{
593
	struct hdpvr_device *dev = video_drvdata(file);
594
	struct hdpvr_fh *fh = _fh;
595 596
	u8 std_type = 1;

597
	if (!fh->legacy_mode && dev->options.video_input == HDPVR_COMPONENT)
598 599 600 601
		return -ENODATA;
	if (dev->status != STATUS_IDLE)
		return -EBUSY;
	if (std & V4L2_STD_525_60)
602
		std_type = 0;
603 604 605
	dev->cur_std = std;
	dev->width = 720;
	dev->height = std_type ? 576 : 480;
606 607 608 609

	return hdpvr_config_call(dev, CTRL_VIDEO_STD_TYPE, std_type);
}

610
static int vidioc_g_std(struct file *file, void *_fh,
611 612 613
			v4l2_std_id *std)
{
	struct hdpvr_device *dev = video_drvdata(file);
614
	struct hdpvr_fh *fh = _fh;
615

616
	if (!fh->legacy_mode && dev->options.video_input == HDPVR_COMPONENT)
617 618 619 620 621
		return -ENODATA;
	*std = dev->cur_std;
	return 0;
}

622
static int vidioc_querystd(struct file *file, void *_fh, v4l2_std_id *a)
623 624
{
	struct hdpvr_device *dev = video_drvdata(file);
625
	struct hdpvr_video_info vid_info;
626
	struct hdpvr_fh *fh = _fh;
627
	int ret;
628

629
	*a = V4L2_STD_UNKNOWN;
630 631
	if (dev->options.video_input == HDPVR_COMPONENT)
		return fh->legacy_mode ? 0 : -ENODATA;
632
	ret = get_video_info(dev, &vid_info);
633
	if (vid_info.valid && vid_info.width == 720 &&
634 635
	    (vid_info.height == 480 || vid_info.height == 576)) {
		*a = (vid_info.height == 480) ?
636 637
			V4L2_STD_525_60 : V4L2_STD_625_50;
	}
638
	return ret;
639 640
}

641 642 643 644 645 646 647 648 649 650 651 652 653
static int vidioc_s_dv_timings(struct file *file, void *_fh,
				    struct v4l2_dv_timings *timings)
{
	struct hdpvr_device *dev = video_drvdata(file);
	struct hdpvr_fh *fh = _fh;
	int i;

	fh->legacy_mode = false;
	if (dev->options.video_input)
		return -ENODATA;
	if (dev->status != STATUS_IDLE)
		return -EBUSY;
	for (i = 0; i < ARRAY_SIZE(hdpvr_dv_timings); i++)
654
		if (v4l2_match_dv_timings(timings, hdpvr_dv_timings + i, 0, false))
655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681
			break;
	if (i == ARRAY_SIZE(hdpvr_dv_timings))
		return -EINVAL;
	dev->cur_dv_timings = hdpvr_dv_timings[i];
	dev->width = hdpvr_dv_timings[i].bt.width;
	dev->height = hdpvr_dv_timings[i].bt.height;
	return 0;
}

static int vidioc_g_dv_timings(struct file *file, void *_fh,
				    struct v4l2_dv_timings *timings)
{
	struct hdpvr_device *dev = video_drvdata(file);
	struct hdpvr_fh *fh = _fh;

	fh->legacy_mode = false;
	if (dev->options.video_input)
		return -ENODATA;
	*timings = dev->cur_dv_timings;
	return 0;
}

static int vidioc_query_dv_timings(struct file *file, void *_fh,
				    struct v4l2_dv_timings *timings)
{
	struct hdpvr_device *dev = video_drvdata(file);
	struct hdpvr_fh *fh = _fh;
682
	struct hdpvr_video_info vid_info;
683 684 685 686 687 688 689
	bool interlaced;
	int ret = 0;
	int i;

	fh->legacy_mode = false;
	if (dev->options.video_input)
		return -ENODATA;
690 691
	ret = get_video_info(dev, &vid_info);
	if (ret)
692 693
		return ret;
	if (!vid_info.valid)
694
		return -ENOLCK;
695
	interlaced = vid_info.fps <= 30;
696 697 698 699 700 701
	for (i = 0; i < ARRAY_SIZE(hdpvr_dv_timings); i++) {
		const struct v4l2_bt_timings *bt = &hdpvr_dv_timings[i].bt;
		unsigned hsize;
		unsigned vsize;
		unsigned fps;

702 703
		hsize = V4L2_DV_BT_FRAME_WIDTH(bt);
		vsize = V4L2_DV_BT_FRAME_HEIGHT(bt);
704
		fps = (unsigned)bt->pixelclock / (hsize * vsize);
705 706
		if (bt->width != vid_info.width ||
		    bt->height != vid_info.height ||
707
		    bt->interlaced != interlaced ||
708
		    (fps != vid_info.fps && fps + 1 != vid_info.fps))
709 710 711 712 713 714
			continue;
		*timings = hdpvr_dv_timings[i];
		break;
	}
	if (i == ARRAY_SIZE(hdpvr_dv_timings))
		ret = -ERANGE;
715

716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755
	return ret;
}

static int vidioc_enum_dv_timings(struct file *file, void *_fh,
				    struct v4l2_enum_dv_timings *timings)
{
	struct hdpvr_device *dev = video_drvdata(file);
	struct hdpvr_fh *fh = _fh;

	fh->legacy_mode = false;
	memset(timings->reserved, 0, sizeof(timings->reserved));
	if (dev->options.video_input)
		return -ENODATA;
	if (timings->index >= ARRAY_SIZE(hdpvr_dv_timings))
		return -EINVAL;
	timings->timings = hdpvr_dv_timings[timings->index];
	return 0;
}

static int vidioc_dv_timings_cap(struct file *file, void *_fh,
				    struct v4l2_dv_timings_cap *cap)
{
	struct hdpvr_device *dev = video_drvdata(file);
	struct hdpvr_fh *fh = _fh;

	fh->legacy_mode = false;
	if (dev->options.video_input)
		return -ENODATA;
	cap->type = V4L2_DV_BT_656_1120;
	cap->bt.min_width = 720;
	cap->bt.max_width = 1920;
	cap->bt.min_height = 480;
	cap->bt.max_height = 1080;
	cap->bt.min_pixelclock = 27000000;
	cap->bt.max_pixelclock = 74250000;
	cap->bt.standards = V4L2_DV_BT_STD_CEA861;
	cap->bt.capabilities = V4L2_DV_BT_CAP_INTERLACED | V4L2_DV_BT_CAP_PROGRESSIVE;
	return 0;
}

756 757 758 759 760 761
static const char *iname[] = {
	[HDPVR_COMPONENT] = "Component",
	[HDPVR_SVIDEO]    = "S-Video",
	[HDPVR_COMPOSITE] = "Composite",
};

762
static int vidioc_enum_input(struct file *file, void *_fh, struct v4l2_input *i)
763 764 765 766 767 768 769 770 771 772 773 774 775 776
{
	unsigned int n;

	n = i->index;
	if (n >= HDPVR_VIDEO_INPUTS)
		return -EINVAL;

	i->type = V4L2_INPUT_TYPE_CAMERA;

	strncpy(i->name, iname[n], sizeof(i->name) - 1);
	i->name[sizeof(i->name) - 1] = '\0';

	i->audioset = 1<<HDPVR_RCA_FRONT | 1<<HDPVR_RCA_BACK | 1<<HDPVR_SPDIF;

777 778
	i->capabilities = n ? V4L2_IN_CAP_STD : V4L2_IN_CAP_DV_TIMINGS;
	i->std = n ? V4L2_STD_ALL : 0;
779 780 781 782

	return 0;
}

783
static int vidioc_s_input(struct file *file, void *_fh,
784 785
			  unsigned int index)
{
786
	struct hdpvr_device *dev = video_drvdata(file);
787 788 789 790 791 792
	int retval;

	if (index >= HDPVR_VIDEO_INPUTS)
		return -EINVAL;

	if (dev->status != STATUS_IDLE)
Hans Verkuil's avatar
Hans Verkuil committed
793
		return -EBUSY;
794 795

	retval = hdpvr_config_call(dev, CTRL_VIDEO_INPUT_VALUE, index+1);
796
	if (!retval) {
797
		dev->options.video_input = index;
798 799 800 801 802 803 804 805 806 807 808
		/*
		 * Unfortunately gstreamer calls ENUMSTD and bails out if it
		 * won't find any formats, even though component input is
		 * selected. This means that we have to leave tvnorms at
		 * V4L2_STD_ALL. We cannot use the 'legacy' trick since
		 * tvnorms is set at the device node level and not at the
		 * filehandle level.
		 *
		 * Comment this out for now, but if the legacy mode can be
		 * removed in the future, then this code should be enabled
		 * again.
809
		dev->video_dev.tvnorms =
810 811
			(index != HDPVR_COMPONENT) ? V4L2_STD_ALL : 0;
		 */
812
	}
813 814 815 816 817 818 819

	return retval;
}

static int vidioc_g_input(struct file *file, void *private_data,
			  unsigned int *index)
{
820
	struct hdpvr_device *dev = video_drvdata(file);
821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850

	*index = dev->options.video_input;
	return 0;
}


static const char *audio_iname[] = {
	[HDPVR_RCA_FRONT] = "RCA front",
	[HDPVR_RCA_BACK]  = "RCA back",
	[HDPVR_SPDIF]     = "SPDIF",
};

static int vidioc_enumaudio(struct file *file, void *priv,
				struct v4l2_audio *audio)
{
	unsigned int n;

	n = audio->index;
	if (n >= HDPVR_AUDIO_INPUTS)
		return -EINVAL;

	audio->capability = V4L2_AUDCAP_STEREO;

	strncpy(audio->name, audio_iname[n], sizeof(audio->name) - 1);
	audio->name[sizeof(audio->name) - 1] = '\0';

	return 0;
}

static int vidioc_s_audio(struct file *file, void *private_data,
851
			  const struct v4l2_audio *audio)
852
{
853
	struct hdpvr_device *dev = video_drvdata(file);
854 855 856 857 858 859
	int retval;

	if (audio->index >= HDPVR_AUDIO_INPUTS)
		return -EINVAL;

	if (dev->status != STATUS_IDLE)
Hans Verkuil's avatar
Hans Verkuil committed
860
		return -EBUSY;
861 862 863 864 865 866 867 868 869 870 871

	retval = hdpvr_set_audio(dev, audio->index+1, dev->options.audio_codec);
	if (!retval)
		dev->options.audio_input = audio->index;

	return retval;
}

static int vidioc_g_audio(struct file *file, void *private_data,
			  struct v4l2_audio *audio)
{
872
	struct hdpvr_device *dev = video_drvdata(file);
873 874 875

	audio->index = dev->options.audio_input;
	audio->capability = V4L2_AUDCAP_STEREO;
876
	strlcpy(audio->name, audio_iname[audio->index], sizeof(audio->name));
877 878 879 880
	audio->name[sizeof(audio->name) - 1] = '\0';
	return 0;
}

881
static int hdpvr_try_ctrl(struct v4l2_ctrl *ctrl)
882
{
883 884
	struct hdpvr_device *dev =
		container_of(ctrl->handler, struct hdpvr_device, hdl);
885 886

	switch (ctrl->id) {
887 888 889 890 891
	case V4L2_CID_MPEG_VIDEO_BITRATE_MODE:
		if (ctrl->val == V4L2_MPEG_VIDEO_BITRATE_MODE_VBR &&
		    dev->video_bitrate->val >= dev->video_bitrate_peak->val)
			dev->video_bitrate_peak->val =
					dev->video_bitrate->val + 100000;
892 893 894 895 896
		break;
	}
	return 0;
}

897
static int hdpvr_s_ctrl(struct v4l2_ctrl *ctrl)
898
{
899 900 901 902
	struct hdpvr_device *dev =
		container_of(ctrl->handler, struct hdpvr_device, hdl);
	struct hdpvr_options *opt = &dev->options;
	int ret = -EINVAL;
903 904 905

	switch (ctrl->id) {
	case V4L2_CID_BRIGHTNESS:
906 907 908 909 910
		ret = hdpvr_config_call(dev, CTRL_BRIGHTNESS, ctrl->val);
		if (ret)
			break;
		dev->options.brightness = ctrl->val;
		return 0;
911
	case V4L2_CID_CONTRAST:
912 913 914 915 916
		ret = hdpvr_config_call(dev, CTRL_CONTRAST, ctrl->val);
		if (ret)
			break;
		dev->options.contrast = ctrl->val;
		return 0;
917
	case V4L2_CID_SATURATION:
918 919 920 921 922
		ret = hdpvr_config_call(dev, CTRL_SATURATION, ctrl->val);
		if (ret)
			break;
		dev->options.saturation = ctrl->val;
		return 0;
923
	case V4L2_CID_HUE:
924 925 926 927 928
		ret = hdpvr_config_call(dev, CTRL_HUE, ctrl->val);
		if (ret)
			break;
		dev->options.hue = ctrl->val;
		return 0;
929
	case V4L2_CID_SHARPNESS:
930 931 932 933 934
		ret = hdpvr_config_call(dev, CTRL_SHARPNESS, ctrl->val);
		if (ret)
			break;
		dev->options.sharpness = ctrl->val;
		return 0;
935 936
	case V4L2_CID_MPEG_AUDIO_ENCODING:
		if (dev->flags & HDPVR_FLAG_AC3_CAP) {
937
			opt->audio_codec = ctrl->val;
938
			return hdpvr_set_audio(dev, opt->audio_input + 1,
939 940
					      opt->audio_codec);
		}
941
		return 0;
942
	case V4L2_CID_MPEG_VIDEO_ENCODING:
943
		return 0;
944 945 946 947 948 949 950 951 952 953 954 955
/*	case V4L2_CID_MPEG_VIDEO_B_FRAMES: */
/*		if (ctrl->value == 0 && !(opt->gop_mode & 0x2)) { */
/*			opt->gop_mode |= 0x2; */
/*			hdpvr_config_call(dev, CTRL_GOP_MODE_VALUE, */
/*					  opt->gop_mode); */
/*		} */
/*		if (ctrl->value == 128 && opt->gop_mode & 0x2) { */
/*			opt->gop_mode &= ~0x2; */
/*			hdpvr_config_call(dev, CTRL_GOP_MODE_VALUE, */
/*					  opt->gop_mode); */
/*		} */
/*		break; */
956 957 958 959 960 961 962 963 964
	case V4L2_CID_MPEG_VIDEO_BITRATE_MODE: {
		uint peak_bitrate = dev->video_bitrate_peak->val / 100000;
		uint bitrate = dev->video_bitrate->val / 100000;

		if (ctrl->is_new) {
			if (ctrl->val == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR)
				opt->bitrate_mode = HDPVR_CONSTANT;
			else
				opt->bitrate_mode = HDPVR_VARIABLE_AVERAGE;
965 966
			hdpvr_config_call(dev, CTRL_BITRATE_MODE_VALUE,
					  opt->bitrate_mode);
967 968
			v4l2_ctrl_activate(dev->video_bitrate_peak,
				ctrl->val != V4L2_MPEG_VIDEO_BITRATE_MODE_CBR);
969 970
		}

971 972 973
		if (dev->video_bitrate_peak->is_new ||
		    dev->video_bitrate->is_new) {
			opt->bitrate = bitrate;
974 975
			opt->peak_bitrate = peak_bitrate;
			hdpvr_set_bitrate(dev);
976 977
		}
		return 0;
978 979
	}
	case V4L2_CID_MPEG_STREAM_TYPE:
980
		return 0;
981
	default:
982
		break;
983 984 985 986 987 988 989
	}
	return ret;
}

static int vidioc_enum_fmt_vid_cap(struct file *file, void *private_data,
				    struct v4l2_fmtdesc *f)
{
Hans Verkuil's avatar
Hans Verkuil committed
990
	if (f->index != 0)
991 992 993 994 995 996 997 998 999
		return -EINVAL;

	f->flags = V4L2_FMT_FLAG_COMPRESSED;
	strncpy(f->description, "MPEG2-TS with AVC/AAC streams", 32);
	f->pixelformat = V4L2_PIX_FMT_MPEG;

	return 0;
}

1000
static int vidioc_g_fmt_vid_cap(struct file *file, void *_fh,
1001 1002
				struct v4l2_format *f)
{
1003
	struct hdpvr_device *dev = video_drvdata(file);
1004
	struct hdpvr_fh *fh = _fh;
1005
	int ret;
1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017

	/*
	 * The original driver would always returns the current detected
	 * resolution as the format (and EFAULT if it couldn't be detected).
	 * With the introduction of VIDIOC_QUERY_DV_TIMINGS there is now a
	 * better way of doing this, but to stay compatible with existing
	 * applications we assume legacy mode every time an application opens
	 * the device. Only if one of the new DV_TIMINGS ioctls is called
	 * will the filehandle go into 'normal' mode where g_fmt returns the
	 * last set format.
	 */
	if (fh->legacy_mode) {
1018
		struct hdpvr_video_info vid_info;
1019

1020
		ret = get_video_info(dev, &vid_info);
1021 1022 1023
		if (ret < 0)
			return ret;
		if (!vid_info.valid)
1024
			return -EFAULT;
1025 1026
		f->fmt.pix.width = vid_info.width;
		f->fmt.pix.height = vid_info.height;
1027 1028 1029 1030
	} else {
		f->fmt.pix.width = dev->width;
		f->fmt.pix.height = dev->height;
	}
1031 1032 1033
	f->fmt.pix.pixelformat	= V4L2_PIX_FMT_MPEG;
	f->fmt.pix.sizeimage	= dev->bulk_in_size;
	f->fmt.pix.bytesperline	= 0;
1034 1035 1036 1037 1038 1039
	if (f->fmt.pix.width == 720) {
		/* SDTV formats */
		f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
		f->fmt.pix.field = V4L2_FIELD_INTERLACED;
	} else {
		/* HDTV formats */
1040
		f->fmt.pix.colorspace = V4L2_COLORSPACE_REC709;
1041 1042
		f->fmt.pix.field = V4L2_FIELD_NONE;
	}
1043 1044 1045
	return 0;
}

1046 1047 1048
static int vidioc_encoder_cmd(struct file *filp, void *priv,
			       struct v4l2_encoder_cmd *a)
{
1049 1050
	struct hdpvr_device *dev = video_drvdata(filp);
	int res = 0;
1051 1052

	mutex_lock(&dev->io_mutex);
1053
	a->flags = 0;
1054 1055 1056

	switch (a->cmd) {
	case V4L2_ENC_CMD_START:
1057 1058 1059 1060 1061 1062
		if (dev->owner && filp->private_data != dev->owner) {
			res = -EBUSY;
			break;
		}
		if (dev->status == STATUS_STREAMING)
			break;
1063
		res = hdpvr_start_streaming(dev);
1064 1065 1066 1067
		if (!res)
			dev->owner = filp->private_data;
		else
			dev->status = STATUS_IDLE;
1068 1069
		break;
	case V4L2_ENC_CMD_STOP:
1070 1071 1072 1073 1074 1075
		if (dev->owner && filp->private_data != dev->owner) {
			res = -EBUSY;
			break;
		}
		if (dev->status == STATUS_IDLE)
			break;
1076
		res = hdpvr_stop_streaming(dev);
1077 1078
		if (!res)
			dev->owner = NULL;
1079 1080
		break;
	default:
1081
		v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
1082
			 "Unsupported encoder cmd %d\n", a->cmd);
1083
		res = -EINVAL;
1084
		break;
1085
	}
1086

1087 1088 1089 1090 1091 1092 1093
	mutex_unlock(&dev->io_mutex);
	return res;
}

static int vidioc_try_encoder_cmd(struct file *filp, void *priv,
					struct v4l2_encoder_cmd *a)
{
1094
	a->flags = 0;
1095 1096 1097 1098 1099 1100 1101 1102
	switch (a->cmd) {
	case V4L2_ENC_CMD_START:
	case V4L2_ENC_CMD_STOP:
		return 0;
	default:
		return -EINVAL;
	}
}
1103 1104 1105 1106

static const struct v4l2_ioctl_ops hdpvr_ioctl_ops = {
	.vidioc_querycap	= vidioc_querycap,
	.vidioc_s_std		= vidioc_s_std,
1107 1108
	.vidioc_g_std		= vidioc_g_std,
	.vidioc_querystd	= vidioc_querystd,
1109 1110 1111 1112 1113
	.vidioc_s_dv_timings	= vidioc_s_dv_timings,
	.vidioc_g_dv_timings	= vidioc_g_dv_timings,
	.vidioc_query_dv_timings= vidioc_query_dv_timings,
	.vidioc_enum_dv_timings	= vidioc_enum_dv_timings,
	.vidioc_dv_timings_cap	= vidioc_dv_timings_cap,
1114 1115 1116 1117 1118 1119
	.vidioc_enum_input	= vidioc_enum_input,
	.vidioc_g_input		= vidioc_g_input,
	.vidioc_s_input		= vidioc_s_input,
	.vidioc_enumaudio	= vidioc_enumaudio,
	.vidioc_g_audio		= vidioc_g_audio,
	.vidioc_s_audio		= vidioc_s_audio,
1120 1121
	.vidioc_enum_fmt_vid_cap= vidioc_enum_fmt_vid_cap,
	.vidioc_g_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
1122 1123
	.vidioc_s_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
	.vidioc_try_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
1124 1125
	.vidioc_encoder_cmd	= vidioc_encoder_cmd,
	.vidioc_try_encoder_cmd	= vidioc_try_encoder_cmd,
1126 1127 1128
	.vidioc_log_status	= v4l2_ctrl_log_status,
	.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
	.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
1129 1130 1131 1132 1133 1134 1135
};

static void hdpvr_device_release(struct video_device *vdev)
{
	struct hdpvr_device *dev = video_get_drvdata(vdev);

	hdpvr_delete(dev);
1136
	mutex_lock(&dev->io_mutex);
1137
	flush_work(&dev->worker);
1138 1139 1140
	mutex_unlock(&dev->io_mutex);

	v4l2_device_unregister(&dev->v4l2_dev);
1141
	v4l2_ctrl_handler_free(&dev->hdl);
1142 1143

	/* deregister I2C adapter */
1144
#if IS_ENABLED(CONFIG_I2C)
1145
	mutex_lock(&dev->i2c_mutex);
Jarod Wilson's avatar
Jarod Wilson committed
1146
	i2c_del_adapter(&dev->i2c_adapter);
1147 1148 1149 1150 1151
	mutex_unlock(&dev->i2c_mutex);
#endif /* CONFIG_I2C */

	kfree(dev->usbc_buf);
	kfree(dev);
1152 1153 1154 1155 1156
}

static const struct video_device hdpvr_video_template = {
	.fops			= &hdpvr_fops,
	.release		= hdpvr_device_release,
1157
	.ioctl_ops		= &hdpvr_ioctl_ops,
1158
	.tvnorms		= V4L2_STD_ALL,
1159 1160
};

1161 1162 1163 1164 1165
static const struct v4l2_ctrl_ops hdpvr_ctrl_ops = {
	.try_ctrl = hdpvr_try_ctrl,
	.s_ctrl = hdpvr_s_ctrl,
};

1166 1167
int hdpvr_register_videodev(struct hdpvr_device *dev, struct device *parent,
			    int devnum)
1168
{
1169 1170 1171 1172
	struct v4l2_ctrl_handler *hdl = &dev->hdl;
	bool ac3 = dev->flags & HDPVR_FLAG_AC3_CAP;
	int res;

1173 1174 1175
	dev->cur_std = V4L2_STD_525_60;
	dev->width = 720;
	dev->height = 480;
1176
	dev->cur_dv_timings = hdpvr_dv_timings[HDPVR_DEF_DV_TIMINGS_IDX];
1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208
	v4l2_ctrl_handler_init(hdl, 11);
	if (dev->fw_ver > 0x15) {
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_BRIGHTNESS, 0x0, 0xff, 1, 0x80);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_CONTRAST, 0x0, 0xff, 1, 0x40);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_SATURATION, 0x0, 0xff, 1, 0x40);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_HUE, 0x0, 0x1e, 1, 0xf);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_SHARPNESS, 0x0, 0xff, 1, 0x80);
	} else {
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_BRIGHTNESS, 0x0, 0xff, 1, 0x86);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_CONTRAST, 0x0, 0xff, 1, 0x80);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_SATURATION, 0x0, 0xff, 1, 0x80);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_HUE, 0x0, 0xff, 1, 0x80);
		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
			V4L2_CID_SHARPNESS, 0x0, 0xff, 1, 0x80);
	}

	v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
		V4L2_CID_MPEG_STREAM_TYPE,
		V4L2_MPEG_STREAM_TYPE_MPEG2_TS,
		0x1, V4L2_MPEG_STREAM_TYPE_MPEG2_TS);
	v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
		V4L2_CID_MPEG_AUDIO_ENCODING,
		ac3 ? V4L2_MPEG_AUDIO_ENCODING_AC3 : V4L2_MPEG_AUDIO_ENCODING_AAC,
1209
		0x7, ac3 ? dev->options.audio_codec : V4L2_MPEG_AUDIO_ENCODING_AAC);
1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
	v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
		V4L2_CID_MPEG_VIDEO_ENCODING,
		V4L2_MPEG_VIDEO_ENCODING_MPEG_4_AVC, 0x3,
		V4L2_MPEG_VIDEO_ENCODING_MPEG_4_AVC);

	dev->video_mode = v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
		V4L2_CID_MPEG_VIDEO_BITRATE_MODE,
		V4L2_MPEG_VIDEO_BITRATE_MODE_CBR, 0,
		V4L2_MPEG_VIDEO_BITRATE_MODE_CBR);

	dev->video_bitrate = v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
		V4L2_CID_MPEG_VIDEO_BITRATE,
		1000000, 13500000, 100000, 6500000);
	dev->video_bitrate_peak = v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
		V4L2_CID_MPEG_VIDEO_BITRATE_PEAK,
		1100000, 20200000, 100000, 9000000);
	dev->v4l2_dev.ctrl_handler = hdl;
	if (hdl->error) {
		res = hdl->error;
		v4l2_err(&dev->v4l2_dev, "Could not register controls\n");
		goto error;
	}
	v4l2_ctrl_cluster(3, &dev->video_mode);
	res = v4l2_ctrl_handler_setup(hdl);
	if (res < 0) {
		v4l2_err(&dev->v4l2_dev, "Could not setup controls\n");
		goto error;
	}

1239
	/* setup and register video device */
1240 1241 1242 1243
	dev->video_dev = hdpvr_video_template;
	strcpy(dev->video_dev.name, "Hauppauge HD PVR");
	dev->video_dev.v4l2_dev = &dev->v4l2_dev;
	video_set_drvdata(&dev->video_dev, dev);
1244

1245
	res = video_register_device(&dev->video_dev, VFL_TYPE_GRABBER, devnum);
1246
	if (res < 0) {
1247
		v4l2_err(&dev->v4l2_dev, "video_device registration failed\n");
1248 1249 1250 1251 1252
		goto error;
	}

	return 0;
error:
1253 1254
	v4l2_ctrl_handler_free(hdl);
	return res;
1255
}