• Eric Miao's avatar
    hwmon: (max1111) Change sysfs interface to in[0-3]_input in millivolts · 012f3b91
    Eric Miao authored
    This patch fixed the inconsistent max1111 sysfs interface as pointed
    out by Jean Delvare:
    
        It was pointed to me that the max1111 driver doesn't implement the
        standard sysfs interface for hwmon drivers (as described in
        Documentation/hwmon/sysfs-interface). It exports files adc[0-3]_in,
        which
        aren't part of the standard interface. Presumably these should be
        renamed to in[0-3]_input. Renaming them is probably not sufficient
        though, as I see no scaling done in the driver. As the MAX1111 chip has
        a documented full scale of 2.048V, I take it that the LSB of the ADC
        has a weight of 8 mV. Exporting raw register values to user-space is
        not OK.
    Reported-by: default avatarJean Delvare <khali@linux-fr.org>
    Signed-off-by: default avatarEric Miao <eric.y.miao@gmail.com>
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    012f3b91
max1111.c 5.65 KB