• Arnd Bergmann's avatar
    ASoC: loongson: fix address space confusion · 012fa262
    Arnd Bergmann authored
    The i2s driver uses the mapped __iomem address of the FIFO as the DMA
    address for the device. This apparently works on loongarch because of
    the way it handles __iomem pointers as aliases of physical addresses,
    but this is not portable to other architectures and causes a compiler
    warning when dma addresses are not the same size as pointers:
    
    sound/soc/loongson/loongson_i2s_pci.c: In function 'loongson_i2s_pci_probe':
    sound/soc/loongson/loongson_i2s_pci.c:110:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
      110 |         tx_data->dev_addr = (dma_addr_t)i2s->reg_base + LS_I2S_TX_DATA;
          |                             ^
    sound/soc/loongson/loongson_i2s_pci.c:113:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
      113 |         rx_data->dev_addr = (dma_addr_t)i2s->reg_base + LS_I2S_RX_DATA;
          |                             ^
    
    Change the driver to instead use the physical address as stored in the
    PCI BAR resource directly. Since 'dev_addr' is a 32-bit address, I think
    this results in the same truncated address on loongarch but is otherwise
    closer to portable code and avoids the warning.
    
    Fixes: d84881e0 ("ASoC: Add support for Loongson I2S controller")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/Message-Id: <20230622101235.3230941-1-arnd@kernel.org>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    012fa262
loongson_i2s_pci.c 4.06 KB